Patchworkβ Add coreboot IDs to make manual selection of HP xw9400 possible

login
register
about
Submitter Michael Karcher
Date 2010-06-02 07:08:31
Message ID <1275462511-26976-1-git-send-email-flashrom@mkarcher.dialup.fu-berlin.de>
Download mbox | patch
Permalink /patch/1442/
State Accepted
Commit r1267
Headers show

Comments

Michael Karcher - 2010-06-02 07:08:31
Hi Nilse-Helge,

you experience problems trying to flash back to the HP BIOS, because with
the original Tyan BIOS, flashrom is unable to detect you have the HP OEM 
version of the board. This is why flashrom does not remove write protection
anymore. The attached patch adds a coreboot ID for the HP xw9400 board, which
makes it possible to tell flashrom you are on an xw9400 from the command line.

After applying this patch, run
   
flashrom -m hp:xw9400 -w hpbios.bin

This should return you to the original HP BIOS if the boot block write
enable jumper is shorted (the two pins next to F2), or bring you into    
big trouble if the boot block is still write protected.

Regards,
  Michael Karcher

---
 board_enable.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Carl-Daniel Hailfinger - 2011-03-05 23:22:53
[stripped all people from CC, because it is unlikely they are still
interested]

Auf 02.06.2010 09:08, Michael Karcher schrieb:
> you experience problems trying to flash back to the HP BIOS, because with
> the original Tyan BIOS, flashrom is unable to detect you have the HP OEM 
> version of the board. This is why flashrom does not remove write protection
> anymore. The attached patch adds a coreboot ID for the HP xw9400 board, which
> makes it possible to tell flashrom you are on an xw9400 from the command line.
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

Regards,
Carl-Daniel
Michael Karcher - 2011-03-06 19:00:53
Am Sonntag, den 06.03.2011, 00:22 +0100 schrieb Carl-Daniel Hailfinger:
> > anymore. The attached patch adds a coreboot ID for the HP xw9400 board, which
> > makes it possible to tell flashrom you are on an xw9400 from the command line.
> >   
> 
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

Comitted in 1267, thanks for your review.

Regards,
  Michael Karcher

Patch

diff --git a/board_enable.c b/board_enable.c
index 69de0f9..a1867be 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -1469,7 +1469,7 @@  struct board_pciid_enable board_pciid_enables[] = {
 	{0x1166, 0x0223, 0x103c, 0x320d,  0x102b, 0x0522, 0x103c, 0x31fa, NULL,          "hp",         "dl145_g3",    "HP",          "DL145 G3",              0,   OK, board_hp_dl145_g3_enable},
 	{0x8086, 0x2415, 0x103c, 0x1249,  0x10b7, 0x9200, 0x103c, 0x1246, NULL,          NULL,         NULL,          "HP",          "Vectra VL400",          0,   OK, board_hp_vl400}, 
 	{0x8086, 0x1a30, 0x103c, 0x1a30,  0x8086, 0x2443, 0x103c, 0x2440, "^VL420$",     NULL,         NULL,          "HP",          "VL420 SFF",             0,   OK, intel_ich_gpio22_raise},
-	{0x10de, 0x0369, 0x103c, 0x12fe,  0x10de, 0x0364, 0x103c, 0x12fe, NULL,          NULL,         NULL,          "HP",          "xw9400",                0,   OK, nvidia_mcp_gpio5_raise},
+	{0x10de, 0x0369, 0x103c, 0x12fe,  0x10de, 0x0364, 0x103c, 0x12fe, NULL,          "hp",         "xw9400",      "HP",          "xw9400",                0,   OK, nvidia_mcp_gpio5_raise},
 	{0x8086, 0x27A0,      0,      0,  0x8086, 0x27B9,      0,      0, NULL,          "ibase",      "mb899",       "iBASE",       "MB899",                 0,   NT, intel_ich_gpio26_raise},
 	{0x1166, 0x0205, 0x1014, 0x0347,  0x1002, 0x515E, 0x1014, 0x0325, NULL,          NULL,         NULL,          "IBM",         "x3455",                 0,   OK, board_ibm_x3455},
 	{0x1039, 0x5513, 0x8086, 0xd61f,  0x1039, 0x6330, 0x8086, 0xd61f, NULL,          NULL,         NULL,          "Intel",       "D201GLY",               0,   OK, wbsio_check_for_spi},