From patchwork Wed Jun 23 06:49:57 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Neuter probe for ITE SuperIO
Date: Wed, 23 Jun 2010 05:49:57 -0000
From: Ed Swierk <eswierk@aristanetworks.com>
X-Patchwork-Id: 1543
Message-Id: <1277275797.20870.14.camel@localhost.localdomain>
To: flashrom@flashrom.org

If the system has an SMSC LPC47N217N SuperIO, enter_conf_mode_ite()
enters configuration mode, and then exit_conf_mode_ite() kills power to
the serial UART.

I don't know if there is a proper way to detect what kind of SuperIO the
system has, but probe_superio_ite() is unsafe in its current form.

Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>

---


Index: flashrom-0.9.2-r1057/internal.c
===================================================================
--- flashrom-0.9.2-r1057.orig/internal.c
+++ flashrom-0.9.2-r1057/internal.c
@@ -104,7 +104,10 @@ struct superio superio = {};
 
 void probe_superio(void)
 {
+#if 0
+	/* ITE probe causes SMSC LPC47N217 to power off the serial UART! */
 	superio = probe_superio_ite();
+#endif
 #if 0
 	/* Winbond Super I/O code is not yet available. */
 	if (superio.vendor == SUPERIO_VENDOR_NONE)