Patchworkβ Add FEATURE_WRSR_WREN to feature_bits for most AMIC SPI flash chips

login
register
about
Submitter David Hendricks
Date 2010-08-13 21:48:29
Message ID <AANLkTi=zMZ1QMYUrjt9Ust0HVwpAmtSOUEv2qNK472T8@mail.gmail.com>
Download mbox | patch
Permalink /patch/1740/
State Accepted
Commit r1149
Headers show

Comments

David Hendricks - 2010-08-13 21:48:29
This patch adds FEATURE_WRSR_WREN to the feature bits for most AMIC SPI
flash chips. I was unable to find datasheets for all of the chips, but the
datasheets presently on http://www.amictechnology.com/ indicate that the SPI
flash chips use WREN.

Signed-off-by: David Hendricks <dhendrix@google.com>
Carl-Daniel Hailfinger - 2010-09-03 03:32:59
On 13.08.2010 23:48, David Hendricks wrote:
> This patch adds FEATURE_WRSR_WREN to the feature bits for most AMIC SPI
> flash chips. 

Thanks for your patch.


> I was unable to find datasheets for all of the chips, but the
> datasheets presently on http://www.amictechnology.com/ indicate that the SPI
> flash chips use WREN.
>   

AFAICS this patch only changes the subset of the AMIC SPI flash chips
for which you had datasheets. I own datasheets for at least
A25L010 A25L016 A25L016_ver10 A25L020 A25L032 A25L032_ver00 A25L040
A25L040_ver10 A25L05P A25L080 A25L080_ver10 A25L10P A25L16P A25L20P
A25L40P A25L512 A25L80P A25LQ032
and someone else might own all other relevant datasheets.
A followup patch with the remaining chips would be appreciated (or if
you need specific datasheets, a call for the datasheets you need).

> Signed-off-by: David Hendricks <dhendrix@google.com>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
and committed in r1149.

Regards,
Carl-Daniel

Patch

Index: flashrom-head/flashchips.c
===================================================================
--- flashrom-head.orig/flashchips.c
+++ flashrom-head/flashchips.c
@@ -643,6 +643,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25L512,
 		.total_size	= 64,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -672,6 +673,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25L010,
 		.total_size	= 128,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -701,6 +703,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25L020,
 		.total_size	= 256,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -730,6 +733,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25L040,
 		.total_size	= 512,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -759,6 +763,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25L080,
 		.total_size	= 1024,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -788,6 +793,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25L016,
 		.total_size	= 2048,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -817,6 +823,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25L032,
 		.total_size	= 4096,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -852,6 +859,7 @@  struct flashchip flashchips[] = {
 		.model_id	= AMIC_A25LQ032,
 		.total_size	= 4096,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,