Patchworkβ Board enable for P4P800

login
register
about
Submitter Michael Karcher
Date 2010-08-15 16:33:44
Message ID <1281890024-15453-1-git-send-email-flashrom@mkarcher.dialup.fu-berlin.de>
Download mbox | patch
Permalink /patch/1744/
State Accepted
Commit 1157
Headers show

Comments

Michael Karcher - 2010-08-15 16:33:44
lspci/superiotool:
  http://www.coreboot.org/pipermail/flashrom/2010-August/004436.html

This goes the safe route of adding a match for the P4P800 that does not
match the P4P800-E Deluxe which is already in.  It seems quite likely that
the whole P4P800 family could use the same board enable with one generic
board enable match, though.

This match uses host bridge + audio, because all other IDs match the
P4P800-E Deluxe board, as reported in
 http://www.e-monkeys.de/Everest-Bericht.txt

Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
---
 board_enable.c |    2 ++
 print.c        |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)
Uwe Hermann - 2010-09-07 18:25:07
On Sun, Aug 15, 2010 at 06:33:44PM +0200, Michael Karcher wrote:
> lspci/superiotool:
>   http://www.coreboot.org/pipermail/flashrom/2010-August/004436.html
> 
> This goes the safe route of adding a match for the P4P800 that does not
> match the P4P800-E Deluxe which is already in.  It seems quite likely that
> the whole P4P800 family could use the same board enable with one generic
> board enable match, though.
> 
> This match uses host bridge + audio, because all other IDs match the
> P4P800-E Deluxe board, as reported in
>  http://www.e-monkeys.de/Everest-Bericht.txt
> 
> Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>

No user feedback so far, feel free to commit as untested for now.

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>


Uwe.
Michael Karcher - 2010-09-10 14:55:15
Am Dienstag, den 07.09.2010, 20:25 +0200 schrieb Uwe Hermann:
> > Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
> No user feedback so far, feel free to commit as untested for now.
> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>

Thanks for acking.
Committed as untested in r1157.

Regards,
  Michael Karcher

Patch

diff --git a/board_enable.c b/board_enable.c
index 5e0294b..d6da14b 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -1315,6 +1315,7 @@  static int intel_ich_gpio19_raise(void)
  * Suited for:
  *  - ASUS P4B266LM (Sony Vaio PCV-RX650): socket478 + 845D + ICH2
  *  - ASUS P4C800-E Deluxe: socket478 + 875P + ICH5
+ *  - ASUS P4P800: Intel socket478 + 865PE + ICH5R
  *  - ASUS P4P800-E Deluxe: Intel socket478 + 865PE + ICH5R
  *  - ASUS P5PE-VM: Intel LGA775 + 865G + ICH5
  *  - Samsung Polaris 32: socket478 + 865P + ICH5
@@ -1768,6 +1769,7 @@  const struct board_pciid_enable board_pciid_enables[] = {
 	{0x8086, 0x1a30, 0x1043, 0x8070,  0x8086, 0x244b, 0x1043, 0x8028, NULL,          NULL,         NULL,          "ASUS",        "P4B266",                0,   OK, intel_ich_gpio22_raise},
 	{0x8086, 0x1A30, 0x1043, 0x8088,  0x8086, 0x24C3, 0x1043, 0x8089, NULL,          NULL,         NULL,          "ASUS",        "P4B533-E",              0,   NT, intel_ich_gpio22_raise},
 	{0x8086, 0x24D3, 0x1043, 0x80A6,  0x8086, 0x2578, 0x1043, 0x80F6, NULL,          NULL,         NULL,          "ASUS",        "P4C800-E Deluxe",       0,   OK, intel_ich_gpio21_raise},
+	{0x8086, 0x2570, 0x1043, 0x80F2,  0x8086, 0x24D5, 0x1043, 0x80F3, NULL,          NULL,         NULL,          "ASUS",        "P4P800",                0,   OK, intel_ich_gpio21_raise},
 	{0x8086, 0x2570, 0x1043, 0x80F2,  0x105A, 0x3373, 0x1043, 0x80F5, NULL,          NULL,         NULL,          "ASUS",        "P4P800-E Deluxe",       0,   OK, intel_ich_gpio21_raise},
 	{0x8086, 0x2570, 0x1043, 0x80A5,  0x105A, 0x24D3, 0x1043, 0x80A6, NULL,          NULL,         NULL,          "ASUS",        "P4SD-LA",               0,   NT, intel_ich_gpio32_raise},
 	{0x1039, 0x0661, 0x1043, 0x8113,  0x1039, 0x5513, 0x1043, 0x8087, NULL,          NULL,         NULL,          "ASUS",        "P4S800-MX",             512, OK, w836xx_memw_enable_2e},
diff --git a/print.c b/print.c
index d8ba1ec..d48b7fb 100644
--- a/print.c
+++ b/print.c
@@ -348,6 +348,7 @@  const struct board_info boards_known[] = {
 	B("ASUS",	"P4B266",		1, "ftp://ftp.asus.com.tw/pub/ASUS/mb/sock478/p4b266/", NULL),
 	B("ASUS",	"P4B266-LM",		1, "http://esupport.sony.com/US/perl/swu-list.pl?mdl=PCVRX650", NULL),
 	B("ASUS",	"P4C800-E Deluxe",	1, "http://www.asus.com/product.aspx?P_ID=cFuVCr9bXXCckmcK", NULL),
+	B("ASUS",	"P4P800",		1, "http://www.asus.com/product.aspx?P_ID=DYt1Et9MlBChqzLb", NULL),
 	B("ASUS",	"P4P800-E Deluxe",	1, "http://www.asus.com/product.aspx?P_ID=INIJUvLlif7LHp3g", NULL),
 	B("ASUS",	"P4SD-LA",		1, "http://h10025.www1.hp.com/ewfrf/wc/document?docname=c00022505", NULL),
 	B("ASUS",	"P5A",			1, "ftp://ftp.asus.com.tw/pub/ASUS/mb/sock7/ali/p5a/", NULL),