Patchworkβ Note to add the board/device name to the subject when contacting the ML.

login
register
about
Submitter Paul Menzel
Date 2010-08-26 10:14:40
Message ID <1282817680.3726.40.camel@mattotaupa>
Download mbox | patch
Permalink /patch/1801/
State Accepted
Commit r1202
Headers show

Comments

Paul Menzel - 2010-08-26 10:14:40
A lot of messages sent to flashrom@flashrom.org just have »flashrom -V« as the subject rendering it in my opinion unusable.

Adding the board/device name to the subject would help a lot when skimming over the messages by the subject line or searching the messages just using the subject line.

• I did not add that note to outputs saying to report a bug to the mailing list.
• I do not know if the subject line can be created automatically in those message, so users just have to copy and paste them.
• I am not a native speaker, so I do not know if using plain »subject« instead of »subject line« would be enough and if the propositions I used are correct.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 board_enable.c   |    7 +++++--
 chipset_enable.c |    7 +++++--
 flashrom.c       |    5 +++--
 pcidev.c         |    3 ++-
 4 files changed, 15 insertions(+), 7 deletions(-)
Carl-Daniel Hailfinger - 2010-10-08 11:04:13
On 26.08.2010 12:14, Paul Menzel wrote:
> A lot of messages sent to flashrom@flashrom.org just have »flashrom -V« as the subject rendering it in my opinion unusable.
>
> Adding the board/device name to the subject would help a lot when skimming over the messages by the subject line or searching the messages just using the subject line.
>
> • I did not add that note to outputs saying to report a bug to the mailing list.
> • I do not know if the subject line can be created automatically in those message, so users just have to copy and paste them.
> • I am not a native speaker, so I do not know if using plain »subject« instead of »subject line« would be enough and if the propositions I used are correct.
>   

Thanks for your patch. I changed the line breaks in a few places.


> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
and committed in r1202.

Regards,
Carl-Daniel

Patch

diff --git a/board_enable.c b/board_enable.c
index ae0fbfa..52052d3 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -430,7 +430,9 @@  int it8705f_write_enable(uint8_t port)
 			max_rom_decode.parallel = 1024 * 1024;
 			msg_pinfo("IT8705F with very unusual settings. Please "
 				  "send the output of \"flashrom -V\" to \n"
-				  "flashrom@flashrom.org to help us finish "
+				  "flashrom@flashrom.org with \n\n"
+				  "IT8705: your board name: flashrom -V \n\n"
+				  "as the subject to help us finish "
 				  "support for your Super I/O. Thanks.\n");
 			ret = 1;
 		} else if (tmp & 0x08) {
@@ -1964,7 +1966,8 @@  int board_flash_enable(const char *vendor, const char *part)
 		board = NULL;
 		} else {
 		        msg_pinfo("NOTE: Running an untested board enable procedure.\n"
-		               "Please report success/failure to flashrom@flashrom.org.\n");
+		               "Please report success/failure to flashrom@flashrom.org \n"
+		               "with your board name and SUCCESS or FAILURE in the subject.\n");
 		}
         }
 
diff --git a/chipset_enable.c b/chipset_enable.c
index f191061..4549e52 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -923,7 +923,9 @@  static int enable_flash_mcp6x_7x(struct pci_dev *dev, const char *name)
 	}
 out_msg:
 	msg_pinfo("Please send the output of \"flashrom -V\" to "
-		  "flashrom@flashrom.org to help us finish support for your "
+		  "flashrom@flashrom.org with \n\n"
+			"your board name: flashrom -V \n\n"
+			"as the subject to help us finish support for your "
 		  "chipset. Thanks.\n");
 
 	return ret;
@@ -1178,7 +1180,8 @@  int chipset_flash_enable(void)
 		if (ret != -2) {
 			msg_pinfo("WARNING: unexpected second chipset match: "
 			       "\"%s %s\"\nignoring, please report lspci and "
-			       "board URL to flashrom@flashrom.org!\n",
+			       "board URL to flashrom@flashrom.org "
+			       "with your board name in the subject line!\n",
 				chipset_enables[i].vendor_name,
 					chipset_enables[i].device_name);
 			continue;
diff --git a/flashrom.c b/flashrom.c
index 45d086d..9dd1c48 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -1290,7 +1290,7 @@  void emergency_help_message(void)
 {
 	msg_gerr("Your flash chip is in an unknown state.\n"
 		"Get help on IRC at irc.freenode.net (channel #flashrom) or\n"
-		"mail flashrom@flashrom.org!\n"
+		"mail flashrom@flashrom.org with your board name in the subject line!\n"
 		"-------------------------------------------------------------"
 		  "------------------\n"
 		"DO NOT REBOOT OR POWEROFF!\n");
@@ -1430,7 +1430,8 @@  void check_chip_supported(struct flashchip *flash)
 			  "output with the additional -V option for all "
 			    "operations you tested (-V, -Vr,\n"
 			  "-Vw, -VE), and mention which mainboard or "
-			    "programmer you tested.\n"
+			    "programmer you tested. Please mention your board in "
+			  "the subject line.\n"
 			  "Thanks for your help!\n"
 			  "===\n");
 	}
diff --git a/pcidev.c b/pcidev.c
index f7048e7..decf4e7 100644
--- a/pcidev.c
+++ b/pcidev.c
@@ -69,7 +69,8 @@  uint32_t pcidev_validate(struct pci_dev *dev, uint32_t bar,
 			msg_pinfo("===\nThis PCI device is UNTESTED. Please "
 			       "report the 'flashrom -p xxxx' output \n"
 			       "to flashrom@flashrom.org if it works "
-			       "for you. Thank you for your help!\n===\n");
+			       "for you. Please add the name of your PCI device "
+			       "to the subject. Thank you for your help!\n===\n");
 		}
 
 		return addr;