Patchwork Tyan S2912 Fam10

login
register
about
Submitter Arne Georg Gleditsch
Date 2010-03-05 14:22:23
Message ID <4B91139F.4040509@numascale.com>
Download mbox | patch
Permalink /patch/1015/
State Accepted
Commit r5197
Headers show

Comments

Arne Georg Gleditsch - 2010-03-05 14:22:23
Hi all,

I've just recently brought my development environment up to speed with
the latest coreboot version -- which is very nice! -- and caught a
couple of minor issues.  I'm not sure I fully understand the underlying
logic behind the different CAR setup routines in
src/cpu/amd/car/cache_as_ram.inc, but the attached patch is required to
make the S2912 board choose the correct code path.  I've also upped the
MAX_CPUS setting to 12 to accommodate 6-core Istanbul CPUs.  This might
make sense for other fam10 boards as well.

Signed-off-by: Arne Georg Gleditsch <arne.gleditsch@numascale.com>

Patch

diff --git a/src/mainboard/tyan/s2912_fam10/Kconfig b/src/mainboard/tyan/s2912_fam10/Kconfig
index 91f8f45..b3c4c4f 100644
--- a/src/mainboard/tyan/s2912_fam10/Kconfig
+++ b/src/mainboard/tyan/s2912_fam10/Kconfig
@@ -38,6 +38,26 @@  config DCACHE_RAM_GLOBAL_VAR_SIZE
 	default 0x04000
 	depends on BOARD_TYAN_S2912_FAM10
 
+config USE_FALLBACK_IMAGE
+	bool
+	default y
+	depends on BOARD_TYAN_S2912_FAM10
+
+config HAVE_FALLBACK_BOOT
+	bool
+	default y
+	depends on BOARD_TYAN_S2912_FAM10
+
+config CONFIG_USE_FAILOVER_IMAGE
+	bool
+	default y
+	depends on BOARD_TYAN_S2912_FAM10
+
+config CONFIG_HAVE_FAILOVER_BOOT
+	bool
+	default y
+	depends on BOARD_TYAN_S2912_FAM10
+
 config APIC_ID_OFFSET
 	hex
 	default 0
@@ -95,7 +115,7 @@  config HW_MEM_HOLE_SIZEK
 
 config MAX_CPUS
 	int
-	default 8
+	default 12
 	depends on BOARD_TYAN_S2912_FAM10
 
 config MAX_PHYSICAL_CPUS