| Submitter | Myles Watson |
|---|---|
| Date | 2010-03-18 17:28:10 |
| Message ID | <2831fecf1003181028g33df73b7ye7a9b19ee148fbea@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/1086/ |
| State | Accepted |
| Headers | show |
Comments
On Thu, Mar 18, 2010 at 11:28 AM, Myles Watson <mylesgw@gmail.com> wrote: > I split the patch into two. One has the acpi changes. > For the ACPI struct, the safest way would probably be to copy sizeof(acpi_header_t) bytes into a temp header, then copy the full temp->size. I think we can probably trust the compiler to give us 4-byte alignment, but maybe we should add an alignment attribute when we change the name. Thanks, Myles > > Abuild-tested and boot tested on serengeti_cheetah_fam10. > > If we get rid of the SSE2 warnings, we could have about 30 boards compiling > without any warnings! > > > Signed-off-by: Myles Watson <mylesgw@gmail.com> > > Thanks, > Myles >
Am 18.03.2010 18:28, schrieb Myles Watson: > I split the patch into two. One has the acpi changes. > > Abuild-tested and boot tested on serengeti_cheetah_fam10. > > If we get rid of the SSE2 warnings, we could have about 30 boards > compiling without any warnings! > > Signed-off-by: Myles Watson <mylesgw@gmail.com <mailto:mylesgw@gmail.com>> The non-ACPI warning stuff is Acked-by: Patrick Georgi <patrick.georgi@coresystems.de> I didn't look into the ACPI stuff yet. As for SSE2 warnings, just add a "default n" to its global definition in src/cpu/Kconfig? (and to MMX and SSE, too) That's also Acked-by: Patrick Georgi <patrick.georgi@coresystems.de> Regards, Patrick
> > Signed-off-by: Myles Watson <mylesgw@gmail.com > <mailto:mylesgw@gmail.com>> > The non-ACPI warning stuff is > Acked-by: Patrick Georgi <patrick.georgi@coresystems.de> > > I didn't look into the ACPI stuff yet. > > As for SSE2 warnings, just add a "default n" to its global definition in > src/cpu/Kconfig? (and to MMX and SSE, too) I just did SSE2, since it is only for performance of ramtest. I haven't looked much at MMX and SSE to see where they're used. > That's also > Acked-by: Patrick Georgi <patrick.georgi@coresystems.de> Rev 5260. Thanks, Myles
Patch
Index: svn/src/arch/i386/lib/console.c =================================================================== --- svn.orig/src/arch/i386/lib/console.c +++ svn/src/arch/i386/lib/console.c @@ -4,6 +4,7 @@ #if CONFIG_USE_PRINTK_IN_CAR == 0 #include "console_print.c" #else /* CONFIG_USE_PRINTK_IN_CAR == 1 */ +#include <console/console.h> #include "console_printk.c" #endif /* CONFIG_USE_PRINTK_IN_CAR */ Index: svn/src/include/lib.h =================================================================== --- svn.orig/src/include/lib.h +++ svn/src/include/lib.h @@ -19,8 +19,15 @@ /* This file is for "nuisance prototypes" that have no other home. */ +#ifndef __LIB_H__ +#define __LIB_H__ + +#ifndef __ROMCC__ /* romcc doesn't support prototypes. */ + +#ifndef __PRE_RAM__ /* Conflicts with romcc_io.h */ /* Defined in src/lib/clog2.c */ unsigned long log2(unsigned long x); +#endif /* Defined in src/lib/lzma.c */ unsigned long ulzma(unsigned char *src, unsigned char *dst); @@ -28,3 +35,18 @@ unsigned long ulzma(unsigned char *src, /* Defined in src/arch/i386/boot/gdt.c */ void move_gdt(void); +/* Defined in src/lib/ramtest.c */ +void ram_check(unsigned long start, unsigned long stop); + +/* Defined in src/pc80/serial.c */ +void uart_init(void); + +/* Defined in romstage.c */ +#if defined(CONFIG_CPU_AMD_LX) && CONFIG_CPU_AMD_LX +void cache_as_ram_main(void); +#else +void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx); +#endif + +#endif /* __ROMCC__ */ +#endif /* __LIB_H__ */ Index: svn/src/lib/ramtest.c =================================================================== --- svn.orig/src/lib/ramtest.c +++ svn/src/lib/ramtest.c @@ -1,3 +1,5 @@ +#include <lib.h> /* Prototypes */ + static void write_phys(unsigned long addr, unsigned long value) { // Assembler in lib/ is very ugly. But we properly guarded Index: svn/src/pc80/serial.c =================================================================== --- svn.orig/src/pc80/serial.c +++ svn/src/pc80/serial.c @@ -1,3 +1,5 @@ +#include <lib.h> /* Prototypes */ + /* Base Address */ #ifndef CONFIG_TTYS0_BASE #define CONFIG_TTYS0_BASE 0x3f8 Index: svn/src/lib/generic_sdram.c =================================================================== --- svn.orig/src/lib/generic_sdram.c +++ svn/src/lib/generic_sdram.c @@ -1,3 +1,4 @@ +#include <lib.h> /* Prototypes */ #ifndef RAMINIT_SYSINFO #define RAMINIT_SYSINFO 0 @@ -12,14 +13,6 @@ static inline void print_debug_sdram_8(c #endif } -void sdram_no_memory(void) -{ - print_err("No memory!!\r\n"); - while(1) { - hlt(); - } -} - /* Setup SDRAM */ #if RAMINIT_SYSINFO == 1 void sdram_initialize(int controllers, const struct mem_controller *ctrl, void *sysinfo) Index: svn/src/mainboard/tyan/s2892/romstage.c =================================================================== --- svn.orig/src/mainboard/tyan/s2892/romstage.c +++ svn/src/mainboard/tyan/s2892/romstage.c @@ -17,7 +17,6 @@ #include "option_table.h" #include "pc80/mc146818rtc_early.c" -#define post_code(x) outb(x, 0x80) #include "pc80/serial.c" #include "arch/i386/lib/console.c" #include "lib/ramtest.c"
I split the patch into two. One has the acpi changes. Abuild-tested and boot tested on serengeti_cheetah_fam10. If we get rid of the SSE2 warnings, we could have about 30 boards compiling without any warnings! Signed-off-by: Myles Watson <mylesgw@gmail.com> Thanks, Myles