Patchwork W83977EF vs. ASUS P2B-L vs. PS/2 keyboard

login
register
about
Submitter Myles Watson
Date 2010-03-24 15:49:08
Message ID <2831fecf1003240849x1aec2810g9115e4ad4d837695@mail.gmail.com>
Download mbox | patch
Permalink /patch/1133/
State Not Applicable
Headers show

Comments

Myles Watson - 2010-03-24 15:49:08
On Wed, Mar 24, 2010 at 8:56 AM, Stefan Reinauer <stepan@coresystems.de>wrote:

> On 3/24/10 2:04 PM, Myles Watson wrote:
> >> I switched back to my P2B-LS and tried the onboard SCSI now that I got
> >> the keyboard going.
> >>
> > So why did that change work if pnp_enable_resources was already doing the
> > same thing?
> >
> I seem to remember the southbridge driver had to contain some code to
> make sure the pnp and i2c devices hanging off it are initialized
> correctly. Maybe the device allocator does not try to call
> pnp_enable_resources for the ASUS P2B?
>

That could be.  I just looked at the superio code, and I'm not sure it looks
right.  I'd like to see the log with this patch applied.  If it's correct,
it should be called for each enabled PNP device.


Thanks,
Myles

Patch

Index: svn/src/devices/pnp_device.c
===================================================================
--- svn.orig/src/devices/pnp_device.c
+++ svn/src/devices/pnp_device.c
@@ -145,6 +145,7 @@  void pnp_set_resources(device_t dev)

 void pnp_enable_resources(device_t dev)
 {
+    printk(BIOS_DEBUG, "%s: %s\n", __func__, dev_path(dev));
     pnp_set_logical_device(dev);
     pnp_set_enable(dev, 1);
 }