From patchwork Fri Apr  2 16:04:02 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: remove annoying noisy message
Date: Fri, 02 Apr 2010 16:04:02 -0000
From: Stefan Reinauer <stepan@coresystems.de>
X-Patchwork-Id: 1186
Message-Id: <4BB61572.4060908@coresystems.de>
To: coreboot mailing list <coreboot@coreboot.org>

See patch
The error message is misleading, even for a SPEW, because
the slot is empty, it's NOT a bad ID (and the message is
more confusing than helpful even in SPEW)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


Index: src/devices/pci_device.c
===================================================================
--- src/devices/pci_device.c	(revision 5344)
+++ src/devices/pci_device.c	(working copy)
@@ -910,11 +910,11 @@
 		dummy.path.pci.devfn = devfn;
 		id = pci_read_config32(&dummy, PCI_VENDOR_ID);
 		/* Have we found something?
-		 * Some broken boards return 0 if a slot is empty.
+		 * Some broken boards return 0 if a slot is empty, but
+		 * the expected answer is 0xffffffff
 		 */
 		if ((id == 0xffffffff) || (id == 0x00000000) ||
 		    (id == 0x0000ffff) || (id == 0xffff0000)) {
-			printk(BIOS_SPEW, "%s, bad id 0x%x\n", dev_path(&dummy), id);
 			return NULL;
 		}
 		dev = alloc_dev(bus, &dummy.path);