Patchwork Debian: Missing build dependency: subversion

login
register
about
Submitter Adrian Glaubitz
Date 2010-04-02 18:17:38
Message ID <20100402181738.GA4868@physik.fu-berlin.de>
Download mbox | patch
Permalink /patch/1188/
State Not Applicable
Headers show

Comments

Adrian Glaubitz - 2010-04-02 18:17:38
Hi,

the Debian package of flashrom misses the build dependency on
subversion in its control file. Subversion is not installed when
choosing "Standard system" and "Desktop system" with tasksel.

I tried to build flashrom on a freshly installed Debian unstable
machine (alpha) and I couldn't check-out the source because of the
missing subversion.

Adrian
Maciej Pijanka - 2010-04-02 19:31:28
On Fri, 02 Apr 2010, adrian.glaubitz@googlemail.com wrote:

> Hi,
> 
> the Debian package of flashrom misses the build dependency on
> subversion in its control file. Subversion is not installed when
> choosing "Standard system" and "Desktop system" with tasksel.
> 
> I tried to build flashrom on a freshly installed Debian unstable
> machine (alpha) and I couldn't check-out the source because of the
> missing subversion.

maybe we should rather patch flashrom build system so it will build without
subversion instead?

> Adrian

Maciej
Carl-Daniel Hailfinger - 2010-04-02 21:35:28
Hi Adrian,

On 02.04.2010 20:17, adrian.glaubitz@googlemail.com wrote:
> the Debian package of flashrom misses the build dependency on
> subversion in its control file. Subversion is not installed when
> choosing "Standard system" and "Desktop system" with tasksel.
>
> I tried to build flashrom on a freshly installed Debian unstable
> machine (alpha) and I couldn't check-out the source because of the
> missing subversion.
>   

The flashrom tarballs at http://qa.coreboot.org/snapshots/ shouldn't
need subversion, and we generally recommend to use those tarballs for
packaging.

Regards,
Carl-Daniel
Uwe Hermann - 2010-05-25 23:49:46
Hi,

On Fri, Apr 02, 2010 at 08:17:38PM +0200, adrian.glaubitz@googlemail.com wrote:
> the Debian package of flashrom misses the build dependency on
> subversion in its control file.

Hm, don't think so.


> Subversion is not installed when
> choosing "Standard system" and "Desktop system" with tasksel.
> 
> I tried to build flashrom on a freshly installed Debian unstable
> machine (alpha) and I couldn't check-out the source because of the
> missing subversion.

You should not checkout the source (via svn) to build the Debian
package. The package as it's available in Debian does not require
subversion as build-dependency. Only if you do a manual checkout and
build of flashrom you need subversion, but that's unrelated to the
Debian package.

I just tested with the current version in unstable and it builds fine
without subversion installed:

 $ dpkg --purge subversion
 $ apt-get source flashrom
 $ cd flashrom-0.9.1+r946
 $ dpkg-buildpackage -us -uc -rfakeroot


Uwe.

Patch

--- debian/control	2010-04-02 20:04:41.000000000 +0200
+++ debian/control.new	2010-04-02 20:05:31.000000000 +0200
@@ -2,7 +2,7 @@ 
 Section: electronics
 Priority: extra
 Maintainer: Uwe Hermann <uwe@debian.org>
-Build-Depends: cdbs, debhelper (>= 5), libpci-dev, libftdi-dev
+Build-Depends: cdbs, debhelper (>= 5), libpci-dev, libftdi-dev, subversion
 Standards-Version: 3.8.4
 Homepage: http://www.flashrom.org