Patchwork Documentation fixes

login
register
about
Submitter Myles Watson
Date 2009-08-13 15:50:34
Message ID <2831fecf0908130850h40133e3el34b1cb4283c9a822@mail.gmail.com>
Download mbox | patch
Permalink /patch/123/
State Accepted
Headers show

Comments

Myles Watson - 2009-08-13 15:50:34
Most of the changes here are trivial, but the white space changes would be
harder to undo than to do over.

I changed all groups of 8 spaces to tabs, then all tabs to two spaces so
more of the device tree fits on the page.  It could have been three or
possibly four, but the largest indents I found were 6 tabs, so 4 is a lot of
the space on the page.

Signed-off-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles
ron minnich - 2009-08-13 16:02:47
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Committed revision 4543.
Thanks!

ron

Patch

Index: Kconfig.tex
===================================================================
--- Kconfig.tex	(revision 4542)
+++ Kconfig.tex	(working copy)
@@ -7,55 +7,55 @@ 
 \title{Kconfig usage in coreboot v2}
 \begin{document}
 \section{Introduction}
-This document describes how to use Kconfig in v2. We describe our usage of Kconfig files, Makefile.inc files, when and where to use them, how to use them, and, interestingly, when and where not to use them. 
+This document describes how to use Kconfig in v2. We describe our usage of Kconfig files, Makefile.inc files, when and where to use them, how to use them, and, interestingly, when and where not to use them.
 \section{Kconfig variations}
-Most Kconfig files set variables, which can be set as part of the Kconfig dialog. Not all Kconfig variables are set by the user, however; some are too dangerous. These are merely enabled by the mainboard. 
+Most Kconfig files set variables, which can be set as part of the Kconfig dialog. Not all Kconfig variables are set by the user, however; some are too dangerous. These are merely enabled by the mainboard.
 
-For variables set by the user, see src/console/Kconfig. 
+For variables set by the user, see src/console/Kconfig.
 
-For variables not set by the user, see src/mainboard/amd/serengeti\_cheetah/Kconfig. Users should never set such variables as the cache as ram base. These are highly mainboard dependent. 
+For variables not set by the user, see src/mainboard/amd/serengeti\_cheetah/Kconfig. Users should never set such variables as the cache as ram base. These are highly mainboard dependent.
 
-Kconfig files use the source command to include subdirectories. In most cases, save for limited cases described below, subdirectories have Kconfig files. They are always sourced unconditionally. 
+Kconfig files use the source command to include subdirectories. In most cases, save for limited cases described below, subdirectories have Kconfig files. They are always sourced unconditionally.
 
 \section{Makefile and Makefile.inc}
-There is only one Makefile, at the top level. All other makefiles are included as Makefile.inc. All the next-level Makefile.inc files are selected in the top level Makefile. Directories that are platform-independent are in BUILD-y; platform-dependent (e.g. Makefile.inc's that depend on architecture) are included in PLATFORM-y. 
+There is only one Makefile, at the top level. All other makefiles are included as Makefile.inc. All the next-level Makefile.inc files are selected in the top level Makefile. Directories that are platform-independent are in BUILD-y; platform-dependent (e.g. Makefile.inc's that depend on architecture) are included in PLATFORM-y.
 
-Make is not recursive. There is only one make process. 
+Make is not recursive. There is only one make process.
 \subsection{subdir usage}
-Further includes of Makefile.inc, if needed, are done via subdir-y commands. As in Linux, the subdir can be conditional or unconditional. Conditional includes are done via subdir-\$(CONFIG\_VARIABLE) usage; unconditional are done via subdir-y. 
+Further includes of Makefile.inc, if needed, are done via subdir-y commands. As in Linux, the subdir can be conditional or unconditional. Conditional includes are done via subdir-\$(CONFIG\_VARIABLE) usage; unconditional are done via subdir-y.
 
-We define the common rules for which variation to use below. 
+We define the common rules for which variation to use below.
 \subsection{object file specification}
-There are several different types of objects specified in the tree. They are: 
+There are several different types of objects specified in the tree. They are:
 \begin{description}
 \item[obj]objects for the ram part of the code
-\item[driver]drivers for the ram part. Drivers are not represented in the device tree but do have a driver struct attached in the driver section. 
+\item[driver]drivers for the ram part. Drivers are not represented in the device tree but do have a driver struct attached in the driver section.
 \item[initobj]seperately-compiled code for the ROM section of coreboot
 \end{description}
-These items are specified via the -y syntax as well. Conditional object inclusion is done via the -\$(CONFIG\_VARIABLE) syntax. 
+These items are specified via the -y syntax as well. Conditional object inclusion is done via the -\$(CONFIG\_VARIABLE) syntax.
 
 \section{Example: AMD serengeti cheetah}
 \subsection{mainboard/Kconfig}
-Defines Vendor variables. Currently defined variables are: 
-Sources all Kconfig files in the vendor directories. 
+Defines Vendor variables. Currently defined variables are:
+Sources all Kconfig files in the vendor directories.
 \input{ mainboardkconfig.tex}
 \subsection{mainboard/Makefile.inc}
 There is none at this time.
-\subsection{mainboard/<vendor>/Kconfig}
-We use the amd as a model. The only action currently taken is to source all Kconfig's in the 
-subdirectories. 
-\subsection{mainboard/<vendor>/Makefile.inc}
-We use amd as a model. There is currently no Makefile.inc at this level. 
-\subsection{mainboard/<vendor>/<board>/Kconfig}
-The mainboard Kconfig and Makefile.inc are designed to be the heart of the build. The defines 
-and rules in here determine everything about how a mainboard target is built. 
-We will use serengeti\_cheetah as a model. It defines these variables. 
+\subsection{mainboard/$<$vendor$>$/Kconfig}
+We use the amd as a model. The only action currently taken is to source all Kconfig's in the
+subdirectories.
+\subsection{mainboard/$<$vendor$>$/Makefile.inc}
+We use amd as a model. There is currently no Makefile.inc at this level.
+\subsection{mainboard/$<$vendor$>$/$<$board$>$/Kconfig}
+The mainboard Kconfig and Makefile.inc are designed to be the heart of the build. The defines
+and rules in here determine everything about how a mainboard target is built.
+We will use serengeti\_cheetah as a model. It defines these variables.
 \input{ mainboardkconfig.tex}
-\subsection{mainboard/<vendor>/<board>/Makefile.inc}
-This is a fairly complex Makefile.inc. Because this is such a critical component, we are going to excerpt and take it piece by piece. 
-Note that this is the mainboard as of August, 2009, and it may change over time. 
+\subsection{mainboard/$<$vendor$>$/$<$board$>$/Makefile.inc}
+This is a fairly complex Makefile.inc. Because this is such a critical component, we are going to excerpt and take it piece by piece.
+Note that this is the mainboard as of August, 2009, and it may change over time.
 \subsubsection{objects}
-We define objects in the first part. The mainbard itself is a driver and included unconditionally. Other objects are conditional: 
+We define objects in the first part. The mainbard itself is a driver and included unconditionally. Other objects are conditional:
 \begin{verbatim}
 driver-y +=  mainboard.o
 
@@ -73,14 +73,14 @@ 
 obj-$(CONFIG_HAVE_ACPI_TABLES) +=  ssdt4.o
 driver-y += ../../../drivers/i2c/i2cmux/i2cmux.o
 
-# This is part of the conversion to init-obj and away from included code. 
+# This is part of the conversion to init-obj and away from included code.
 
 initobj-y += crt0.o
 \end{verbatim}
 \subsubsection{romcc legacy support}
-We hope to move away from romcc soon, but for now, if one is using romcc, the Makefile.inc must define 
-crt0 include files (assembly code for startup, usually); and several ldscripts. These are taken directly from the 
-old Config.lb. Note that these use the -y syntax and can use the ability to be included conditionally. 
+We hope to move away from romcc soon, but for now, if one is using romcc, the Makefile.inc must define
+crt0 include files (assembly code for startup, usually); and several ldscripts. These are taken directly from the
+old Config.lb. Note that these use the -y syntax and can use the ability to be included conditionally.
 \begin{verbatim}
 crt0-y += ../../../../src/cpu/x86/16bit/entry16.inc
 crt0-y += ../../../../src/cpu/x86/32bit/entry32.inc
@@ -97,351 +97,351 @@ 
 
 \end{verbatim}
 \subsubsection{defines}
-There are variables that should never be definable by users, as changing them will break the build or the image. These are set 
-in MAINBOARD\_OPTIONS. 
+There are variables that should never be definable by users, as changing them will break the build or the image. These are set
+in MAINBOARD\_OPTIONS.
 \begin{verbatim}
 MAINBOARD_OPTIONS=\
-	-DCONFIG_AP_IN_SIPI_WAIT=0 \
-	-DCONFIG_USE_PRINTK_IN_CAR=1 \
-	-DCONFIG_HAVE_HIGH_TABLES=1
+  -DCONFIG_AP_IN_SIPI_WAIT=0 \
+  -DCONFIG_USE_PRINTK_IN_CAR=1 \
+  -DCONFIG_HAVE_HIGH_TABLES=1
 \end{verbatim}
 \subsubsection{POST\_EVALUATION}
-POST\_EVALUATION rules should be placed after this section: 
+POST\_EVALUATION rules should be placed after this section:
 \begin{verbatim}
 ifdef POST_EVALUATION
 \end{verbatim}
-to ensure that the values of variables are correct. 
-Here are the post-evaluation rules for this mainboard: 
+to ensure that the values of variables are correct.
+Here are the post-evaluation rules for this mainboard:
 \begin{verbatim}
 $(obj)/dsdt.c: $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl
-	iasl -p dsdt -tc $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl
-	mv dsdt.hex $@
+  iasl -p dsdt -tc $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl
+  mv dsdt.hex $@
 
 $(obj)/mainboard/$(MAINBOARDDIR)/dsdt.o: $(obj)/dsdt.c
-	$(CC) $(DISTRO_CFLAGS) $(CFLAGS) $(CPPFLAGS) $(DEBUG_CFLAGS) -I$(src) -I. -c $< -o $@
+  $(CC) $(DISTRO_CFLAGS) $(CFLAGS) $(CPPFLAGS) $(DEBUG_CFLAGS) -I$(src) -I. -c $< -o $@
 
 $(obj)/ssdt2.c: $(src)/mainboard/$(MAINBOARDDIR)/dx/pci2.asl
-	iasl -p $(CURDIR)/pci2 -tc $(CONFIG_MAINBOARD)/dx/pci2.asl
-	perl -pi -e 's/AmlCode/AmlCode_ssdt2/g' pci2.hex
-	mv pci2.hex ssdt2.c
+  iasl -p $(CURDIR)/pci2 -tc $(CONFIG_MAINBOARD)/dx/pci2.asl
+  perl -pi -e 's/AmlCode/AmlCode_ssdt2/g' pci2.hex
+  mv pci2.hex ssdt2.c
 
 $(obj)/ssdt3.c: $(src)/mainboard/$(MAINBOARDDIR)/dx/pci3.asl"
-	iasl -p $(CURDIR)/pci3 -tc $(CONFIG_MAINBOARD)/
-	perl -pi -e 's/AmlCode/AmlCode_ssdt3/g' pci3.hex
-	mv pci3.hex ssdt3.c
-           
+  iasl -p $(CURDIR)/pci3 -tc $(CONFIG_MAINBOARD)/
+  perl -pi -e 's/AmlCode/AmlCode_ssdt3/g' pci3.hex
+  mv pci3.hex ssdt3.c
+  
 $(obj)/ssdt4.c: $(src)/mainboard/$(MAINBOARDDIR)/dx/pci4.asl"
-	iasl -p $(CURDIR)/pci4 -tc $(CONFIG_MAINBOARD)/dx/pci4.asl
-	perl -pi -e 's/AmlCode/AmlCode_ssdt4/g' pci4.hex
-	mv pci4.hex ssdt4.c
+  iasl -p $(CURDIR)/pci4 -tc $(CONFIG_MAINBOARD)/dx/pci4.asl
+  perl -pi -e 's/AmlCode/AmlCode_ssdt4/g' pci4.hex
+  mv pci4.hex ssdt4.c
 
 $(obj)/mainboard/$(MAINBOARDDIR)/auto.inc: $(src)/mainboard/$(MAINBOARDDIR)/rom.c $(obj)/option_table.h
-	$(CC) $(DISTRO_CFLAGS) $(CFLAGS) $(CPPFLAGS) $(DEBUG_CFLAGS) -I$(src) -I. -c -S  $(src)/mainboard/$(MAINBOARDDIR)/rom.c -o $@
-	perl -e 's/\.rodata/.rom.data/g' -pi $@
-	perl -e 's/\.text/.section .rom.text/g' -pi $@
+  $(CC) $(DISTRO_CFLAGS) $(CFLAGS) $(CPPFLAGS) $(DEBUG_CFLAGS) -I$(src) -I. -c -S  $(src)/mainboard/$(MAINBOARDDIR)/rom.c -o $@
+  perl -e 's/\.rodata/.rom.data/g' -pi $@
+  perl -e 's/\.text/.section .rom.text/g' -pi $@
 
 \end{verbatim}
-The last rule is for romcc, and, again, we hope to eliminate romcc usage and this rule soon. The first set of rules concern ACPI tables. 
+The last rule is for romcc, and, again, we hope to eliminate romcc usage and this rule soon. The first set of rules concern ACPI tables.
 \subsubsection{devicetree.cb}
 Most of the old Config.lb is gone, but one piece remains: the device tree specification. This tree is still required to build a mainboard
-properly, as it defines topology and chips that can be defined no other way. 
-Let's go through the tree. 
+properly, as it defines topology and chips that can be defined no other way.
+Let's go through the tree.
 \begin{verbatim}
 chip northbridge/amd/amdk8/root_complex
-        device apic_cluster 0 on
-                chip cpu/amd/socket_F
-                        device apic 0 on end
-                end
-        end
+  device apic_cluster 0 on
+    chip cpu/amd/socket_F
+      device apic 0 on end
+    end
+  end
 \end{verbatim}
-This topology is always somewhat confusing to newcomers, and even to coreboot veterans. 
+This topology is always somewhat confusing to newcomers, and even to coreboot veterans.
 
-We root the tree at the pci-e {\it root complex}. There is always the question of how and where to root the tree. Over the years we 
+We root the tree at the pci-e {\it root complex}. There is always the question of how and where to root the tree. Over the years we
 have found that the one part that never goes away is the root complex. CPU sockets may be empty or full; but there is always a northbridge
-somewhere, since it runs memory. 
+somewhere, since it runs memory.
 
 
-What is the APIC? Northbridges always have an Advanced Programmable Interrupt Controller, and that {\it APIC cluster} is a topological connection to the 
-CPU socket. So the tree is rooted at the northbridge, which has a link to an apic cluster, and then the CPU. The CPU contains 
-its own APIC, and will define any parameters needed. In this case, we have a northbridge of type 
-{\it northbridge/amd/amdk8/root\_complex}, with its won apic\_cluster device which we turn on, 
-which connects to a {\it cpu/amd/socket\_F}, 
-which has an apic, which is on. 
+What is the APIC? Northbridges always have an Advanced Programmable Interrupt Controller, and that {\it APIC cluster} is a topological connection to the
+CPU socket. So the tree is rooted at the northbridge, which has a link to an apic cluster, and then the CPU. The CPU contains
+its own APIC, and will define any parameters needed. In this case, we have a northbridge of type
+{\it northbridge/amd/amdk8/root\_complex}, with its own apic\_cluster device which we turn on,
+which connects to a {\it cpu/amd/socket\_F},
+which has an apic, which is on.
 
-Note that we do not enumerate all CPUs, even on this SMP mainboard. The reason is they may not all be there. The CPU we define here 
-is the so-called Boot Strap Processor, or BSP; the other CPUs will come along later, as the are discovered. We do not require (unlike many 
-BIOSes) that the BSP be CPU 0; any CPU will do. 
+Note that we do not enumerate all CPUs, even on this SMP mainboard. The reason is they may not all be there. The CPU we define here
+is the so-called Boot Strap Processor, or BSP; the other CPUs will come along later, as the are discovered. We do not require (unlike many
+BIOSes) that the BSP be CPU 0; any CPU will do.
 \begin{verbatim}
-	device pci_domain 0 on
-		chip northbridge/amd/amdk8
-			device pci 18.0 on #  northbridge 
-				#  devices on link 0, link 0 == LDT 0
+  device pci_domain 0 on
+    chip northbridge/amd/amdk8
+      device pci 18.0 on #  northbridge
+        #  devices on link 0, link 0 == LDT 0
 \end{verbatim}
-Here begins the pci domain, which usually starts with 0. Then there is the northbridge, which bridges to the PCI bus. On 
-Opterons, certain CPU control registers are managed in PCI config space in device 18.0 (BSP), 19.0 (AP), and up. 
+Here begins the pci domain, which usually starts with 0. Then there is the northbridge, which bridges to the PCI bus. On
+Opterons, certain CPU control registers are managed in PCI config space in device 18.0 (BSP), 19.0 (AP), and up.
 \begin{verbatim}
-				chip southbridge/amd/amd8132
-					# the on/off keyword is mandatory
-					device pci 0.0 on end
-					device pci 0.1 on end
-					device pci 1.0 on end
-					device pci 1.1 on end
-				end
+        chip southbridge/amd/amd8132
+          # the on/off keyword is mandatory
+          device pci 0.0 on end
+          device pci 0.1 on end
+          device pci 1.0 on end
+          device pci 1.1 on end
+        end
 \end{verbatim}
-This is the 8132, a bridge to a secondary PCI bus. 
+This is the 8132, a bridge to a secondary PCI bus.
 \begin{verbatim}
-				chip southbridge/amd/amd8111
-					# this "device pci 0.0" is the parent the next one
-					# PCI bridge
-					device pci 0.0 on
-						device pci 0.0 on end
-						device pci 0.1 on end
-						device pci 0.2 off end
-						device pci 1.0 off end
-					end
+        chip southbridge/amd/amd8111
+          # this "device pci 0.0" is the parent the next one
+          # PCI bridge
+          device pci 0.0 on
+            device pci 0.0 on end
+            device pci 0.1 on end
+            device pci 0.2 off end
+            device pci 1.0 off end
+          end
 \end{verbatim}
-The 8111 is a bridge to other busses and to the legacy ISA devices such as superio. 
+The 8111 is a bridge to other busses and to the legacy ISA devices such as superio.
 \begin{verbatim}
-					device pci 1.0 on
-						chip superio/winbond/w83627hf
-							device pnp 2e.0 off #  Floppy
-                	                 			io 0x60 = 0x3f0
-                	                			irq 0x70 = 6
-                	                			drq 0x74 = 2
-							end
-                	        			device pnp 2e.1 off #  Parallel Port
-                	                 			io 0x60 = 0x378
-                	                			irq 0x70 = 7
-							end
-                	        			device pnp 2e.2 on #  Com1
-                	                 			io 0x60 = 0x3f8
-                	                			irq 0x70 = 4
-							end
-                	        			device pnp 2e.3 off #  Com2
-                	                 			io 0x60 = 0x2f8
-                	                			irq 0x70 = 3
-							end
-                	        			device pnp 2e.5 on #  Keyboard
-                	                 			io 0x60 = 0x60
-                	                 			io 0x62 = 0x64
-                	                			irq 0x70 = 1
-								irq 0x72 = 12
-							end
-                	        			device pnp 2e.6 off #  CIR
-								io 0x60 = 0x100
-							end
-                	        			device pnp 2e.7 off #  GAME_MIDI_GIPO1
-								io 0x60 = 0x220
-								io 0x62 = 0x300
-								irq 0x70 = 9
-							end						
-                	        			device pnp 2e.8 off end #  GPIO2
-                	        			device pnp 2e.9 off end #  GPIO3
-                	        			device pnp 2e.a off end #  ACPI
-                	        			device pnp 2e.b on #  HW Monitor
- 					 			io 0x60 = 0x290
-								irq 0x70 = 5
-                					end
-						end
-					end
+          device pci 1.0 on
+            chip superio/winbond/w83627hf
+              device pnp 2e.0 off #  Floppy
+                 io 0x60 = 0x3f0
+                irq 0x70 = 6
+                drq 0x74 = 2
+              end
+              device pnp 2e.1 off #  Parallel Port
+                 io 0x60 = 0x378
+                irq 0x70 = 7
+              end
+              device pnp 2e.2 on #  Com1
+                 io 0x60 = 0x3f8
+                irq 0x70 = 4
+              end
+              device pnp 2e.3 off #  Com2
+                 io 0x60 = 0x2f8
+                irq 0x70 = 3
+              end
+              device pnp 2e.5 on #  Keyboard
+                 io 0x60 = 0x60
+                 io 0x62 = 0x64
+                irq 0x70 = 1
+                irq 0x72 = 12
+              end
+              device pnp 2e.6 off #  CIR
+                io 0x60 = 0x100
+              end
+              device pnp 2e.7 off #  GAME_MIDI_GIPO1
+                io 0x60 = 0x220
+                io 0x62 = 0x300
+                irq 0x70 = 9
+              end
+              device pnp 2e.8 off end #  GPIO2
+              device pnp 2e.9 off end #  GPIO3
+              device pnp 2e.a off end #  ACPI
+              device pnp 2e.b on #  HW Monitor
+                  io 0x60 = 0x290
+                irq 0x70 = 5
+              end
+            end
+          end
 \end{verbatim}
-The pnp refers to the many Plug N Play devices on a superio. 2e refers to the base I/O address of the superio, and the number following the 
-2e (i.e. 2e.1) is the Logical Device Number, or LDN. Each LDN has a common configuration (base, irq, etc.) and these are set by the statements under the LDN. 
+The pnp refers to the many Plug N Play devices on a superio. 2e refers to the base I/O address of the superio, and the number following the
+2e (i.e. 2e.1) is the Logical Device Number, or LDN. Each LDN has a common configuration (base, irq, etc.) and these are set by the statements under the LDN.
 \begin{verbatim}
-					device pci 1.1 on end
-					device pci 1.2 on end
+          device pci 1.1 on end
+          device pci 1.2 on end
 \end{verbatim}
-More devices. These statements set up placeholders in the device tree. 
+More devices. These statements set up placeholders in the device tree.
 \begin{verbatim}
-					device pci 1.3 on
-                                                chip drivers/i2c/i2cmux # pca9556 smbus mux
-                                                        device i2c 18 on #0 pca9516 1
-                                                                chip drivers/generic/generic #dimm 0-0-0
-                                                                        device i2c 50 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 0-0-1
-                                                                        device i2c 51 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 0-1-0
-                                                                        device i2c 52 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 0-1-1
-                                                                        device i2c 53 on end
-                                                                end
-                                                        end
-                                                        device i2c 18 on #1 pca9516 2
-                                                                chip drivers/generic/generic #dimm 1-0-0
-                                                                        device i2c 50 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 1-0-1
-                                                                        device i2c 51 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 1-1-0
-                                                                        device i2c 52 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 1-1-1
-                                                                        device i2c 53 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 1-2-0
-                                                                        device i2c 54 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 1-2-1
-                                                                        device i2c 55 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 1-3-0
-                                                                        device i2c 56 on end
-                                                                end
-                                                                chip drivers/generic/generic #dimm 1-3-1
-                                                                        device i2c 57 on end
-                                                                end
-                                                        end
-						end
-					end # acpi
+          device pci 1.3 on
+            chip drivers/i2c/i2cmux # pca9556 smbus mux
+              device i2c 18 on #0 pca9516 1
+                chip drivers/generic/generic #dimm 0-0-0
+                  device i2c 50 on end
+                end
+                chip drivers/generic/generic #dimm 0-0-1
+                  device i2c 51 on end
+                end
+                chip drivers/generic/generic #dimm 0-1-0
+                  device i2c 52 on end
+                end
+                chip drivers/generic/generic #dimm 0-1-1
+                  device i2c 53 on end
+                end
+              end
+              device i2c 18 on #1 pca9516 2
+                chip drivers/generic/generic #dimm 1-0-0
+                  device i2c 50 on end
+                end
+                chip drivers/generic/generic #dimm 1-0-1
+                  device i2c 51 on end
+                end
+                chip drivers/generic/generic #dimm 1-1-0
+                  device i2c 52 on end
+                end
+                chip drivers/generic/generic #dimm 1-1-1
+                  device i2c 53 on end
+                end
+                chip drivers/generic/generic #dimm 1-2-0
+                  device i2c 54 on end
+                end
+                chip drivers/generic/generic #dimm 1-2-1
+                  device i2c 55 on end
+                end
+                chip drivers/generic/generic #dimm 1-3-0
+                  device i2c 56 on end
+                end
+                chip drivers/generic/generic #dimm 1-3-1
+                  device i2c 57 on end
+                end
+              end
+            end
+          end # acpi
 \end{verbatim}
-These are the i2c devices. 
+These are the i2c devices.
 \begin{verbatim}
-					device pci 1.5 off end
-					device pci 1.6 off end
+          device pci 1.5 off end
+          device pci 1.6 off end
 \end{verbatim}
-More placeholders. 
+More placeholders.
 \begin{verbatim}
-               	                register "ide0_enable" = "1"
-                	                register "ide1_enable" = "1"
-				end
-			end #  device pci 18.0
+               register "ide0_enable" = "1"
+          register "ide1_enable" = "1"
+        end
+      end #  device pci 18.0
 
 \end{verbatim}
-These "register" commands set controls in the southbridge. 
+These "register" commands set controls in the southbridge.
 \begin{verbatim}
-                       device pci 18.0 on end
-                        device pci 18.0 on end  
+           device pci 18.0 on end
+      device pci 18.0 on end
 \end{verbatim}
-These are the other two hypertransport links. 
+These are the other two hypertransport links.
 \begin{verbatim}
-			device pci 18.1 on end
-			device pci 18.2 on end
-			device pci 18.3 on end
+      device pci 18.1 on end
+      device pci 18.2 on end
+      device pci 18.3 on end
 \end{verbatim}
-The 18.1 devices are, again, northbridge control for various k8 functions. 
+The 18.1 devices are, again, northbridge control for various k8 functions.
 \begin{verbatim}
-		end
+    end
   \end{verbatim}
-That's it for the BSP I/O and HT busses. Now we begin the AP busses. Not much here. 
+That's it for the BSP I/O and HT busses. Now we begin the AP busses. Not much here.
 \begin{verbatim}
-              chip northbridge/amd/amdk8
-                        device pci 19.0 on #  northbridge
-                                chip southbridge/amd/amd8151
-                                        # the on/off keyword is mandatory
-                                        device pci 0.0 on end
-                                        device pci 1.0 on end
-                                end
-                        end #  device pci 19.0
+        chip northbridge/amd/amdk8
+      device pci 19.0 on #  northbridge
+        chip southbridge/amd/amd8151
+          # the on/off keyword is mandatory
+          device pci 0.0 on end
+          device pci 1.0 on end
+        end
+      end #  device pci 19.0
 
-                        device pci 19.0 on end
-                        device pci 19.0 on end
-                        device pci 19.1 on end
-                        device pci 19.2 on end
-                        device pci 19.3 on end
-                end
+      device pci 19.0 on end
+      device pci 19.0 on end
+      device pci 19.1 on end
+      device pci 19.2 on end
+      device pci 19.3 on end
+    end
 
 
 \end{verbatim}
 \begin{verbatim}
-	end #pci_domain
-#        chip drivers/generic/debug
-#        	device pnp 0.0 off end # chip name
-#                device pnp 0.1 on end # pci_regs_all
-#                device pnp 0.2 off end # mem
-#                device pnp 0.3 off end # cpuid
-#                device pnp 0.4 off end # smbus_regs_all
-#                device pnp 0.5 off end # dual core msr
-#                device pnp 0.6 off end # cache size
-#                device pnp 0.7 off end # tsc
+  end #pci_domain
+#  chip drivers/generic/debug
+#    device pnp 0.0 off end # chip name
+#    device pnp 0.1 on end # pci_regs_all
+#    device pnp 0.2 off end # mem
+#    device pnp 0.3 off end # cpuid
+#    device pnp 0.4 off end # smbus_regs_all
+#    device pnp 0.5 off end # dual core msr
+#    device pnp 0.6 off end # cache size
+#    device pnp 0.7 off end # tsc
 #       end
 
 end
 \end{verbatim}
-This is a trick used to debug by creating entries in the device tree. 
+This is a trick used to debug by creating entries in the device tree.
 
 \subsection{cpu socket}
-The CPU socket is the key link from mainboard to its CPUs. Since many models of CPU can go in a socket, the mainboard mentions only 
-the socket, and the socket, in turn, references the various model CPUs which can be plugged into it. The socket is thus the focus 
-of all defines and Makefile controls for building the CPU components of a board. 
+The CPU socket is the key link from mainboard to its CPUs. Since many models of CPU can go in a socket, the mainboard mentions only
+the socket, and the socket, in turn, references the various model CPUs which can be plugged into it. The socket is thus the focus
+of all defines and Makefile controls for building the CPU components of a board.
 
-\subsubsection{ /cpu/Kconfig}
-Defines variables. Current variables are: 
+\subsubsection{ cpu/Kconfig}
+Defines variables. Current variables are:
 \input{cpukconfig.tex}
-Sources all Kconfig files in the vendor directories. 
-\subsubsection{ /cpu/Makefile.inc}
-Unconditionally sources all Makefile.inc in the vendor directories. 
+Sources all Kconfig files in the vendor directories.
+\subsubsection{ cpu/Makefile.inc}
+Unconditionally sources all Makefile.inc in the vendor directories.
 
-\subsection{cpu/<vendor>/Kconfig}
-The only action currently taken is to source all Kconfig's in the 
-subdirectories. 
-\subsection{cpu/<vendor>/Makefile.inc}
-{\em Conditionally} source the socket directories. 
-Example: 
+\subsection{cpu/$<$vendor$>$/Kconfig}
+The only action currently taken is to source all Kconfig's in the
+subdirectories.
+\subsection{cpu/$<$vendor$>$/Makefile.inc}
+{\em Conditionally} source the socket directories.
+Example:
 \begin{verbatim}
 subdirs-$(CONFIG_CPU_AMD_SOCKET_F) += socket_F
 \end{verbatim}
 .
-CONFIG\_CPU\_AMD\_SOCKET\_F is set in a mainboard file. 
+CONFIG\_CPU\_AMD\_SOCKET\_F is set in a mainboard file.
 
-\subsection{cpu/<vendor>/<socket>/Kconfig}
-Set variables that relate to this {\em socket}, and {\em any models that plug into this socket}. Note that 
-the socket, as much as possible, should control the models, because the models may plug into many sockets. 
-Socket\_F currently sets: 
+\subsection{cpu/$<$vendor$>$/$<$socket$>$/Kconfig}
+Set variables that relate to this {\em socket}, and {\em any models that plug into this socket}. Note that
+the socket, as much as possible, should control the models, because the models may plug into many sockets.
+Socket\_F currently sets:
 \input{socketfkconfig.tex}
 
-It sources only those Kconfigs that relate to this particular socket, i.e. not all possible models are sourced. 
+It sources only those Kconfigs that relate to this particular socket, i.e. not all possible models are sourced.
 
-\subsection{cpu/<vendor>/<model>/Kconfig}
+\subsection{cpu/$<$vendor$>$/$<$model$>$/Kconfig}
 CPU Model Kconfigs only set variables, We do not expect that they will source any other Kconfig. The socket Kconfig should do that
-if needed. 
-\subsection{cpu/<vendor>/<model>/Makefile.inc}
-The Makefile.inc {\em unconditionally} specifies drivers and objects to be included in the build. There is no conditional 
-compilation at this point. IF a socket is included, it includes the models. If a model is included, it should include {em all} 
-objects, because it is not possible to determine at build time what options may be needed for a given model CPU. 
+if needed.
+\subsection{cpu/$<$vendor$>$/$<$model$>$/Makefile.inc}
+The Makefile.inc {\em unconditionally} specifies drivers and objects to be included in the build. There is no conditional
+compilation at this point. IF a socket is included, it includes the models. If a model is included, it should include {em all}
+objects, because it is not possible to determine at build time what options may be needed for a given model CPU.
 This Makefile.inc includes no other Makefile.inc files; any inclusion should be done in the socket Makefile.inc.
 
 \subsection{northbridge}
 \subsubsection{northbridge/Kconfig}
-No variables. Source all vendor directory Kconfigs. 
-\subsubsection{northbridge/Kconfig}
+No variables. Source all vendor directory Kconfigs.
+\subsubsection{northbridge/Makefile.inc}
 No variables. unconditionally include all vendor Makefile.inc
-\subsubsection{northbridge/<vendor>/Kconfig}
-No variables. Source all chip directory Kconfigs. 
-\subsubsection{northbridge/<vendor>/Makefile.inc}
-No variables. {\em Conditionally} include all chipset Makefile.inc. The variable 
-is the name of the part, e.g. 
+\subsubsection{northbridge/$<$vendor$>$/Kconfig}
+No variables. Source all chip directory Kconfigs.
+\subsubsection{northbridge/$<$vendor$>$/Makefile.inc}
+No variables. {\em Conditionally} include all chipset Makefile.inc. The variable
+is the name of the part, e.g.
 \begin{verbatim}
 subdirs-$(CONFIG_NORTHBRIDGE_AMD_AMDK8) += amdk8
 \end{verbatim}
 .
-\subsubsection{northbridge/<vendor>/<chip>/Kconfig}
-Typically a small number of variables. One defines the part name. Here is an example 
-of the variables defined for the K8. 
+\subsubsection{northbridge/$<$vendor$>$/$<$chip$>$/Kconfig}
+Typically a small number of variables. One defines the part name. Here is an example
+of the variables defined for the K8.
 \begin{verbatim}
 config NORTHBRIDGE_AMD_AMDK8
-	bool
-	default n
+  bool
+  default n
 
 config AGP_APERTURE_SIZE
-	hex
-	default 0x4000000
+  hex
+  default 0x4000000
 
 config HAVE_HIGH_TABLES
-	int
-	default 1
+  int
+  default 1
 \end{verbatim}
-\subsubsection{northbridge/<vendor>/<chip>/Makefile.inc}
-Typically very small set of rules, and very simple. 
-Since this file is already conditionally included, 
+\subsubsection{northbridge/$<$vendor$>$/$<$chip$>$/Makefile.inc}
+Typically very small set of rules, and very simple.
+Since this file is already conditionally included,
 we don't need to test for the chipset CONFIG variable. We
 can therefore test other variables (which is part of the reason
 we set up conditional inclusion of this file, instead
 of unconditionally including it). Here is an example from AMD K8.
-Note that we can make a variable conditional on the ACPI tables. 
+Note that we can make a variable conditional on the ACPI tables.
 \begin{verbatim}
 driver-y += northbridge.o
 driver-y += misc_control.o
@@ -459,8 +459,8 @@ 
 \subsubsection{vendor and part}
 \subsection{superio}
 \subsection{drivers/i2c}
-This is a rather special case. There are no Kconfig files or Makefile.inc files here. They are notneeed. 
-To compile in one of these files, name the .o directory. E.g. in serengeti\_cheetah we have: 
+This is a rather special case. There are no Kconfig files or Makefile.inc files here. They are not needed.
+To compile in one of these files, name the .o directory. E.g. in serengeti\_cheetah we have:
 \begin{verbatim}
 \end{verbatim}