| Submitter | Nathan Williams |
|---|---|
| Date | 2010-05-04 08:07:08 |
| Message ID | <4BDFD5AC.4020706@traverse.com.au> |
| Download | mbox | patch |
| Permalink | /patch/1285/ |
| State | Rejected, archived |
| Headers | show |
Comments
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
On 5/4/10 10:07 AM, Nathan Williams wrote: > Signed-off-by: Nathan Williams <nathan@traverse.com.au> > > - device pci 1.0 on end > - device pci 1.1 on end > + device pci 1.0 on end # Northbridge > + device pci 1.1 on end # Graphics > + device pci 1.2 on end # AES What's the impact of that change? Stefan
On 5/05/2010 12:15 AM, Stefan Reinauer wrote: > On 5/4/10 10:07 AM, Nathan Williams wrote: >> Signed-off-by: Nathan Williams <nathan@traverse.com.au> >> >> - device pci 1.0 on end >> - device pci 1.1 on end >> + device pci 1.0 on end # Northbridge >> + device pci 1.1 on end # Graphics >> + device pci 1.2 on end # AES > What's the impact of that change? > > Stefan > I don't think it makes any difference. I just added it for completeness/documentation. Nathan
On Tue, May 4, 2010 at 5:40 PM, Nathan Williams <nathan@traverse.com.au> wrote: > On 5/05/2010 12:15 AM, Stefan Reinauer wrote: >> On 5/4/10 10:07 AM, Nathan Williams wrote: >>> Signed-off-by: Nathan Williams <nathan@traverse.com.au> >>> >>> - device pci 1.0 on end >>> - device pci 1.1 on end >>> + device pci 1.0 on end # Northbridge >>> + device pci 1.1 on end # Graphics >>> + device pci 1.2 on end # AES >> What's the impact of that change? >> >> Stefan >> > > I don't think it makes any difference. I just added it for completeness/documentation. In general we try to only specify the devices that must be specified because they have special driver needs. It keeps the device trees cleaner. Things that can be probed for and initialized by the generic code are better left alone. Maybe a comment in the lx code would be a good way to document other functions. Thanks, Myles
Patch
Index: src/mainboard/digitallogic/msm800sev/devicetree.cb =================================================================== --- src/mainboard/digitallogic/msm800sev/devicetree.cb (revision 5521) +++ src/mainboard/digitallogic/msm800sev/devicetree.cb (working copy) @@ -1,7 +1,8 @@ chip northbridge/amd/lx device pci_domain 0 on - device pci 1.0 on end - device pci 1.1 on end + device pci 1.0 on end # Northbridge + device pci 1.1 on end # Graphics + device pci 1.2 on end # AES chip southbridge/amd/cs5536 # IRQ 12 and 1 unmasked, Keyboard and Mouse IRQs. OK # SIRQ Mode = Active(Quiet) mode. Save power.... Index: src/mainboard/amd/norwich/devicetree.cb =================================================================== --- src/mainboard/amd/norwich/devicetree.cb (revision 5521) +++ src/mainboard/amd/norwich/devicetree.cb (working copy) @@ -2,6 +2,7 @@ device pci_domain 0 on device pci 1.0 on end # Northbridge device pci 1.1 on end # Graphics + device pci 1.2 on end # AES chip southbridge/amd/cs5536 # IRQ 12 and 1 unmasked, Keyboard and Mouse IRQs. OK # SIRQ Mode = Active(Quiet) mode. Save power.... Index: src/mainboard/amd/db800/devicetree.cb =================================================================== --- src/mainboard/amd/db800/devicetree.cb (revision 5521) +++ src/mainboard/amd/db800/devicetree.cb (working copy) @@ -2,6 +2,7 @@ device pci_domain 0 on device pci 1.0 on end # Northbridge device pci 1.1 on end # Graphics + device pci 1.2 on end # AES chip southbridge/amd/cs5536 # IRQ 12 and 1 unmasked, Keyboard and Mouse IRQs. OK # SIRQ Mode = Active(Quiet) mode. Save power.... Index: src/mainboard/iei/pcisa-lx-800-r10/devicetree.cb =================================================================== --- src/mainboard/iei/pcisa-lx-800-r10/devicetree.cb (revision 5521) +++ src/mainboard/iei/pcisa-lx-800-r10/devicetree.cb (working copy) @@ -2,6 +2,7 @@ device pci_domain 0 on device pci 1.0 on end # Northbridge device pci 1.1 on end # Graphics + device pci 1.2 on end # AES chip southbridge/amd/cs5536 # IRQ 12 and 1 unmasked, Keyboard and Mouse IRQs. OK # SIRQ Mode = Active(Quiet) mode. Save power.... Index: src/mainboard/pcengines/alix1c/devicetree.cb =================================================================== --- src/mainboard/pcengines/alix1c/devicetree.cb (revision 5521) +++ src/mainboard/pcengines/alix1c/devicetree.cb (working copy) @@ -1,7 +1,8 @@ chip northbridge/amd/lx device pci_domain 0 on - device pci 1.0 on end - device pci 1.1 on end + device pci 1.0 on end # Northbridge + device pci 1.1 on end # Graphics + device pci 1.2 on end # AES chip southbridge/amd/cs5536 # IRQ 12 and 1 unmasked, Keyboard and Mouse IRQs. OK # SIRQ Mode = Active(Quiet) mode. Save power.... Index: src/mainboard/artecgroup/dbe61/devicetree.cb =================================================================== --- src/mainboard/artecgroup/dbe61/devicetree.cb (revision 5521) +++ src/mainboard/artecgroup/dbe61/devicetree.cb (working copy) @@ -2,6 +2,7 @@ device pci_domain 0 on device pci 1.0 on end # Northbridge device pci 1.1 on end # Graphics + device pci 1.2 on end # AES chip southbridge/amd/cs5536 # IRQ 12 and 1 unmasked, Keyboard and Mouse IRQs. OK # SIRQ Mode = Active(Quiet) mode. Save power.... Index: src/mainboard/winent/pl6064/devicetree.cb =================================================================== --- src/mainboard/winent/pl6064/devicetree.cb (revision 5521) +++ src/mainboard/winent/pl6064/devicetree.cb (working copy) @@ -2,6 +2,7 @@ device pci_domain 0 on device pci 1.0 on end # Northbridge device pci 1.1 on end # Graphics + device pci 1.2 on end # AES chip southbridge/amd/cs5536 # IRQ 12 and 1 unmasked, Keyboard and Mouse IRQs. OK # SIRQ Mode = Active(Quiet) mode. Save power....
Signed-off-by: Nathan Williams <nathan@traverse.com.au>