Comments
Patch
===================================================================
@@ -164,6 +164,10 @@ config ATI_RAGE_XL
source src/console/Kconfig
+config HAVE_ACPI_SLIC
+ bool
+ default n
+
config HAVE_ACPI_RESUME
bool
default n
===================================================================
@@ -33,6 +33,7 @@ config BOARD_GETAC_P470
select GENERATE_MP_TABLE
select HAVE_HARD_RESET
select HAVE_ACPI_RESUME
+ select HAVE_ACPI_SLIC
select HAVE_MAINBOARD_RESOURCES
select MMCONF_SUPPORT
select USE_PRINTK_IN_CAR
@@ -88,9 +89,3 @@ config FALLBACK_VGA_BIOS_FILE
string
default "getac-pci8086,27a2.rom"
depends on BOARD_GETAC_P470
-
-config HAVE_ACPI_SLIC
- bool
- default y
- depends on BOARD_GETAC_P470
-
===================================================================
@@ -88,9 +88,3 @@ config MAX_PHYSICAL_CPUS
int
default 2
depends on BOARD_INTEL_D945GCLF
-
-config HAVE_ACPI_SLIC
- bool
- default n
- depends on BOARD_INTEL_D945GCLF
-
===================================================================
@@ -65,9 +65,3 @@ config FALLBACK_VGA_BIOS_FILE
string
default "amipci_01.20"
depends on BOARD_KONTRON_986LCD_M
-
-config HAVE_ACPI_SLIC
- bool
- default n
- depends on BOARD_KONTRON_986LCD_M
-
===================================================================
@@ -62,9 +62,3 @@ config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex
default 0x6886
depends on BOARD_RODA_RK886EX
-
-config HAVE_ACPI_SLIC
- bool
- default n
- depends on BOARD_RODA_RK886EX
-
===================================================================
@@ -95,6 +95,6 @@ static const u32 mainboard_cim_verb_data
0x01F71F41,
};
-extern u32 * cim_verb_data;
+extern const u32 * cim_verb_data;
extern u32 cim_verb_data_size;
===================================================================
@@ -90,10 +90,10 @@ no_codec:
return 0;
}
-u32 * cim_verb_data = NULL;
+const u32 * cim_verb_data = NULL;
u32 cim_verb_data_size = 0;
-static u32 find_verb(struct device *dev, u32 viddid, u32 ** verb)
+static u32 find_verb(struct device *dev, u32 viddid, const u32 ** verb)
{
int idx=0;
@@ -166,7 +166,7 @@ static int wait_for_valid(u32 base)
static void codec_init(struct device *dev, u32 base, int addr)
{
u32 reg32;
- u32 *verb;
+ const u32 *verb;
u32 verb_size;
int i;
===================================================================
@@ -449,8 +449,6 @@ static void southbridge_smi_gpe0(unsigne
dump_gpe0_status(gpe0_sts);
}
-void __attribute__((weak)) mainboard_smi_gpi(u16 gpi_sts);
-
static void southbridge_smi_gpi(unsigned int node, smm_state_save_area_t *state_save)
{
u16 reg16;
Fix a couple more warnings: coreboot-builds/rca_rm4100/make.log:src/southbridge/intel/i82801dx/i82801dx_smihandler.c:452: warning: redundant redeclaration of 'mainboard_smi_gpi' coreboot-builds/via_vt8454c/make.log:src/arch/i386/include/arch/acpi.h:402:5: warning: "CONFIG_HAVE_ACPI_SLIC" is not defined coreboot-builds/getac_p470/make.log:src/mainboard/getac/p470/mainboard.c:83: warning: assignment discards qualifiers from pointer target type Signed-off-by: Myles Watson <mylesgw@gmail.com> Thanks, Myles