Patchwork Patch for Nokia-IP530, now with working PIRQ table, fix on the pirq_routing

login
register
about
Submitter marc bertens
Date 2010-05-27 10:30:32
Message ID <1274956232.28185.53.camel@andrala.reboot>
Download mbox | patch
Permalink /patch/1405/
State Accepted
Headers show

Comments

marc bertens - 2010-05-27 10:30:32
Signed-off-by: Marc Bertens <mbertens@xs4all.nl>

This is the patch for Kconfig, i have taken all unnessarry things out
- back to default HEAP size
- correct settings for the PIRQ table
- with comments

Marc 

On Thu, 2010-05-27 at 12:14 +0200, mbertens wrote:

> Part two now the PIRQ table for the Nokia IP530.
> 
> Changes made:
> - rebuild the table to get th eNICs and PCMCIA controllers get there
> correct IRQs assigned. 
> - Added a stub pirq_assign_irqs() due to the fact that it was missing at
> compilation time. This was discussed with Rudolf Marek (ruik)
> <r.marek@assembler.cz>
> 
> Marc
> 
> 
> On Thu, 2010-05-27 at 11:56 +0200, mbertens wrote:
> 
> > Hi all,
> > 
> > Here is the patch just for the pirq_routing() function. Its made
> > specific to the CONFIG_NORTHBRIDGE_INTEL_440BX if that is to generic 
> > please replace by CONFIG_BOARD_NOKIA_IP530. 
> > 
> > Put the following extras in the file; 
> > - added header accordingly "Common License Header" that was missing.
> > - corrected a printk() warning of the compiler.
> > - added the correction for the i440BX by AND the link value with 0x5F
> >  so that always the value is kept below 0x5F. That AND value should be
> >  0x03 i think because the link value cannot be greater than 3. But i'm
> >  not sure about that, thats why i used the current solution.
> > 
> > The other patches will follow to day.
> > 
> > Marc 
> > 
> > 
> > 
> > On Wed, 2010-05-26 at 15:14 -0600, Myles Watson wrote:
> > > On Wed, May 26, 2010 at 2:15 PM, mbertens <mbertens@xs4all.nl> wrote:
> > > > On Wed, 2010-05-26 at 11:00 -0600, Myles Watson wrote:
> > > >> +                     // fix made by Marc Bertens <mbertens@xs4all.nl>
> > > >> +                     if (link > 0x5f) {
> > > >> +                             // This is basically for the 440BX
> > > >> +                             link -= 0x5f;
> > > >> +                     }
> > > >>
> > > >> I'd prefer this to be guarded by
> > > >> #if CONFIG_NORTHBRIDGE_INTEL_440BX (or whatever the correct one is)
> > > > I was thinking of it to put it that way, but i'd. But i will make the
> > > > changes to the code.
> > > >>
> >

Patch

Index: src/mainboard/nokia/ip530/Kconfig
===================================================================
--- src/mainboard/nokia/ip530/Kconfig	(revision 5593)
+++ src/mainboard/nokia/ip530/Kconfig	(working copy)
@@ -25,9 +25,12 @@ 
 	select SOUTHBRIDGE_INTEL_I82371EB
 	select SUPERIO_SMSC_SMSCSUPERIO
 	select ROMCC
-	select HAVE_PIRQ_TABLE
+	# Fix made by Marc Bertens <mbertens@xs4all.nl>
+	# add correct PIRQ table support
+	# just the PIRQ_ROUTE is enough to enable the PIRQ TABLE
+	select PIRQ_ROUTE
 	select UDELAY_TSC
-	select BOARD_ROMSIZE_KB_256
+	select DEBUG

 config MAINBOARD_DIR
 	string