Patchwork Nokia IP530 finally fully working

login
register
about
Submitter marc bertens
Date 2010-06-01 18:30:32
Message ID <1275417032.6402.55.camel@andrala.reboot>
Download mbox | patch
Permalink /patch/1439/
State Accepted
Headers show

Comments

marc bertens - 2010-06-01 18:30:32
Hi all,

a last update the dirty hack in the pirq_routing is not needed, therefor
i made a new diff for it. This contains just the fix in the printk call,
to keep de compiler happy, and me too :-)

	Signed-off : Marc Bertens <mbertens@xs4all.nl>

	on the following patches;
	1.	arch-pirq-rouring.diff
	2.	dec21143-driver.diff
	3.	pcmcia-cardbus-driver.diff
	4.	working-nokia.diff

Marc


On Mon, 2010-05-31 at 22:23 +0200, mbertens wrote:
> hi all,
> 
> i was to fast on the send button, the Nokia IP530 is now finally fully
> working. 
> -	the four on-board NICs (22143PD)
> -	the 2 PCMCIA-Cardbus slots
> -	the 3 compact PCI expansion slots (with 12 NICs)
> 
> I got it working with 16 ethernet controller (all 21143PD), two HDDs on
> the primary IDE controller and two HDD's on the secondary controller.
> The on-board CF slot works as master on the primary IDE controller. very
> nice for silent running (hihi, with those 4 fan's in the back).
> 
> for the NICs i added a driver to the src/drivers/dec/21143. for the
> pcmcia-cardbus controller i added a driver to the
> src/drivers/ti/pcmcia-cardbus. these where required to get the devices
> proberly working. These are added as drivers so that other can use then
> in there configuration to. the parameters can be set in the
> configuration "menuconfig", "xconfig" or "gconfig". 
> 
> all this depends still on a patch to the
> 'src/arch/i386/boot/pirq_routing.c' to get the interrupt routing correct
> working. i will look into this to fix in the near future. 
> 
> I find the coreboot project a great project and i have a lot of fun
> working on it. and i will do so. Next on mylist is the Nokia-IP330, yes
> again a Nokia piece of hardware.
> 
> "That's all folks" 
> 
> Marc 
> 
> 
> 
> 	
> -- 
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
Myles Watson - 2010-06-01 19:36:45
On Tue, Jun 1, 2010 at 12:30 PM, mbertens <mbertens@xs4all.nl> wrote:
> Hi all,
>
> a last update the dirty hack in the pirq_routing is not needed, therefor
> i made a new diff for it. This contains just the fix in the printk call,
> to keep de compiler happy, and me too :-)
>
>        Signed-off : Marc Bertens <mbertens@xs4all.nl>
Acked-by: Myles Watson <mylesgw@gmail.com>

Rev 5604.

Thanks,
Myles

Patch

Index: src/arch/i386/boot/pirq_routing.c
===================================================================
--- src/arch/i386/boot/pirq_routing.c	(revision 5600)
+++ src/arch/i386/boot/pirq_routing.c	(working copy)
@@ -1,3 +1,23 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2000-2010 Coreboot project
+ * Copyright (C) 2010 Marc Bertens <mbertens@xs4all.nl>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
 #include <console/console.h>
 #include <arch/pirq_routing.h>
 #include <string.h>
@@ -64,7 +84,7 @@ 
 
 	rt_curr = (uint8_t*)addr;
 	rt_orig = (uint8_t*)&intel_irq_routing_table;
-	printk(BIOS_INFO, "Verifing copy of Interrupt Routing Table at 0x%08x... ", addr);
+	printk(BIOS_INFO, "Verifing copy of Interrupt Routing Table at 0x%08lx... ", addr);
 	for (i = 0; i < intel_irq_routing_table.size; i++) {
 		if (*(rt_curr + i) != *(rt_orig + i)) {
 			printk(BIOS_INFO, "failed\n");