Patchwork avoid IO resource conflicts

login
register
about
Submitter Stefan Reinauer
Date 2010-06-09 08:49:36
Message ID <4C0F55A0.2010506@coresystems.de>
Download mbox | patch
Permalink /patch/1493/
State Accepted
Commit r5624
Headers show

Comments

Stefan Reinauer - 2010-06-09 08:49:36
See patch

Stefan
The interrupt controller lives at I/O 0x4d0/0x4d1.
However on these platforms we were causing a resource conflict by
letting the resource allocator start allocations at 0x400.
Change the constraints to start at 0x1000 so we avoid allocating over
LPT ports (0x778-0x77f), PCI (0xcf8-0xcff) and some other fixed
resources that might live down there (smbus base, acpi base,...)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Myles Watson - 2010-06-09 13:06:28
Acked-by: Myles Watson <mylesgw@gmail.com>

Is 0x1000 standard now?  Should we just bump everything up that isn't there
yet?

Thanks,
Myles

Patch

Index: src/southbridge/via/vt8231/vt8231_lpc.c
===================================================================
--- src/southbridge/via/vt8231/vt8231_lpc.c	(revision 5623)
+++ src/southbridge/via/vt8231/vt8231_lpc.c	(working copy)
@@ -136,7 +136,7 @@ 
 
 	res = new_resource(dev, 1);
 	res->base = 0x0UL;
-	res->size = 0x400UL;
+	res->size = 0x1000UL;
 	res->limit = 0xffffUL;
 	res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 
Index: src/southbridge/via/vt8235/vt8235_lpc.c
===================================================================
--- src/southbridge/via/vt8235/vt8235_lpc.c	(revision 5623)
+++ src/southbridge/via/vt8235/vt8235_lpc.c	(working copy)
@@ -110,7 +110,7 @@ 
 	// Set gen config 0
 	pci_write_config8(dev, 0x80, 0x20);
 
-	// Set ACPI base address to IO 0x4000
+	// Set ACPI base address to IO 0x400
 	pci_write_config16(dev, 0x88, 0x0401);
 
 	// set ACPI irq to 5
@@ -223,7 +223,7 @@ 
 
 	res = new_resource(dev, 1);
 	res->base = 0x0UL;
-	res->size = 0x400UL;
+	res->size = 0x1000UL;
 	res->limit = 0xffffUL;
 	res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 
Index: src/southbridge/amd/cs5530/cs5530_isa.c
===================================================================
--- src/southbridge/amd/cs5530/cs5530_isa.c	(revision 5623)
+++ src/southbridge/amd/cs5530/cs5530_isa.c	(working copy)
@@ -33,7 +33,7 @@ 
 
 	res = new_resource(dev, 1);
 	res->base = 0x0UL;
-	res->size = 0x400UL;
+	res->size = 0x1000UL;
 	res->limit = 0xffffUL;
 	res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;