| Submitter | David Hendricks |
|---|---|
| Date | 2010-06-18 03:21:43 |
| Message ID | <AANLkTinaCL3k848F5wP_omEeUjdACxMpn5vPKwYsthaH@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/1527/ |
| State | Accepted |
| Commit | r1059 |
| Headers | show |
Comments
On Thu, Jun 17, 2010 at 8:21 PM, David Hendricks <dhendrix@google.com>wrote: > This patch adds support for the W25Q64. It's similar, but has its own > datasheet [Link<http://www.winbond.com.tw/hq/enu/ProductAndSales/ProductLines/FlashMemory/SerialFlash/W25Q64BV.htm>], > although it's mentioned in the W25Q{80,16,32} datasheet once. Ugh, botched editing on my part. What I meant to say is that it's similar to the W25Q80/16/32 in terms of supported instructions and the stuff that matters to Flashrom. (sorry for the spam)
On 18.06.2010 05:21, David Hendricks wrote: > This patch adds support for the W25Q64. > > I happen to have one and was able to successfully read, erase, and > write to it using an NM10 based device. I was only able to successfully > erase with D8h block erase and C7h chip erase commands, but other than that > it seemed to work great. > > Signed-off by: David Hendricks (dhendrix@google.com) > Thanks for your patch, committed in r1059. Regards, Carl-Daniel
On 24.06.2010 13:40, Carl-Daniel Hailfinger wrote: > On 18.06.2010 05:21, David Hendricks wrote: > >> This patch adds support for the W25Q64. >> >> I happen to have one and was able to successfully read, erase, and >> write to it using an NM10 based device. I was only able to successfully >> erase with D8h block erase and C7h chip erase commands, but other than that >> it seemed to work great. >> >> Signed-off by: David Hendricks (dhendrix@google.com) >> >> > > Thanks for your patch, committed in r1059. > I forgot to say: Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Regards, Carl-Daniel
Patch
Index: flashchips.c =================================================================== --- flashchips.c (revision 1048) +++ flashchips.c (working copy) @@ -5746,6 +5746,40 @@ { .vendor = "Winbond", + .name = "W25Q64", + .bustype = CHIP_BUSTYPE_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = W_25Q64, + .total_size = 8192, + .page_size = 256, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .write = spi_chip_write_256, + .read = spi_chip_read, + }, + + { + .vendor = "Winbond", .name = "W25x10", .bustype = CHIP_BUSTYPE_SPI, .manufacture_id = WINBOND_NEX_ID, Index: flashchips.h =================================================================== --- flashchips.h (revision 1048) +++ flashchips.h (working copy) @@ -510,6 +510,7 @@ #define W_25Q80 0x4014 #define W_25Q16 0x4015 #define W_25Q32 0x4016 +#define W_25Q64 0x4017 #define W_29C011 0xC1 #define W_29C020C 0x45 /* Same as W29C020 and ASD AE29F2008 */ #define W_29C040P 0x46 /* Same as W29C040 */
This patch adds support for the W25Q64. It's similar, but has its own datasheet [Link<http://www.winbond.com.tw/hq/enu/ProductAndSales/ProductLines/FlashMemory/SerialFlash/W25Q64BV.htm>], although it's mentioned in the W25Q{80,16,32} datasheet once. Anyway, I happen to have one and was able to successfully read, erase, and write to it using an NM10 based device. I was only able to successfully erase with D8h block erase and C7h chip erase commands, but other than that it seemed to work great. Patch attached. Signed-off by: David Hendricks (dhendrix@google.com)