Patchwork Added dependency checking for the USB EHCI debug Kconfig option

login
register
about
Submitter Cristi Magherusan
Date 2010-06-19 21:48:08
Message ID <1276984088.6251.9.camel@ufo>
Download mbox | patch
Permalink /patch/1528/
State New
Headers show

Comments

Cristi Magherusan - 2010-06-19 21:48:08
See attached patch.

I had to add that ifdef because config.h didn't have defined the
CONFIG_USBDEBUG_DIRECT option and compilation failed.
If anyone has an idea how I can get it defined there, I'm all ears.

Signed-off-by: Cristi Magherusan <cristi.magherusan@net.utcluj.ro>
Stefan Reinauer - 2010-06-20 00:00:25
On 6/19/10 11:48 PM, Cristi Magherusan wrote:
> See attached patch.
>
> I had to add that ifdef because config.h didn't have defined the
> CONFIG_USBDEBUG_DIRECT option and compilation failed.
> If anyone has an idea how I can get it defined there, I'm all ears.
>   
Why not just leave it as it is? Someone might plug an USB2 card into a
system that doesn't have the chip onboard.

Stefan
Cristi Magherusan - 2010-06-20 06:04:30
On Sun, 2010-06-20 at 02:00 +0200, Stefan Reinauer wrote:
> On 6/19/10 11:48 PM, Cristi Magherusan wrote:
> > See attached patch.
> >
> > I had to add that ifdef because config.h didn't have defined the
> > CONFIG_USBDEBUG_DIRECT option and compilation failed.
> > If anyone has an idea how I can get it defined there, I'm all ears.
> >   
> Why not just leave it as it is? Someone might plug an USB2 card into a
> system that doesn't have the chip onboard.
> 
> Stefan
> 
Compilation fails if you select the option and the support is not
implemented. If anyone wants to use the device with another motherboard,
he could easily mark it as supported by adding it to this list after the
support code done.

Regards,
Cristi

Patch

From 15a98ca0bc77a3808318ae4f49084fe7490da57d Mon Sep 17 00:00:00 2001
From: Cristi Magherusan <cristi.magherusan@net.utcluj.ro>
Date: Sun, 20 Jun 2010 00:37:00 +0300
Subject: [PATCH] Added dependency checking for the USB EHCI debug Kconfig option

Signed-off-by: Cristi Magherusan <cristi.magherusan@net.utcluj.ro>
---

 src/arch/i386/boot/coreboot_table.c |    2 ++
 src/console/Kconfig                 |    4 +++-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/arch/i386/boot/coreboot_table.c b/src/arch/i386/boot/coreboot_table.c

index bdf3b1b..d446060 100644

--- a/src/arch/i386/boot/coreboot_table.c

+++ b/src/arch/i386/boot/coreboot_table.c

@@ -146,9 +146,11 @@  static void lb_console(struct lb_header *header)

 #if CONFIG_CONSOLE_SROM
 	add_console(header, LB_TAG_CONSOLE_SROM);
 #endif
+#ifdef CONFIG_USBDEBUG_DIRECT 

 #if CONFIG_USBDEBUG_DIRECT
 	add_console(header, LB_TAG_CONSOLE_EHCI);
 #endif
+#endif

 }
 
 static void lb_framebuffer(struct lb_header *header)
diff --git a/src/console/Kconfig b/src/console/Kconfig

index b9d6f69..f8f615c 100644

--- a/src/console/Kconfig

+++ b/src/console/Kconfig

@@ -85,9 +85,11 @@  config TTYS0_LCS

 	default 3
 	depends on CONSOLE_SERIAL8250
 
-# TODO: FIX DEPENDENCY HERE

 config USBDEBUG_DIRECT
 	bool "USB 2.0 EHCI debug dongle support"
+	# only systems that are supported by coreboot are listed here

+	depends on (SOUTHBRIDGE_NVIDIA_MCP55 || SOUTHBRIDGE_SIS_SIS966 || \

+		SOUTHBRIDGE_AMD_SB600 || SOUTHBRIDGE_INTEL_I82801GX )

 	default n
 	help
 	  This option allows you to use a so-called USB EHCI Debug device
-- 

1.7.1