Patchwork Trying to add Kconfig support for M57SLI - build error

login
register
about
Submitter ron minnich
Date 2009-08-21 15:31:17
Message ID <13426df10908210831m4fd1c6e1w14ca055c778a0412@mail.gmail.com>
Download mbox | patch
Permalink /patch/157/
State Superseded
Headers show

Comments

ron minnich - 2009-08-21 15:31:17
This is *almost* perfect. Questions and changes.


Just make these -y. This Makefile.inc is *conditionally* included from
the src/cpu/amd/Makefile.inc. There's no reason to make
them conditional in turn.

Let's go around one more time taking into account my comments. We are
almost there.

ron

Patch

Index: src/cpu/amd/socket_AM2/Kconfig
===================================================================
--- src/cpu/amd/socket_AM2/Kconfig	(revision 0)
+++ src/cpu/amd/socket_AM2/Kconfig	(revision 0)
@@ -0,0 +1,30 @@ 
+config CPU_AMD_SOCKET_AM2
+	bool
+	default false
+
+config CPU_SOCKET_TYPE
+	hex
+	default 0x10
+	depends on CPU_AMD_SOCKET_AM2

It's a type 0x10?

+
+config K8_REV_F_SUPPORT
+	int	
+	default 1
+	depends on CPU_AMD_SOCKET_AM2

Socket AM2 supports REV F? I don't know, just asking.


+config CPU_SOCKET_TYPE
+	hex
+	default 0x11
+	depends on CPU_AMD_SOCKET_AM2

it's in here twice.


Index: src/cpu/amd/socket_AM2/Makefile.inc
===================================================================
--- src/cpu/amd/socket_AM2/Makefile.inc	(revision 0)
+++ src/cpu/amd/socket_AM2/Makefile.inc	(revision 0)
@@ -0,0 +1,14 @@ 
+obj-$(CONFIG_CPU_AMD_SOCKET_AM2) += socket_AM.o
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../model_fxx
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../dualcore
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../mtrr
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/tsc
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/mtrr
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/fpu
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/mmx
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/sse
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/lapic
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/cache
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/mtrr
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/pae
+subdirs-$(CONFIG_CPU_AMD_SOCKET_AM2) += ../../x86/smm