Patchwork new chip: AMIC A25L80P

login
register
about
Submitter Daniel Lenski
Date 2010-07-11 19:11:04
Message ID <1278875464.3021.3.camel@dlenski-desktop>
Download mbox | patch
Permalink /patch/1611/
State Accepted
Commit r1075
Headers show

Comments

Daniel Lenski - 2010-07-11 19:11:04
On Sun, 2010-07-11 at 20:25 +0200, Michael Karcher wrote:
> Your patch looks mostly fine. Please add a sign-off according to
> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
> 
> Also, please use tabs instead of spaces before the comment in flashchips.h.
> 
> Except for the tab issue, the patch is
> Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>

Got it, thanks.  Corrected patch for AMIC A25L80P attached.

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
Michael Karcher - 2010-07-11 22:22:57
Am Sonntag, den 11.07.2010, 15:11 -0400 schrieb Daniel Lenski:
> On Sun, 2010-07-11 at 20:25 +0200, Michael Karcher wrote:
> > Your patch looks mostly fine. Please add a sign-off according to
> > http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
> > 
> > Also, please use tabs instead of spaces before the comment in flashchips.h.
> > 
> > Except for the tab issue, the patch is
> > Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
> 
> Got it, thanks.  Corrected patch for AMIC A25L80P attached.
> 
> Signed-off-by: Daniel Lenski <dlenski@gmail.com>

Committed as r1075.

Regards,
  Michael Karcher
Carl-Daniel Hailfinger - 2010-07-11 22:33:40
Hi Daniel,

thanks for your patch.

On 11.07.2010 21:11, Daniel Lenski wrote:
> On Sun, 2010-07-11 at 20:25 +0200, Michael Karcher wrote:
>   
>> Your patch looks mostly fine. Please add a sign-off according to
>> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
>>
>> Also, please use tabs instead of spaces before the comment in flashchips.h.
>>
>> Except for the tab issue, the patch is
>> Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
>>     
>
> Got it, thanks.  Corrected patch for AMIC A25L80P attached.
>
> Signed-off-by: Daniel Lenski <dlenski@gmail.com>
>   

Could I interest you in implementing support for all other AMIC A25
series chips as well? Even if you can't test those, it would expand
flashrom coverage a lot.

Regards,
Carl-Daniel

Patch

Index: flashchips.h
===================================================================
--- flashchips.h	(revision 1074)
+++ flashchips.h	(working copy)
@@ -76,6 +76,7 @@ 
 #define AMIC_ID			0x7F37	/* AMIC */
 #define AMIC_ID_NOPREFIX	0x37	/* AMIC */
 #define AMIC_A25L40P		0x2013
+#define AMIC_A25L80P		0x2014
 #define AMIC_A29002B		0x0d
 #define AMIC_A29002T		0x8C	/* Same as A290021T */
 #define AMIC_A29040B		0x86
Index: flashchips.c
===================================================================
--- flashchips.c	(revision 1074)
+++ flashchips.c	(working copy)
@@ -1221,6 +1221,37 @@ 
 
 	{
 		.vendor		= "AMIC",
+		.name		= "A25L80P",
+		.bustype	= CHIP_BUSTYPE_SPI,
+		.manufacture_id	= AMIC_ID,
+		.model_id	= AMIC_A25L80P,
+		.total_size	= 1024,
+		.page_size	= 256,
+		.tested		= TEST_OK_PREW,
+		.probe		= probe_spi_rdid4,
+		.probe_timing	= TIMING_ZERO,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = {
+					{4 * 1024, 2},
+					{8 * 1024, 1},
+					{16 * 1024, 1},
+					{32 * 1024, 1},
+					{64 * 1024, 15},
+				},
+				.block_erase = spi_block_erase_d8,
+			}, {
+				.eraseblocks = { {1024 * 1024, 1} },
+				.block_erase = spi_block_erase_c7,
+			}
+		},
+		.write		= spi_chip_write_256,
+		.read		= spi_chip_read,
+	},
+
+	{
+		.vendor		= "AMIC",
 		.name		= "A29002B",
 		.bustype	= CHIP_BUSTYPE_PARALLEL,
 		.manufacture_id	= AMIC_ID_NOPREFIX,