Patchwork Clean up bad board list

login
register
about
Submitter Carl-Daniel Hailfinger
Date 2009-08-21 17:18:47
Message ID <4A8ED6F7.8000502@gmx.net>
Download mbox | patch
Permalink /patch/163/
State Superseded
Headers show

Comments

Carl-Daniel Hailfinger - 2009-08-21 17:18:47
Hi,

while going through the bad board list, I noticed that some boards
either have no public test reports, are classified incorrectly or have
chipset instead of board problems. None of them should be listed.

Chipset problem, not board related:
"ASUS" "M3N78 Pro"

Flashrom works with coreboot, fails only under factory BIOS:
"MSI" "MS-7260 (K9N Neo)"

No report:
"FIC" "VA-502"
"PCCHIPS" "M537DMA33"
"Soyo" "SY-5VD"

Our 0.9.1 release should look good.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Uwe Hermann - 2009-08-21 18:59:42
On Fri, Aug 21, 2009 at 07:18:47PM +0200, Carl-Daniel Hailfinger wrote:
> while going through the bad board list, I noticed that some boards
> either have no public test reports, are classified incorrectly or have
> chipset instead of board problems. None of them should be listed.

Hm, why not? The list contains boards that are verified not to work
with flashrom. Whether this is due to missing board-enable or to missing
chipset-code or to missing datasheets is irrelevant for the user,
flashrom will still not work regardless of the reason.

Maybe we also want a known-bad-chipsets list (for those without
datasheets for example)?


> Chipset problem, not board related:
> "ASUS" "M3N78 Pro"

See above.

In this case we don't have datasheets for NVIDIA flash translation IIRC,
so yes, this affects all boards with that chipset using NVIDIA flash
translation. It's not as easy as "all boards with MCP78 chipset" though
(unfortunately).


> Flashrom works with coreboot, fails only under factory BIOS:
> "MSI" "MS-7260 (K9N Neo)"

Yeah, this is debatable, and I should probably re-check latest flashrom
here with BIOS and coreboot, maybe things changed.


> No report:
> "FIC" "VA-502"
> "Soyo" "SY-5VD"

These two can stay, the info was taken from the wiki, and added to the
wiki by me quite a while ago. I tested both boards myself using actual
hardware.

http://www.coreboot.org/index.php?title=Flashrom&diff=next&oldid=7265
http://www.coreboot.org/index.php?title=Flashrom&diff=next&oldid=7321


> "PCCHIPS" "M537DMA33"

This guy I'll have to check. Also added by me in
http://www.coreboot.org/index.php?title=Flashrom&diff=next&oldid=7304
but I can't remember if this is a board I owned or if I added the
entry based on info from someone in IRC (or maybe I tested a board
of some friend or so, dunno).

Feel free to drop this one for now, if I can verify where the report
came from we can re-add it.


Uwe.
Carl-Daniel Hailfinger - 2009-08-21 22:52:34
Hi Uwe,

thank you for your comments. I tried to answer them in detail.

On 21.08.2009 20:59, Uwe Hermann wrote:
> On Fri, Aug 21, 2009 at 07:18:47PM +0200, Carl-Daniel Hailfinger wrote:
>   
>> while going through the bad board list, I noticed that some boards
>> either have no public test reports, are classified incorrectly or have
>> chipset instead of board problems. None of them should be listed.
>>     
>
> Hm, why not? The list contains boards that are verified not to work
> with flashrom. Whether this is due to missing board-enable or to missing
> chipset-code or to missing datasheets is irrelevant for the user,
> flashrom will still not work regardless of the reason.
>   

With that reasoning, we should add every every non-x86 board to the list
because flashrom doesn't support them (yet). And we should list all
Intel network cards because we don't suppport them. And every 3Com
network card which is not yet in the PCI ID list. Same applies to Nvidia
and ATI graphics cards.

Negative lists can grow very fast if we include every model in a class
of unsupported hardware. At most, list the class as unsupported. Then
again, we don't list unsupported programmers. And we don't list
unsupported network cards. Why shouldn't the same policy be applied to
mainboards? If the chipset is not supported, don't list the mainboards
at all.


> Maybe we also want a known-bad-chipsets list (for those without
> datasheets for example)?
>   

The chipset enable can simply issue a warning if not all functions are
supported. We fully support some chipsets for which we don't have
datasheets. If we don't support the chipset at all, we should not list it.


>> Chipset problem, not board related:
>> "ASUS" "M3N78 Pro"
>>     
>
> See above.
>
> In this case we don't have datasheets for NVIDIA flash translation IIRC,
> so yes, this affects all boards with that chipset using NVIDIA flash
> translation. It's not as easy as "all boards with MCP78 chipset" though
> (unfortunately).
>   

I hope I explained my point above well enough.


>> Flashrom works with coreboot, fails only under factory BIOS:
>> "MSI" "MS-7260 (K9N Neo)"
>>     
>
> Yeah, this is debatable, and I should probably re-check latest flashrom
> here with BIOS and coreboot, maybe things changed.
>   

Can't we at least list that board as semi-supported instead of broken?


>> No report:
>> "FIC" "VA-502"
>> "Soyo" "SY-5VD"
>>     
>
> These two can stay, the info was taken from the wiki, and added to the
> wiki by me quite a while ago. I tested both boards myself using actual
> hardware.
>
> http://www.coreboot.org/index.php?title=Flashrom&diff=next&oldid=7265
> http://www.coreboot.org/index.php?title=Flashrom&diff=next&oldid=7321
>   

OK, can stay.


>> "PCCHIPS" "M537DMA33"
>>     
>
> This guy I'll have to check. Also added by me in
> http://www.coreboot.org/index.php?title=Flashrom&diff=next&oldid=7304
> but I can't remember if this is a board I owned or if I added the
> entry based on info from someone in IRC (or maybe I tested a board
> of some friend or so, dunno).
>
> Feel free to drop this one for now, if I can verify where the report
> came from we can re-add it.
>   

Thanks, I'll send an updated patch.

Regards,
Carl-Daniel

Patch

Index: flashrom-badboard_cleanup/print.c
===================================================================
--- flashrom-badboard_cleanup/print.c	(Revision 694)
+++ flashrom-badboard_cleanup/print.c	(Arbeitskopie)
@@ -420,7 +420,6 @@ 
  
 	/* Verified non-working boards (for now). */
 	{ "Abit",		"IS-10",		"http://www.abit.com.tw/page/en/motherboard/motherboard_detail.php?pMODEL_NAME=IS-10&fMTYPE=Socket+478" },
-	{ "ASUS",		"M3N78 Pro",		"http://www.asus.com/product.aspx?P_ID=DVvm9CU0G1bCC4gp" },
 	{ "ASUS",		"MEW-AM",		"ftp://ftp.asus.com.tw/pub/ASUS/mb/sock370/810/mew-am/" },
 	{ "ASUS",		"MEW-VM",		"http://www.elhvb.com/mboards/OEM/HP/manual/ASUS%20MEW-VM.htm" },
 	{ "ASUS",		"P3B-F",		"ftp://ftp.asus.com.tw/pub/ASUS/mb/slot1/440bx/p3b-f/" },
@@ -429,11 +428,7 @@ 
 	{ "Biostar",		"M6TBA",		"ftp://ftp.biostar-usa.com/manuals/M6TBA/" },
 	{ "Boser",		"HS-6637",		"http://www.boser.com.tw/manual/HS-62376637v3.4.pdf" },
 	{ "DFI",		"855GME-MGF",		"http://www.dfi.com.tw/portal/CM/cmproduct/XX_cmproddetail/XX_WbProdsWindow?action=e&downloadType=&windowstate=normal&mode=view&downloadFlag=false&itemId=433" },
-	{ "FIC",		"VA-502",		"ftp://ftp.fic.com.tw/motherboard/manual/socket7/va-502/" },
 	{ "MSI",		"MS-6178",		"http://www.msi-technology.de/index.php?func=proddesc&prod_no=343&maincat_no=1" },
-	{ "MSI",		"MS-7260 (K9N Neo)",	"http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=255" },
-	{ "PCCHIPS",		"M537DMA33",		"http://motherboards.mbarron.net/models/pcchips/m537dma.htm" },
-	{ "Soyo",		"SY-5VD",		"http://www.soyo.com/content/Downloads/163/&c=80&p=464&l=English" },
 	{ "Sun",		"Fire x4540",		"http://www.sun.com/servers/x64/x4540/" },
 	{ "Sun",		"Fire x4150",		"http://www.sun.com/servers/x64/x4150/" },
 	{ "Sun",		"Fire x4200",		"http://www.sun.com/servers/entry/x4200/" },
@@ -466,9 +461,7 @@ 
 	{ "Acer",		"Aspire One",		"See http://www.coreboot.org/pipermail/coreboot/2009-May/048041.html." },
 
 	/* Verified non-working boards (for now). */
-	{ "ASUS",		"M3N78 Pro",		"SPI flash translation seems to be done in the NVIDIA MCP78 southbridge, but we don't have MCP78 datasheets." },
 	{ "MSI",		"MS-6178",		"Immediately powers off if you try to hot-plug the chip. However, this does '''not''' happen if you use coreboot." },
-	{ "MSI",		"MS-7260 (K9N Neo)",	"Interestingly flashrom does not work when the vendor BIOS is booted, but it ''does'' work flawlessly when the machine is booted with coreboot." },
 
 	/* Verified working laptops. */
 	/* None which need comments, yet... */
Index: flashrom-badboard_cleanup/board_enable.c
===================================================================
--- flashrom-badboard_cleanup/board_enable.c	(Revision 694)
+++ flashrom-badboard_cleanup/board_enable.c	(Arbeitskopie)
@@ -1054,7 +1054,6 @@ 
 const struct board_info boards_bad[] = {
 	/* Verified non-working boards (for now). */
 	{ "Abit",		"IS-10", },
-	{ "ASUS",		"M3N78 Pro", },
 	{ "ASUS",		"MEW-AM", },
 	{ "ASUS",		"MEW-VM", },
 	{ "ASUS",		"P3B-F", },
@@ -1063,11 +1062,7 @@ 
 	{ "Biostar",		"M6TBA", },
 	{ "Boser",		"HS-6637", },
 	{ "DFI",		"855GME-MGF", },
-	{ "FIC",		"VA-502", },
 	{ "MSI",		"MS-6178", },
-	{ "MSI",		"MS-7260 (K9N Neo)", },
-	{ "PCCHIPS",		"M537DMA33", },
-	{ "Soyo",		"SY-5VD", },
 	{ "Sun",		"Fire x4150", },
 	{ "Sun",		"Fire x4200", },
 	{ "Sun",		"Fire x4540", },