Patchwork Trying to add Kconfig support for M57SLI - build error

login
register
about
Submitter Harald Gutmann
Date 2009-08-21 18:12:55
Message ID <200908212012.55186.harald.gutmann@gmx.net>
Download mbox | patch
Permalink /patch/165/
State Accepted
Headers show

Comments

Harald Gutmann - 2009-08-21 18:12:55
On Friday 21 August 2009 20:00:23 ron minnich wrote:
> let's slow down on these patches.
>
> We're moving way too fast and it's getting confusing, and errors and
> mistakes are creeping in. Cristi is right.
>
> Let's first do AM2. Then nvidia south. And so on.
>
> OK, I am going to apply Cristi's patch, and, if it looks good, commit.
> Then we can do nvidia south.
Okay, sounds good.

I've reviewed the mcp55 Kconfig once more and attached it.
It seems for me that it is fine, and should work normally.

This patch is:
Signed-off-by: Harald Gutmann <harald.gutmann@gmx.net>

> ron
Harald
Myles Watson - 2009-08-21 18:21:27
> > OK, I am going to apply Cristi's patch, and, if it looks good, commit.
> > Then we can do nvidia south.
> Okay, sounds good.
Lets not create a new CONFIG variable SOUTHBRIDGE_NVIDIA_MCP55.  I think
that whole file can go.  And the files that source it.
Index: nvidia/mcp55/Kconfig
Index: nvidia/Kconfig

I'd rather you didn't remove the ck804 references, since my patch will have
to put them back.

+driver-$(CONFIG_HAVE_ACPI_TABLES) += mcp55_fadt.o
I think you mean obj here.

Thanks,
Myles

Patch

Index: Kconfig
===================================================================
--- Kconfig	(revision 4559)
+++ Kconfig	(working copy)
@@ -1,7 +1,7 @@ 
 source src/southbridge/amd/Kconfig
 #source src/southbridge/broadcom/Kconfig
 source src/southbridge/intel/Kconfig
-#source src/southbridge/nvidia/Kconfig
+source src/southbridge/nvidia/Kconfig
 #source src/southbridge/ricoh/Kconfig
 #source src/southbridge/sis/Kconfig
 source src/southbridge/via/Kconfig
Index: nvidia/Kconfig
===================================================================
--- nvidia/Kconfig	(revision 4560)
+++ nvidia/Kconfig	(working copy)
@@ -1,2 +1 @@ 
-source src/southbridge/nvidia/ck804/Kconfig
 source src/southbridge/nvidia/mcp55/Kconfig
Index: nvidia/Makefile.inc
===================================================================
--- nvidia/Makefile.inc	(revision 4560)
+++ nvidia/Makefile.inc	(working copy)
@@ -1,3 +1 @@ 
-subdirs-y += ck804
 subdirs-y += mcp55
-
Index: nvidia/mcp55/Kconfig
===================================================================
--- nvidia/mcp55/Kconfig	(revision 0)
+++ nvidia/mcp55/Kconfig	(revision 0)
@@ -0,0 +1,22 @@ 
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2008-2009 coresystems GmbH
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+##
+
+config SOUTHBRIDGE_NVIDIA_MCP55
+	bool
+	default n
Index: nvidia/mcp55/Makefile.inc
===================================================================
--- nvidia/mcp55/Makefile.inc	(revision 0)
+++ nvidia/mcp55/Makefile.inc	(revision 0)
@@ -0,0 +1,20 @@ 
+driver-y += mcp55.o
+driver-y += mcp55_aza.o
+driver-y += mcp55_early_ctrl.o
+driver-y += mcp55_early_setup_car.o
+driver-y += mcp55_early_smbus.o
+driver-y += mcp55_enable_rom.o
+driver-$(CONFIG_USB_DEBUG_DIRECT) += mcp55_enable_usbdebug_direct.o
+driver-y += mcp55_ht.o
+driver-y += mcp55_ide.o
+driver-y += mcp55_lpc.o
+driver-y += mcp55_nic.o
+driver-y += mcp55_pci.o
+driver-y += mcp55_pcie.o
+driver-y += mcp55_sata.o
+driver-y += mcp55_smbus.o
+driver-y += mcp55_usb2.o
+driver-y += mcp55_usb.o
+driver-$(CONFIG_HAVE_ACPI_TABLES) += mcp55_fadt.o
+
+obj-y += mcp55_reset.o