| Submitter | baiyin cai |
|---|---|
| Date | 2010-07-26 23:33:43 |
| Message ID | <AANLkTimDU--9unKGyEY=g9fD_2mvANhfEmj2gLrasiC8@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/1686/ |
| State | Accepted |
| Headers | show |
Comments
baiyin cai wrote: > hi all, > since the xcompile file is generated for different compiler, i think it > should be included under the PHONY distclean, am i right? I think that makes good sense, but I hope to hear also from more people. > Signed-off-by Cai Bai Yin <caibaiyin.pku@gmail.com> Acked-by: Peter Stuge <peter@stuge.se> If there's no disagreement I can commit a little later. //Peter
i agree it seems pretty good... On Tue, Jul 27, 2010 at 8:35 AM, Peter Stuge <peter@stuge.se> wrote: > baiyin cai wrote: > > hi all, > > since the xcompile file is generated for different compiler, i think > it > > should be included under the PHONY distclean, am i right? > > I think that makes good sense, but I hope to hear also from more > people. > > > > Signed-off-by Cai Bai Yin <caibaiyin.pku@gmail.com> > > Acked-by: Peter Stuge <peter@stuge.se> > > If there's no disagreement I can commit a little later. > > > //Peter > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot >
hi all, i added another fix into this patch. besides of the xcoompile patch, it resolved the bug of filo+libpayload building. the bug is if libpayload is installed before filo load "make -C ../libpayload/Makefile DEST=**", it would not install correctly. Signed-off-by Cai Bai Yin <caibaiyin.pku@gmail.com> 2010/7/27 Qing Pei Wang <wangqingpei@gmail.com> > i agree it seems pretty good... > > > On Tue, Jul 27, 2010 at 8:35 AM, Peter Stuge <peter@stuge.se> wrote: > >> baiyin cai wrote: >> > hi all, >> > since the xcompile file is generated for different compiler, i think >> it >> > should be included under the PHONY distclean, am i right? >> >> I think that makes good sense, but I hope to hear also from more >> people. >> >> >> > Signed-off-by Cai Bai Yin <caibaiyin.pku@gmail.com> >> >> Acked-by: Peter Stuge <peter@stuge.se> >> >> If there's no disagreement I can commit a little later. >> >> >> //Peter >> >> -- >> coreboot mailing list: coreboot@coreboot.org >> http://www.coreboot.org/mailman/listinfo/coreboot >> > > > > -- > Wang Qing Pei > Phone: 86+13426369984 > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot >
On Tue, Jul 27, 2010 at 10:47 PM, baiyin cai <caibaiyin.pku@gmail.com> wrote: > hi all, > i added another fix into this patch. > besides of the xcoompile patch, it resolved the bug of filo+libpayload > building. > the bug is if libpayload is installed before filo load "make -C > ../libpayload/Makefile DEST=**", it would not > install correctly. > > Signed-off-by Cai Bai Yin <caibaiyin.pku@gmail.com> > > > 2010/7/27 Qing Pei Wang <wangqingpei@gmail.com> >> >> i agree it seems pretty good... >> >> On Tue, Jul 27, 2010 at 8:35 AM, Peter Stuge <peter@stuge.se> wrote: >>> >>> baiyin cai wrote: >>> > hi all, >>> > since the xcompile file is generated for different compiler, i think >>> > it >>> > should be included under the PHONY distclean, am i right? >>> >>> I think that makes good sense, but I hope to hear also from more >>> people. >>> >>> >>> > Signed-off-by Cai Bai Yin <caibaiyin.pku@gmail.com> >>> >>> Acked-by: Peter Stuge <peter@stuge.se> >>> >>> If there's no disagreement I can commit a little later. >>> >>> >>> //Peter Acked-by: Marc Jones <marcj303@gmail.com> r5672
Patch
Index: Makefile =================================================================== --- Makefile (revision 5668) +++ Makefile (working copy) @@ -163,7 +163,7 @@ distclean: clean $(Q)rm -rf build # should be $(obj) ? - $(Q)rm -f .config .config.old ..config.tmp .kconfig.d .tmpconfig* + $(Q)rm -f .config .config.old ..config.tmp .kconfig.d .tmpconfig* .xcompile # This include must come _before_ the pattern rules below! # Order _does_ matter for pattern rules.