Patchwork Board enable for Asus P4S800-MX

login
register
about
Submitter David Borg
Date 2010-08-01 20:32:44
Message ID <AANLkTikOKrHnyvgfDdDxXMiFuDkUhTxRA659OgDwAEFY@mail.gmail.com>
Download mbox | patch
Permalink /patch/1708/
State Accepted
Commit r1130
Headers show

Comments

David Borg - 2010-08-01 20:32:44
> If you just have one subsystem ID, DMI might be a good idea. I suggested
> not to use the IDE controller for the second subsystem ID, as it varies
> with AHCI/RAID/whatsoever modes, but this board is so old, it has
> nothing of them. I suggest to use the IDE PCI ID with subsystem as
> second device and drop the DMI.

Yes in fact the only settings you can change in the bios are related
to UDMA modes and such.
And btw, I was wrong on iRC - all USB controllers can be disabled.

Attached patch updated as suggested & tested.

Regards,
David Borg
Michael Karcher - 2010-08-02 07:24:06
Am Sonntag, den 01.08.2010, 22:32 +0200 schrieb David Borg:
> Attached patch updated as suggested & tested.

If you add you sign-off (see
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure ),
this is
Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>

I can commit it after sign-off.

Regards,
  Michael Karcher
David Borg - 2010-08-02 08:09:37
Oh sorry, thought the original sign-off was enough.

Signed-off-by: David Borg <borg.db@gmail.com>

On 2 August 2010 09:24, Michael Karcher
<flashrom@mkarcher.dialup.fu-berlin.de> wrote:
> Am Sonntag, den 01.08.2010, 22:32 +0200 schrieb David Borg:
>> Attached patch updated as suggested & tested.
>
> If you add you sign-off (see
> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure ),
> this is
> Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
>
> I can commit it after sign-off.
>
> Regards,
>  Michael Karcher
>
>
Michael Karcher - 2010-08-02 08:30:16
Am Montag, den 02.08.2010, 10:09 +0200 schrieb David Borg:
> Oh sorry, thought the original sign-off was enough.
> 
> Signed-off-by: David Borg <borg.db@gmail.com>
Thanks, this is r1130 now.

Regards,
  Michael Karcher
Uwe Hermann - 2010-08-08 21:59:47
On Sun, Aug 01, 2010 at 10:32:44PM +0200, David Borg wrote:
> +	{0x1039, 0x0661, 0x1043, 0x8113,  0x1039, 0x5513, 0x1043, 0x8087, NULL,          NULL,         NULL,          "ASUS",        "P4S800-MX",             512, OK, w836xx_memw_enable_2e},

Just for archival purposes, we talked about this on IRC. David did
indeed test writing a 512KB image of random bytes to the chip on this
board, so the "512" max. decode size is listed correctly here, just in
case anyone is wondering when browsing the archives.


Uwe.

Patch

Index: board_enable.c
===================================================================
--- board_enable.c	(revision 1129)
+++ board_enable.c	(working copy)
@@ -352,7 +352,9 @@ 
 }
 
 /**
- * w83627: Enable MEMW# and set ROM size to max.
+ * Enable MEMW# and set ROM size to max.
+ * Supported chips:
+ * W83L517D, W83697HF/F/HG, W83697SF/UF/UG
  */
 static void w836xx_memw_enable(uint16_t port)
 {
@@ -1715,6 +1717,7 @@ 
 	{0x8086, 0x24D3, 0x1043, 0x80A6,  0x8086, 0x2578, 0x1043, 0x80F6, NULL,          NULL,         NULL,          "ASUS",        "P4C800-E Deluxe",       0,   OK, intel_ich_gpio21_raise},
 	{0x8086, 0x2570, 0x1043, 0x80F2,  0x105A, 0x3373, 0x1043, 0x80F5, NULL,          NULL,         NULL,          "ASUS",        "P4P800-E Deluxe",       0,   OK, intel_ich_gpio21_raise},
 	{0x8086, 0x2570, 0x1043, 0x80A5,  0x105A, 0x24D3, 0x1043, 0x80A6, NULL,          NULL,         NULL,          "ASUS",        "P4SD-LA",               0,   NT, intel_ich_gpio32_raise},
+	{0x1039, 0x0661, 0x1043, 0x8113,  0x1039, 0x5513, 0x1043, 0x8087, NULL,          NULL,         NULL,          "ASUS",        "P4S800-MX",             512, OK, w836xx_memw_enable_2e},
 	{0x10B9, 0x1541,      0,      0,  0x10B9, 0x1533,      0,      0, "^P5A$",       "asus",       "p5a",         "ASUS",        "P5A",                   0,   OK, board_asus_p5a},
 	{0x10DE, 0x0030, 0x1043, 0x818a,  0x8086, 0x100E, 0x1043, 0x80EE, NULL,          NULL,         NULL,          "ASUS",        "P5ND2-SLI Deluxe",      0,   OK, nvidia_mcp_gpio10_raise},
 	{0x8086, 0x24dd, 0x1043, 0x80a6,  0x8086, 0x2570, 0x1043, 0x8157, NULL,          NULL,         NULL,          "ASUS",        "P5PE-VM",               0,   OK, intel_ich_gpio21_raise},