Patchwork [superiotool] Add support for Nuvoton NCT5571D

login
register
about
Submitter Corey Osgood
Date 2010-08-04 09:16:23
Message ID <AANLkTinf-YaNUkrcPVS3iL9B_tE0i+oLxRnSx74r34JM@mail.gmail.com>
Download mbox | patch
Permalink /patch/1719/
State Accepted
Headers show

Comments

Corey Osgood - 2010-08-04 09:16:23
On Wed, Aug 4, 2010 at 5:13 AM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> Am Mittwoch, den 04.08.2010, 03:36 -0400 schrieb Corey Osgood:
>> Patch attached, and output below (from Zotac NM10 board)
>
> It looks like you picked the wrong file in the file chooser. `Makefile`
> is attached.
>

Oops! Let me try that one again.


> […]
>
>
> Thanks,
>
> Paul
>
> --
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>
Uwe Hermann - 2010-08-09 23:20:16
On Wed, Aug 04, 2010 at 05:16:23AM -0400, Corey Osgood wrote:
> Add support for the Nuvoton NCT5571D. This chip acts nothing like the other 
> supported Nuvoton chip, but identical to a Winbond, and Nuvoton is a subsidary 
> of Winbond, so for simplicity's sake I've added it to the Winbond file.
> 
> Signed-off-by: Corey Osgood <corey.osgood@gmail.com>

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>

Looks good, please commit. At some point we should fix the code a bit
wrt vendor name, I guess it prints "Found Winbond Nuvoton NCT5571D"
right now, but that's for another patch.


Uwe.

Patch

Add support for the Nuvoton NCT5571D. This chip acts nothing like the other 
supported Nuvoton chip, but identical to a Winbond, and Nuvoton is a subsidary 
of Winbond, so for simplicity's sake I've added it to the Winbond file.

Signed-off-by: Corey Osgood <corey.osgood@gmail.com>

Index: winbond.c
===================================================================
--- winbond.c	(revision 5682)
+++ winbond.c	(working copy)
@@ -238,6 +238,52 @@ 
 	{0xa51, "W83667HG", {
 		/* See also: http://lists.lm-sensors.org/pipermail/lm-sensors/2008-July/023683.html */
 		{EOT}}},
+	{0xb35, "Nuvoton NCT5571D", {
+		{NOLDN, NULL,
+			{0x02,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28,0x29,
+			 0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},
+			{RSVD,0xb3,NANA,0xff,0x00,0x40,0x00,MISC,0xff,0x20,0x00,
+			 0x00,0x7f,0x0a,0x08,0x00,MISC,EOT}},
+		{0x2, "COM1",
+			{0x30,0x60,0x61,0x70,0xf0,EOT},
+			{0x01,0x03,0xf8,0x04,0x00,EOT}},
+		{0x5, "Keyboard",
+			{0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT},
+			{0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}},
+		{0x7, "GPIO 6, GPIO 8, GPIO 9",
+			{0x30,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,0xea,0xeb,0xec,0xed,
+			 0xee,0xf4,0xf5,0xf6,0xf7,0xf8,EOT},
+			{0x18,0xef,MISC,0x00,0x00,0xff,MISC,0x00,0x00,RSVD,0x00,
+			 0x00,0xff,MISC,0x00,0x00,0x00,EOT}},
+		{0x9, "GPIO 2, GPIO 3, GPIO 5",
+			{0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9,0xea,
+			 0xeb,0xf4,0xf5,0xf6,0xf7,0xfe,EOT},
+			{0x05,0xff,MISC,0x00,0x00,0xff,MISC,0x00,0x00,0x00,0x00,
+			 0x00,0xff,MISC,0x00,0x00,0x00,EOT}},
+		{0xa, "ACPI",
+			{0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,0xf2,
+			 0xf3,0xf4,0xf6,0xf7,0xfe,0xff,EOT},
+			{0x01,0x00,0xff,0x00,0x00,0x02,0x1c,0x00,RSVD,0x00,0x7c,
+			 0x00,0x00,0x00,0x00,0x00,0x30,EOT}},
+		{0xb, "Hardware monitor",
+			{0x30,0x60,0x61,0x70,0xe0,0xe1,0xe2,0xe3,0xf0,0xf5,EOT},
+			{0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xc1,0x10,EOT}},
+		{0xc, "PECI",
+			{0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe8,0xe9,0xea,0xec,
+			 0xee,0xef,0xf1,0xf2,0xf3,0xfe,0xff,EOT},
+			{0x00,0x48,0x48,0x48,0x48,0x00,0x00,0x00,RSVD,0x00,0x00,
+			 0x01,0x5a,0x48,0x50,0x10,0x80,0x01,EOT}},
+		{0xd, "SUSLED",
+			{0xec,EOT},
+			{0x01,EOT}},
+		{0xf, "GPIO Push-Pull/OD Select",
+			{0xe0,0xe1,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,0xf0,0xf1,
+			 0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,0xfc,
+			 0xfd,0xfe,0xff,EOT},
+			{RSVD,0xfd,RSVD,0xf7,0xcb,RSVD,0xff,0xff,0x00,MISC,MISC,
+			 MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,
+			 MISC,MISC,MISC,EOT}},
+		{EOT}}},
 
 	/* ID and rev */
 	{0x9771, "W83977F-A/G-A/AF-A/AG-A", {