Patchwork nicnatsemi.c: Typo. s/are apparently don't/apparently don't/

login
register
about
Submitter David Borg
Date 2010-08-07 12:51:09
Message ID <AANLkTinkcBK0TtuYCfcYW2OJVx-=bNAhTPw5hR2xm=ed@mail.gmail.com>
Download mbox | patch
Permalink /patch/1727/
State Accepted
Commit 1135
Headers show

Comments

David Borg - 2010-08-07 12:51:09
On 13 June 2010 00:06, Andrew Morgan <ziltro@ziltro.com> wrote:
>
> On 12/06/10 22:28, Carl-Daniel Hailfinger wrote:
>>
>> On 12.06.2010 22:52, Paul Menzel wrote:
>>
>>>
>>> -        * Bit 8-31 of this register are apparently don't care, and if this
>>> +        * Bit 8-31 of this register apparently don't care, and if this
>>>
>>>
>>
>> "don't care" is used as a compound adjective and the verb in the
>> compound adjective is ignored in that case. Please see
>> http://en.wikipedia.org/wiki/Don%27t-care_(logic) for details. It is
>> possible to improve readability slightly with the following variant:
>>
>> Bit 8-31 of this register are apparently don't-care bits, and...

I think just saying:

 * Bits 8-31 of this register are apparently don't care, ...

should be enough. Just use the plural as a range of bits is being specified.

Attached patch does just that, and fixes a missing comma on the following line.

>>
>> Not sure if this is really better, and we probably should ask a native
>> speaker who works with hardware logic.
>>

I'm not a native speaker, but English is my second language :P

>
> I would be tempted to put:
> are "don't care"
> with the quotes, if it is quoting the datasheet?
>
> --
>
> Andrew.
>

I don't think that's necessary.

Signed-off-by: David Borg <borg.db@gmail.com>
Acked-by: David Borg <borg.db@gmail.com> (trivial)
Uwe Hermann - 2010-08-08 17:04:39
On Sat, Aug 07, 2010 at 02:51:09PM +0200, David Borg wrote:
> I think just saying:
> 
>  * Bits 8-31 of this register are apparently don't care, ...
> 
> should be enough. Just use the plural as a range of bits is being specified.
 
> Signed-off-by: David Borg <borg.db@gmail.com>

Thanks, r1135.


Uwe.

Patch

Index: nicnatsemi.c
===================================================================
--- nicnatsemi.c	(revision 1130)
+++ nicnatsemi.c	(working copy)
@@ -68,8 +68,8 @@ 
 	/*
 	 * The datasheet requires 32 bit accesses to this register, but it seems
 	 * that requirement might only apply if the register is memory mapped.
-	 * Bit 8-31 of this register are apparently don't care, and if this
-	 * register is I/O port mapped 8 bit accesses to the lowest byte of the
+	 * Bits 8-31 of this register are apparently don't care, and if this
+	 * register is I/O port mapped, 8 bit accesses to the lowest byte of the
 	 * register seem to work fine. Due to that, we ignore the advice in the
 	 * data sheet.
 	 */
@@ -82,8 +82,8 @@ 
 	/*
 	 * The datasheet requires 32 bit accesses to this register, but it seems
 	 * that requirement might only apply if the register is memory mapped.
-	 * Bit 8-31 of this register are apparently don't care, and if this
-	 * register is I/O port mapped 8 bit accesses to the lowest byte of the
+	 * Bits 8-31 of this register are apparently don't care, and if this
+	 * register is I/O port mapped, 8 bit accesses to the lowest byte of the
 	 * register seem to work fine. Due to that, we ignore the advice in the
 	 * data sheet.
 	 */