Patchwork Add FEATURE_WRSR_WREN to feature_bits for many Eon SPI flash chips

login
register
about
Submitter David Hendricks
Date 2010-08-13 22:01:23
Message ID <AANLkTi=c91teq=Ck2iJuXC5npNdagOEz8NzM2mDpm7CW@mail.gmail.com>
Download mbox | patch
Permalink /patch/1741/
State Accepted
Commit r1148
Headers show

Comments

David Hendricks - 2010-08-13 22:01:23
This patch adds the FEATURE_WRSR_WREN bit to the feature_bits for many of
the supported Eon chips. I was unable to find datasheets for all the similar
Eon chips... there seems to be some huge number of variants listed on
http://www.eonssi.com/products/products.aspx . Perhaps we can safely assume
they are sanely uniform and apply FEATURE_WRSR_WREN to all of them?

Signed-off-by: David Hendricks <dhendrix@google.com>
Carl-Daniel Hailfinger - 2010-09-03 03:23:47
On 14.08.2010 00:01, David Hendricks wrote:
> This patch adds the FEATURE_WRSR_WREN bit to the feature_bits for many of
> the supported Eon chips. 

Thanks for your patch.


> I was unable to find datasheets for all the similar
> Eon chips... there seems to be some huge number of variants listed on
> http://www.eonssi.com/products/products.aspx . Perhaps we can safely assume
> they are sanely uniform and apply FEATURE_WRSR_WREN to all of them?
>   

Good point. Would you mind sending a followup patch to convert the other
Eon SPI chips as well?
I think one of us flashrom developers has a huge datasheet database for
Eon flash chips. I own at least datasheets for
EN25B05 EN25B10 EN25B16 EN25B20 EN25B32 EN25B40 EN25B80 EN25F20 EN25F40
EN25F80 EN25P05 EN25P10 EN25P16 EN25P20 EN25P32 EN25P40 EN25P80
as well as numerous non-SPI Eon flash chips.

> Signed-off-by: David Hendricks <dhendrix@google.com>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
and committed in r1148.

Regards,
Carl-Daniel

Patch

Index: flashrom-head/flashchips.c
===================================================================
--- flashrom-head.orig/flashchips.c
+++ flashrom-head/flashchips.c
@@ -2499,6 +2499,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25B64,
 		.total_size	= 8192,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -2598,6 +2599,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25F05,
 		.total_size	= 64,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -2633,6 +2635,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25F10,
 		.total_size	= 128,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -2668,6 +2671,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25F20,
 		.total_size	= 256,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -2703,6 +2707,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25F40,
 		.total_size	= 512,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_OK_PROBE,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -2735,6 +2740,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25F80,
 		.total_size	= 1024,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_OK_PR,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -2767,6 +2773,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25F16,
 		.total_size	= 2048,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
@@ -2799,6 +2806,7 @@  struct flashchip flashchips[] = {
 		.model_id	= EN_25F32,
 		.total_size	= 4096,
 		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,