Patchwork Eliminate some warnings treated as errors

login
register
about
Submitter xdrudis
Date 2010-08-16 22:50:48
Message ID <20100816225048.GB6706@ideafix.casa.ct>
Download mbox | patch
Permalink /patch/1755/
State Accepted
Headers show

Comments

xdrudis - 2010-08-16 22:50:48
After I copied mainboard/amd/tilapia-fam10 dir for mainboard/asus/m4a77td-pro,
adapted it a litlle
and changed mainboard/asus/Kconfig and makemenuconfig, I had 
to change a few small things because I got warnings treated as
erroes for unused symbols. 

patch.warnerror 

With only this patch applied to svn rev 5701 
I can compile but I can't see anything in the serial port.

(I can send the current diff between m4a77td-pro and tilapia-fam10, but maybe
I wait until it boots?) 

Signed off by: Xavi Drudis Ferran <xdrudis@tinet.cat>
Patrick Georgi - 2010-08-17 06:13:43
Am 17.08.2010 00:50, schrieb xdrudis:
> Signed off by: Xavi Drudis Ferran <xdrudis@tinet.cat>
Acked-by: Patrick Georgi <patrick@georgi-clan.de>

Committed in r5704. I also removed some whitespace the patch left over


Patrick

Patch

Index: src/northbridge/amd/amdht/h3finit.c
===================================================================
--- src/northbridge/amd/amdht/h3finit.c	(revision 5692)
+++ src/northbridge/amd/amdht/h3finit.c	(working copy)
@@ -845,8 +845,8 @@ 
  */
 static void coherentInit(sMainData *pDat)
 {
-	u8 i, j;
 
+
 #ifdef HT_BUILD_NC_ONLY
 	/* Replace discovery process with:
 	 * No other nodes, no coherent links
@@ -856,6 +856,8 @@ 
 	pDat->TotalLinks = 0;
 	pDat->nb->enableRoutingTables(0, pDat->nb);
 #else
+	u8 i, j;
+
 	pDat->NodesDiscovered = 0;
 	pDat->TotalLinks = 0;
 	for (i = 0; i < MAX_NODES; i++)
Index: src/northbridge/amd/amdht/h3ncmn.c
===================================================================
--- src/northbridge/amd/amdht/h3ncmn.c	(revision 5692)
+++ src/northbridge/amd/amdht/h3ncmn.c	(working copy)
@@ -1553,6 +1553,8 @@ 
  *
  * ---------------------------------------------------------------------------------------
  */
+#ifndef HT_BUILD_NC_ONLY
+
 static void fam0fWriteHTLinkCmdBufferAlloc(u8 node, u8 link, u8 req, u8 preq, u8 rsp, u8 prb)
 {
 	u32 temp;
@@ -1574,6 +1576,7 @@ 
 	temp = prb;
 	AmdPCIWriteBits(currentPtr, 15, 12, &temp);
 }
+#endif /* HT_BUILD_NC_ONLY */
 
 /**----------------------------------------------------------------------------------------
  *
@@ -1594,6 +1597,8 @@ 
  *
  * ---------------------------------------------------------------------------------------
  */
+#ifndef HT_BUILD_NC_ONLY
+
 static void fam0fWriteHTLinkDatBufferAlloc(u8 node, u8 link, u8 reqD, u8 preqD, u8 rspD)
 {
 	u32 temp;
@@ -1612,6 +1617,7 @@ 
 	temp = rspD;
 	AmdPCIWriteBits(currentPtr, 26, 24, &temp);
 }
+#endif /* HT_BUILD_NC_ONLY */
 
 /**----------------------------------------------------------------------------------------
  *