Patchwork ht init and some errata for AMD fam 10 RB_C3

login
register
about
Submitter xdrudis
Date 2010-08-19 21:52:22
Message ID <20100819215222.GB7181@ideafix.casa.ct>
Download mbox | patch
Permalink /patch/1772/
State Accepted
Commit r5736
Headers show

Comments

xdrudis - 2010-08-19 21:52:22
My smallest patch ever
I've checked Revision Guide for AMD Family10h processors (#41322) rev
3.74 June 2010 for errata 351 and it agrees with the comment on
setting ForceFullT0= 000b but I believe the code didn't honor the
comment.

apply this after patch.rbc3infam10all
xdrudis - 2010-08-19 22:09:00
Signed off by: Xavi Drudis Ferran <xdrudis@tinet.cat>

On Thu, Aug 19, 2010 at 11:52:22PM +0200, xdrudis wrote:
> My smallest patch ever

> I've checked Revision Guide for AMD Family10h processors (#41322) rev
> 3.74 June 2010 for errata 351 and it agrees with the comment on
> setting ForceFullT0= 000b but I believe the code didn't honor the
> comment.
> 
> apply this after patch.rbc3infam10all 
> 
> Index: src/cpu/amd/model_10xxx/defaults.h
> ===================================================================
> --- src/cpu/amd/model_10xxx/defaults.h	(revision 5719)
> +++ src/cpu/amd/model_10xxx/defaults.h	(working copy)
> @@ -157,7 +157,7 @@
>  
>  	/* Link Global Extended Control Register */
>  	{ 0, 0x16C,  AMD_DRBA23_RBC2, AMD_PTYPE_ALL,
> -	  0x00000014, 0x0000003F },	/* [15:13] ForceFullT0 = 0b,
> +	  0x00000014, 0x0000E03F },	/* [15:13] ForceFullT0 = 0b,
>  								 * Set T0Time 14h per BKDG */
>  
>  

> -- 
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
Stefan Reinauer - 2010-08-22 19:46:52
On 8/19/10 11:52 PM, xdrudis wrote:
> My smallest patch ever
will be applied after sign-off :-)
Stefan Reinauer - 2010-08-22 20:01:08
On 8/22/10 9:46 PM, Stefan Reinauer wrote:
>  On 8/19/10 11:52 PM, xdrudis wrote:
>> My smallest patch ever
> will be applied after sign-off :-)
>
Ah, missed the sign-off in the extra mail. It's in.

Stefan

Patch

Index: src/cpu/amd/model_10xxx/defaults.h
===================================================================
--- src/cpu/amd/model_10xxx/defaults.h	(revision 5719)
+++ src/cpu/amd/model_10xxx/defaults.h	(working copy)
@@ -157,7 +157,7 @@ 
 
 	/* Link Global Extended Control Register */
 	{ 0, 0x16C,  AMD_DRBA23_RBC2, AMD_PTYPE_ALL,
-	  0x00000014, 0x0000003F },	/* [15:13] ForceFullT0 = 0b,
+	  0x00000014, 0x0000E03F },	/* [15:13] ForceFullT0 = 0b,
 								 * Set T0Time 14h per BKDG */