Patchwork mainboard.c: init() still being called?

2010-08-25 16:10:39

Hi,

sorry for the delay, I'm continually jumping between projects and especially if
a customer wants something I have to immediately drop everything else.

I wrote:
>> [...] separate the configuration _data_ from the _code_ that writes it into
>> the chip.  [...]  I had guessed that this is the purpose why there
>> is a struct mainboard_config in the mainboard's chip.h, just as there is a
>> struct superio_..._config in all superio's chip.h.

Myles wrote:
> The device tree isn't for options. It's for immutable properties of the
> mainboard.

I'm not sure why things like 'register "com1_address" = "0x3E8"', which is in
devicetree.cb, and which is changable in most standard BIOSes' Setup, are
considered more immutable than an option switching RS232 to RS485 (via some
mainboard logic).

In this sense I experimented doing this:

chip mainboard/CONFIG_MAINBOARD_DIR
    # Bit0 turns off Live LED, bit1 switches Com1 to RS485, bit2 same for Com2
    register "sio_gp1x_config" = "0x01"
    chip northbridge/amd/lx
        device pci_domain 0 on
        ...

i.e. make the mainboard the root device of the device tree - seemed plausible to
me, somehow. This compiles and boots fine, but the 'register' statement still
doesn't have any effect, sio_gp1x_config in the mainboard's chip.h still isn't
set - hmm, tough luck ... Why have a struct mainboard_config if it can't be
used? Maybe it should be removed completely??

> I think you need Kconfig variables for both of those things.

Ok, then I'll take this approach instead - and tripped over something else:

The vendor's Kconfig looks like this:
choice
	prompt "Mainboard model"
	source board/1
	...
endchoice

This means you can't put any (visible) options in the board's Kconfig, because
they'd all end up _inside_ the choice instead of as seperate options. So you'd
have to put them all in the vendor Kconfig - but this would soon become very
ugly with all the "depends on"s once the list of boards and options grows. And
board specific options just belong in the board specific Kconfig, not in the
vendor's.

So I did this:
choice
	prompt "Mainboard model"
	config BOARD_1
		bool "Board 1"
endchoice
source board/1

This made the board Kconfig:
config BOARD_1
	bool "Board 1"
	select FOO

lose the BOARD_1 option. But I needed something to attach the selects to:
config BOARD_SPECIFIC_OPTIONS # dummy
	def_bool y
	select FOO

(Dependencies skipped for simplicity, see attached full patch.) This works fine,
but I don't like the dummy config option BOARD_SPECIFIC_OPTIONS, which is always
y and doesn't actually configure anything.

- Does anyone have a better idea, avoiding the dummy option?
- I'm going to use the same scheme for the RoadRunner-LX and also for the 2
additional boards I'm planning to base on this. Maybe this restructuring should
be applied to all boards/vendors?? I've seen there is one other board with a
private config option, which is so far kept in the vendor's Kconfig.

Any comments are most welcome.

Thanks and cheers,
Jens
sio_gp1x_config can no longer be set from devicetree.cb, so convert this into a
Kconfig option instead. And while I'm at it, also add option for SMC_CONFIG so
user doesn't have to mess around in C files.

Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
---

Submitter	Jens Rottmann
Date	2010-08-25 16:10:39
Message ID	<4C75407F.5080002@LiPPERTEmbedded.de>
Download	mbox \| patch
Permalink	/patch/1799/
State	New
Headers	show Return-path: <coreboot-bounces@coreboot.org> Envelope-to: patchwork@coreboot.org Received: from localhost ([127.0.0.1] helo=ra.coresystems.de) by ra.coresystems.de with esmtp (Exim 4.72) (envelope-from <coreboot-bounces@coreboot.org>) id 1OoIXx-0003E3-TJ; Wed, 25 Aug 2010 18:09:53 +0200 Received: from mail.lippert-at.com ([62.80.22.186] helo=domex.lippertembedded.de) by ra.coresystems.de with esmtp (Exim 4.72) (envelope-from <jrottmann@lippertembedded.com>) id 1OoIXn-0003D0-O2 for coreboot@coreboot.org; Wed, 25 Aug 2010 18:09:51 +0200 Received: from [192.168.1.149] ([192.168.1.149]) by domex.lippertembedded.de with Microsoft SMTPSVC(6.0.3790.4675); Wed, 25 Aug 2010 18:10:40 +0200 Message-ID: <4C75407F.5080002@LiPPERTEmbedded.de> Date: Wed, 25 Aug 2010 18:10:39 +0200 From: Jens Rottmann <JRottmann@LiPPERTEmbedded.de> User-Agent: Thunderbird 1.5.0.14 (Windows/20071210) MIME-Version: 1.0 To: Myles Watson <mylesgw@gmail.com> References: <4C6943CD.3060300@LiPPERTEmbedded.de> <4C6955B9.901@coresystems.de> <4C6985E3.2030403@LiPPERTEmbedded.de> <DE2012B97D65458BAD3B113372A4EFD1@chimp> In-Reply-To: <DE2012B97D65458BAD3B113372A4EFD1@chimp> Content-Type: multipart/mixed; boundary="------------020409080900080808020403" X-OriginalArrivalTime: 25 Aug 2010 16:10:40.0916 (UTC) FILETIME=[10358540:01CB4470] X-Spam-Score: -1.9 (-) Cc: 'Stefan Reinauer' <stefan.reinauer@coresystems.de>, coreboot@coreboot.org Subject: Re: [coreboot] mainboard.c: init() still being called? X-BeenThere: coreboot@coreboot.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: coreboot project mailing list <coreboot.coreboot.org> List-Unsubscribe: <http://www.coreboot.org/mailman/options/coreboot>, <mailto:coreboot-request@coreboot.org?subject=unsubscribe> List-Archive: <http://www.coreboot.org/pipermail/coreboot> List-Post: <mailto:coreboot@coreboot.org> List-Help: <mailto:coreboot-request@coreboot.org?subject=help> List-Subscribe: <http://www.coreboot.org/mailman/listinfo/coreboot>, <mailto:coreboot-request@coreboot.org?subject=subscribe> Sender: coreboot-bounces@coreboot.org Errors-To: coreboot-bounces@coreboot.org

Patchwork mainboard.c: init() still being called?

Comments

Patch