Patchwork mainboard.c: init() still being called?

login
register
about
Submitter Stefan Reinauer
Date 2010-08-27 15:04:11
Message ID <4C77D3EB.6050108@coresystems.de>
Download mbox | patch
Permalink /patch/1807/
State New
Headers show

Comments

Stefan Reinauer - 2010-08-27 15:04:11
On 8/27/10 4:24 PM, Jens Rottmann wrote:
>>> me, somehow. This compiles and boots fine, but the 'register' statement still
>>> doesn't have any effect, sio_gp1x_config in the mainboard's chip.h still isn't
>>> set - hmm, tough luck ... Why have a struct mainboard_config if it can't be
>>> used? Maybe it should be removed completely??
>> That mechanism could be fixed to work correctly again. Attached patch
>> should do that.
> Tried chip mainboard / register ... in several locations but couldn't get it
> to work, sometimes it wouldn't compile or else the mainboard's enable_dev +
> init weren't called at all.
>
Patricks patch, plus this addition should do the job:

macpro:coreboot stepan$ svn diff

If it does not, we should fix the mechanism, independently of your use
of Kconfig,...


Stefan
Jens Rottmann - 2010-08-27 15:44:57
> Patricks patch, plus this addition should do the job:

You're right, it does. My mistake was trying to be extra clever and writing

chip mainboard/CONFIG_MAINBOARD_DIR

instead of

chip mainboard/lippert/spacerunner-lx

because CONFIG_MAINBOARD_DIR == lippert/spacerunner-lx. This compiled and even
booted, but appearently still broke something ... sorry!

Tested-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
:-)

Cheers,
Jens

Patch

Index: src/mainboard/lippert/spacerunner-lx/devicetree.cb
===================================================================
--- src/mainboard/lippert/spacerunner-lx/devicetree.cb (revision 5745)
+++ src/mainboard/lippert/spacerunner-lx/devicetree.cb (working copy)
@@ -1,3 +1,7 @@ 
+chip mainboard/lippert/spacerunner-lx
+
+register "sio_gp1x_config" = "1"
+
chip northbridge/amd/lx
device pci_domain 0 on
device pci 1.0 on end # Northbridge
@@ -88,3 +92,5 @@ 
end
end
end
+
+end