Patchwork kconfig support for ASUS P2B-F

login
register
about
Submitter ron minnich
Date 2009-08-25 14:07:52
Message ID <13426df10908250707x2ea2b13enafa9a82554bef6b8@mail.gmail.com>
Download mbox | patch
Permalink /patch/185/
State Not Applicable
Headers show

Comments

ron minnich - 2009-08-25 14:07:52
Now I know why I never write docs .... nobody ever reads them :-)



Again, conditional conclusion is at the DIRECTORY level for parts, not
at the FILE level in the actual part directory.

Why do this? It makes is MUCH simpler if you have a part that also
depends on some other variable, such as ACPI configuration variable.

Please change this if you get a chance. Thanks for doing this. It is
really wonderful to see people taking up the Kconfig stuff.

Next I'll introduce my romcc-free qemu stuff ...

ron

Patch

Index: src/northbridge/intel/i440bx/Makefile.inc
===================================================================
--- src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
+++ src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
@@ -0,0 +1,22 @@ 
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2009 Uwe Hermann <uwe@hermann-uwe.de>
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+##
+
+driver-$(CONFIG_NORTHBRIDGE_INTEL_I440BX) += northbridge.o
+
Index: src/northbridge/intel/Makefile.inc
===================================================================
--- src/northbridge/intel/Makefile.inc	(Revision 4566)
+++ src/northbridge/intel/Makefile.inc	(Arbeitskopie)
@@ -2,7 +2,7 @@ 
 #subdirs-y += e7520
 #subdirs-y += e7525
 #subdirs-y += i3100
-#subdirs-y += i440bx
+subdirs-y += i440bx
 subdirs-y += i82810
 #subdirs-y += i82830
 #subdirs-y += i855gme

This is not quite right. Please change as follows:

Index: src/northbridge/intel/i440bx/Makefile.inc
===================================================================
--- src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
+++ src/northbridge/intel/i440bx/Makefile.inc	(Revision 0)
@@ -0,0 +1,22 @@ 
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2009 Uwe Hermann <uwe@hermann-uwe.de>
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+##
+
+driver-y += northbridge.o
+
Index: src/northbridge/intel/Makefile.inc
===================================================================
--- src/northbridge/intel/Makefile.inc	(Revision 4566)
+++ src/northbridge/intel/Makefile.inc	(Arbeitskopie)
@@ -2,7 +2,7 @@ 
 #subdirs-y += e7520
 #subdirs-y += e7525
 #subdirs-y += i3100
-#subdirs-y += i440bx
+subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I440BX) += i440bx
 subdirs-$(CONFIG_NORTHBRIDGE_INTEL_I82810) += i82810
 #subdirs-y += i82830
 #subdirs-y += i855gme