| Submitter | Uwe Hermann |
|---|---|
| Date | 2010-09-01 22:25:30 |
| Message ID | <20100901222530.GA17529@greenwood> |
| Download | mbox | patch |
| Permalink | /patch/1851/ |
| State | Accepted |
| Commit | r1190 |
| Headers | show |
Comments
On 02.09.2010 00:25, Uwe Hermann wrote: > Quickfix for broken writes on FT2232H based programmers. > > Not sure if this is the final/correct fix, but for now it definately > fixes writes on FT2232H hardware. I have tested this on both, the > DLP Design DLP-USB1232H, and the openbiosprog-spi hardware. > > Thanks to Joshua Roys <roysjosh@gmail.com> for the hint on IRC. > > Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> It would be appreciated if you could extend the changelog with more details about the error mode, and the flash chip write method used (page write vs. byte write). That said, this patch apparently fixes something, and I don't know libftdi well enough to tell you if this is correct or not, so I'll rely on the testing you did. Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Regards, Carl-Daniel
On Mon, Oct 04, 2010 at 01:18:04PM +0200, Carl-Daniel Hailfinger wrote: > On 02.09.2010 00:25, Uwe Hermann wrote: > > Quickfix for broken writes on FT2232H based programmers. > > > > Not sure if this is the final/correct fix, but for now it definately > > fixes writes on FT2232H hardware. I have tested this on both, the > > DLP Design DLP-USB1232H, and the openbiosprog-spi hardware. > > > > Thanks to Joshua Roys <roysjosh@gmail.com> for the hint on IRC. > > > > Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> > > It would be appreciated if you could extend the changelog with more > details about the error mode, and the flash chip write method used (page > write vs. byte write). > > That said, this patch apparently fixes something, and I don't know > libftdi well enough to tell you if this is correct or not, so I'll rely > on the testing you did. > > Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Thanks, r1190. I have no further details at the moment, but I will definately look into this some more later. I'll try to test as many chips as I can find, maybe there's a pattern. Uwe.
Patch
Quickfix for broken writes on FT2232H based programmers. Not sure if this is the final/correct fix, but for now it definately fixes writes on FT2232H hardware. I have tested this on both, the DLP Design DLP-USB1232H, and the openbiosprog-spi hardware. Thanks to Joshua Roys <roysjosh@gmail.com> for the hint on IRC. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Index: ft2232_spi.c =================================================================== --- ft2232_spi.c (Revision 1146) +++ ft2232_spi.c (Arbeitskopie) @@ -195,7 +195,7 @@ msg_perr("Unable to set latency timer\n"); } - if (ftdi_write_data_set_chunksize(ftdic, 512)) { + if (ftdi_write_data_set_chunksize(ftdic, 256)) { msg_perr("Unable to set chunk size\n"); }