Patchwork Board enable for Dell OptiPlex GX1 (try 2)

login
register
about
Submitter David Borg
Date 2010-09-03 22:21:08
Message ID <AANLkTime7mJuTEwo-8Gpj1rJfgiQSKPi5_efkeJEiWXe@mail.gmail.com>
Download mbox | patch
Permalink /patch/1859/
State Accepted
Headers show

Comments

David Borg - 2010-09-03 22:21:08
Hi Mattias,

It seems that patchwork didn't find your patch. I've updated it
against r1151 and attached it here, in the hopes that it's now found
:)

In case it's needed, in addition to your original sign off, this is
Signed-off-by: David Borg <borg.db@gmail.com>

Thanks!

Regards,

David

On 16 August 2010 04:53, Mattias Mattsson <vitplister@gmail.com> wrote:
> Add board enable for Dell OptiPlex GX1.
>
> This is a new version of an earlier patch.
>
> - Change matching PCI ID:s to ethernet and north bridge.
>
> - Truncate board name to "OptiPlex GX1" as this patch probably apply
> to the whole series (they share the same vendor BIOS download).
>
> - Add URL to print.c
>
> - Marked board as OK. This was tested with an earlier version of
> flashrom (r1092), but nothing has changed that affects this patch
> (GPO30 is still always available on PIIX4).
>
> lspci output:
> http://www.flashrom.org/pipermail/flashrom/2010-July/004042.html
>
> Signed-off-by: Mattias Mattsson <vitplister@gmail.com>
>
>
> Thanks!
> -mattias
>
> _______________________________________________
> flashrom mailing list
> flashrom@flashrom.org
> http://www.flashrom.org/mailman/listinfo/flashrom
>
Carl-Daniel Hailfinger - 2010-10-05 13:24:28
On 04.09.2010 00:21, David Borg wrote:
> Hi Mattias,
>
> It seems that patchwork didn't find your patch. I've updated it
> against r1151 and attached it here, in the hopes that it's now found
> :)
>   

Thanks for updating the patch.


> In case it's needed, in addition to your original sign off, this is
> Signed-off-by: David Borg <borg.db@gmail.com>
>   

Usually not needed unless you modify the code.


> On 16 August 2010 04:53, Mattias Mattsson <vitplister@gmail.com> wrote:
>   
>> Add board enable for Dell OptiPlex GX1.
>>
>> This is a new version of an earlier patch.
>>
>> - Change matching PCI ID:s to ethernet and north bridge.
>>
>> - Truncate board name to "OptiPlex GX1" as this patch probably apply
>> to the whole series (they share the same vendor BIOS download).
>>
>> - Add URL to print.c
>>
>> - Marked board as OK. This was tested with an earlier version of
>> flashrom (r1092), but nothing has changed that affects this patch
>> (GPO30 is still always available on PIIX4).
>>
>> lspci output:
>> http://www.flashrom.org/pipermail/flashrom/2010-July/004042.html
>>
>> Signed-off-by: Mattias Mattsson <vitplister@gmail.com>
>>     

Mattias, can you please credit the original reporter? And if he tested
it, add

Tested-by: Joachim Ernst <joachim.ernst@web.de>

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

Regards,
Carl-Daniel
Carl-Daniel Hailfinger - 2010-10-05 20:21:37
On 05.10.2010 15:24, Carl-Daniel Hailfinger wrote:
> On 04.09.2010 00:21, David Borg wrote:
>   
>> Hi Mattias,
>>
>> It seems that patchwork didn't find your patch. I've updated it
>> against r1151 and attached it here, in the hopes that it's now found
>> :)
>>   
>>     
>
> Thanks for updating the patch.
>
>
>   
>> In case it's needed, in addition to your original sign off, this is
>> Signed-off-by: David Borg <borg.db@gmail.com>
>>   
>>     
>
> Usually not needed unless you modify the code.
>
>
>   
>> On 16 August 2010 04:53, Mattias Mattsson <vitplister@gmail.com> wrote:
>>   
>>     
>>> Add board enable for Dell OptiPlex GX1.
>>>
>>> This is a new version of an earlier patch.
>>>
>>> - Change matching PCI ID:s to ethernet and north bridge.
>>>
>>> - Truncate board name to "OptiPlex GX1" as this patch probably apply
>>> to the whole series (they share the same vendor BIOS download).
>>>
>>> - Add URL to print.c
>>>
>>> - Marked board as OK. This was tested with an earlier version of
>>> flashrom (r1092), but nothing has changed that affects this patch
>>> (GPO30 is still always available on PIIX4).
>>>
>>> lspci output:
>>> http://www.flashrom.org/pipermail/flashrom/2010-July/004042.html
>>>
>>> Signed-off-by: Mattias Mattsson <vitplister@gmail.com>
>>>     
>>>       
>
> Mattias, can you please credit the original reporter? And if he tested
> it, add
>
> Tested-by: Joachim Ernst <joachim.ernst@web.de>
>   

Sorry, my fault. I thought a report from last year had triggered this
board enable. I was talking about
http://www.flashrom.org/pipermail/flashrom/2009-July/000207.html
So please ignore the Tested-by suggestion.

> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>   

My ack still stands, though.

Regards,
Carl-Daniel
Mattias Mattsson - 2010-10-05 21:35:33
On Tue, Oct 5, 2010 at 22:21, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006@gmx.net> wrote:
> On 05.10.2010 15:24, Carl-Daniel Hailfinger wrote:
>> On 04.09.2010 00:21, David Borg wrote:
>>
>>> Hi Mattias,
>>>
>>> It seems that patchwork didn't find your patch. I've updated it
>>> against r1151 and attached it here, in the hopes that it's now found
>>> :)
>>>
>>>
>>
>> Thanks for updating the patch.
>>
>>
>>
>>> In case it's needed, in addition to your original sign off, this is
>>> Signed-off-by: David Borg <borg.db@gmail.com>
>>>
>>>
>>
>> Usually not needed unless you modify the code.
>>
>>
>>
>>> On 16 August 2010 04:53, Mattias Mattsson <vitplister@gmail.com> wrote:
>>>
>>>
>>>> Add board enable for Dell OptiPlex GX1.
>>>>
>>>> This is a new version of an earlier patch.
>>>>
>>>> - Change matching PCI ID:s to ethernet and north bridge.
>>>>
>>>> - Truncate board name to "OptiPlex GX1" as this patch probably apply
>>>> to the whole series (they share the same vendor BIOS download).
>>>>
>>>> - Add URL to print.c
>>>>
>>>> - Marked board as OK. This was tested with an earlier version of
>>>> flashrom (r1092), but nothing has changed that affects this patch
>>>> (GPO30 is still always available on PIIX4).
>>>>
>>>> lspci output:
>>>> http://www.flashrom.org/pipermail/flashrom/2010-July/004042.html
>>>>
>>>> Signed-off-by: Mattias Mattsson <vitplister@gmail.com>
>>>>
>>>>
>>
>> Mattias, can you please credit the original reporter? And if he tested
>> it, add
>>
>> Tested-by: Joachim Ernst <joachim.ernst@web.de>
>>
>
> Sorry, my fault. I thought a report from last year had triggered this
> board enable. I was talking about
> http://www.flashrom.org/pipermail/flashrom/2009-July/000207.html
> So please ignore the Tested-by suggestion.
>
>> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>>
>
> My ack still stands, though.

Thanks, committed as r1191


-mattias

Patch

Index: print.c
===================================================================
--- print.c	(revision 1151)
+++ print.c	(working copy)
@@ -380,6 +380,7 @@ 
 	B("Biostar",	"P4M80-M4",		1, "http://www.biostar-usa.com/mbdetails.asp?model=p4m80-m4", NULL),
 	B("Biostar",	"TA780G M2+",		1, "http://www.biostar.com.tw/app/en/t-series/content.php?S_ID=344", NULL),
 	B("Boser",	"HS-6637",		0, "http://www.boser.com.tw/manual/HS-62376637v3.4.pdf", NULL),
+	B("Dell",	"OptiPlex GX1",		1, "http://support.dell.com/support/edocs/systems/ban_gx1/en/index.htm", NULL),
 	B("Dell",	"PowerEdge 1850",	1, "http://support.dell.com/support/edocs/systems/pe1850/en/index.htm", NULL),
 	B("DFI",	"855GME-MGF",		0, "http://www.dfi.com.tw/portal/CM/cmproduct/XX_cmproddetail/XX_WbProdsWindow?action=e&downloadType=&windowstate=normal&mode=view&downloadFlag=false&itemId=433", NULL),
 	B("DFI",	"Blood-Iron P35 T2RL",	1, "http://lp.lanparty.com.tw/portal/CM/cmproduct/XX_cmproddetail/XX_WbProdsWindow?itemId=516&downloadFlag=false&action=1", NULL),
Index: board_enable.c
===================================================================
--- board_enable.c	(revision 1151)
+++ board_enable.c	(working copy)
@@ -1101,6 +1101,15 @@ 
 }
 
 /*
+ * Suited for:
+ *  - Dell OptiPlex GX1
+ */
+static int intel_piix4_gpo30_lower(void)
+{
+	return intel_piix4_gpo_set(30, 0);
+}
+
+/*
  * Set a GPIO line on a given Intel ICH LPC controller.
  */
 static int intel_ich_gpio_set(int gpio, int raise)
@@ -1799,6 +1808,7 @@ 
 	{0x10B9, 0x1541,      0,      0,  0x10B9, 0x1533,      0,      0, "^P5A$",       "asus",       "p5a",         "ASUS",        "P5A",                   0,   OK, board_asus_p5a},
 	{0x10DE, 0x0030, 0x1043, 0x818a,  0x8086, 0x100E, 0x1043, 0x80EE, NULL,          NULL,         NULL,          "ASUS",        "P5ND2-SLI Deluxe",      0,   OK, nvidia_mcp_gpio10_raise},
 	{0x8086, 0x24dd, 0x1043, 0x80a6,  0x8086, 0x2570, 0x1043, 0x8157, NULL,          NULL,         NULL,          "ASUS",        "P5PE-VM",               0,   OK, intel_ich_gpio21_raise},
+	{0x10b7, 0x9055, 0x1028, 0x0082,  0x8086, 0x7190,      0,      0, NULL,          NULL,         NULL,          "Dell",        "OptiPlex GX1",          0,   OK, intel_piix4_gpo30_lower},
 	{0x8086, 0x3590, 0x1028, 0x016c,  0x1000, 0x0030, 0x1028, 0x016c, NULL,          NULL,         NULL,          "Dell",        "PowerEdge 1850",        0,   OK, intel_ich_gpio23_raise},
 	{0x1106, 0x3038, 0x1019, 0x0996,  0x1106, 0x3177, 0x1019, 0x0996, NULL,          NULL,         NULL,          "Elitegroup",  "K7VTA3",                256, OK, NULL},
 	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3059, 0x1695, 0x3005, NULL,          NULL,         NULL,          "EPoX",        "EP-8K5A2",              0,   OK, w836xx_memw_enable_2e},