| Submitter | Myles Watson |
|---|---|
| Date | 2009-08-25 15:56:41 |
| Message ID | <2831fecf0908250856o186e3b94jc74c4e88598de4d0@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/187/ |
| State | Accepted |
| Headers | show |
Comments
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Myles, not sure which is right, but per IRC discussion, let's take
this one slowly for now.
It's easy to fix later.
thanks again
ron
On Tue, Aug 25, 2009 at 10:01 AM, ron minnich<rminnich@gmail.com> wrote: > Acked-by: Ronald G. Minnich <rminnich@gmail.com> Rev 4578. > Myles, not sure which is right, but per IRC discussion, let's take > this one slowly for now. Sure. > It's easy to fix later. Agreed. Thanks, Myles
On Tue, Aug 25, 2009 at 10:05 AM, Myles Watson<mylesgw@gmail.com> wrote: > On Tue, Aug 25, 2009 at 10:01 AM, ron minnich<rminnich@gmail.com> wrote: >> Acked-by: Ronald G. Minnich <rminnich@gmail.com> > Rev 4578. I just realized that there was no microcode included for socket F, and socket 940 needs it. I need to add it back in. Should I add it for socket F at the same time? Thanks, Myles
On Tue, Aug 25, 2009 at 9:07 AM, Myles Watson<mylesgw@gmail.com> wrote: > On Tue, Aug 25, 2009 at 10:05 AM, Myles Watson<mylesgw@gmail.com> wrote: >> On Tue, Aug 25, 2009 at 10:01 AM, ron minnich<rminnich@gmail.com> wrote: >>> Acked-by: Ronald G. Minnich <rminnich@gmail.com> >> Rev 4578. > > I just realized that there was no microcode included for socket F, and > socket 940 needs it. I need to add it back in. Should I add it for > socket F at the same time? yes please. ron
>> I just realized that there was no microcode included for socket F, and >> socket 940 needs it. I need to add it back in. Should I add it for >> socket F at the same time? > > yes please. Rev 4579. Now the only difference is that I didn't include smm for socket_940. I don't think there are any socket_940 boards with smm support. Thanks, Myles
Patch
Index: src/cpu/amd/socket_940/Makefile.inc =================================================================== --- src/cpu/amd/socket_940/Makefile.inc (revision 4577) +++ src/cpu/amd/socket_940/Makefile.inc (working copy) @@ -1,2 +1,13 @@ obj-y += socket_940.o subdirs-y += ../model_fxx +subdirs-y += ../dualcore +subdirs-y += ../mtrr +subdirs-y += ../../x86/tsc +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/fpu +subdirs-y += ../../x86/mmx +subdirs-y += ../../x86/sse +subdirs-y += ../../x86/lapic +subdirs-y += ../../x86/cache +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/pae Index: src/cpu/amd/model_fxx/Makefile.inc =================================================================== --- src/cpu/amd/model_fxx/Makefile.inc (revision 4577) +++ src/cpu/amd/model_fxx/Makefile.inc (working copy) @@ -4,16 +4,3 @@ obj-y += model_fxx_update_microcode.o obj-y += processor_name.o obj-y += powernow_acpi.o -subdirs-y += ../dualcore -subdirs-y += ../mtrr -subdirs-y += ../microcode -subdirs-y += ../../x86/tsc -subdirs-y += ../../x86/mtrr -subdirs-y += ../../x86/fpu -subdirs-y += ../../x86/mmx -subdirs-y += ../../x86/sse -subdirs-y += ../../x86/lapic -subdirs-y += ../../x86/cache -subdirs-y += ../../x86/mtrr -subdirs-y += ../../x86/pae -subdirs-y += ../../x86/smm Index: src/cpu/amd/socket_AM2/Makefile.inc =================================================================== --- src/cpu/amd/socket_AM2/Makefile.inc (revision 4577) +++ src/cpu/amd/socket_AM2/Makefile.inc (working copy) @@ -1,2 +1,15 @@ obj-y += socket_AM2.o subdirs-y += ../model_fxx +subdirs-y += ../dualcore +subdirs-y += ../mtrr +subdirs-y += ../microcode +subdirs-y += ../../x86/tsc +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/fpu +subdirs-y += ../../x86/mmx +subdirs-y += ../../x86/sse +subdirs-y += ../../x86/lapic +subdirs-y += ../../x86/cache +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/pae +subdirs-y += ../../x86/smm Index: src/cpu/amd/socket_F/Makefile.inc =================================================================== --- src/cpu/amd/socket_F/Makefile.inc (revision 4577) +++ src/cpu/amd/socket_F/Makefile.inc (working copy) @@ -1,2 +1,14 @@ obj-y += socket_F.o subdirs-y += ../model_fxx +subdirs-y += ../dualcore +subdirs-y += ../mtrr +subdirs-y += ../../x86/tsc +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/fpu +subdirs-y += ../../x86/mmx +subdirs-y += ../../x86/sse +subdirs-y += ../../x86/lapic +subdirs-y += ../../x86/cache +subdirs-y += ../../x86/mtrr +subdirs-y += ../../x86/pae +subdirs-y += ../../x86/smm
I agree that it's dangerous because it's not abstracted correctly yet. I'm not sure what the right fix is, but I don't think there should be this much duplication in every socket Makefile.inc. Maybe the best thing would be for someone to take a socket that supports two families and implement it for Kconfig so that we can see what shakes out. Signed-off-by: Myles Watson <mylesgw@gmail.com> Thanks, Myles