Patchwork [flashrom] Re: flashrom patch: add support for Abit AB-BM6 board

login
register
about
Submitter Tim ter Laak
Date 2010-09-06 17:47:16
Message ID <Pine.LNX.4.64.1009061928420.21555@virtuscin>
Download mbox | patch
Permalink /patch/1872/
State Not Applicable
Headers show

Comments

Tim ter Laak - 2010-09-06 17:47:16
This patch adds support for the Abit BM6 board, using DMI string 
identification.

Signed-off-by: Tim ter Laak <timl@scintilla.utwente.nl>
---

On Sun, 5 Sep 2010, Tim ter Laak wrote:

> On Sat, 4 Sep 2010, Carl-Daniel Hailfinger wrote:
>
>> flashrom supports DMI matching since a few months, so it may be possible
>> to identify your board that way. And with superiotool output, we could
>> perhaps improve matching a bit more.
>
>> If DMI is useful on your board, we could try to match the DMI strings
>> and avoid the -m abit:ab-bm6 parameter for flashrom.
>
> The combination of the 'baseboard-manufacturer' and 'baseboard-product-name' 
> DMI strings looks promising.
> (The empty contents of other strings is completely in line with expectations; 
> after all the BIOS didn't bother to assign subsystem IDs to the PCI devices 
> of the chipset either.)
>
> I'll be poking around in the source in the next few days to port my patch to 
> the current version of flashrom. It would take a while to get up to speed 
> again though, so I'm also open to testing other people's patches.

Well, that was a lot easier than expected. As per commit log message at 
the top of this mail, the patch is attached. Patch is tested and seems to 
work fine.

Tim.
Michael Karcher - 2010-09-06 17:58:07
Am Montag, den 06.09.2010, 19:47 +0200 schrieb Tim ter Laak:
> Signed-off-by: Tim ter Laak <timl@scintilla.utwente.nl>
> Well, that was a lot easier than expected. As per commit log message at 
> the top of this mail, the patch is attached. Patch is tested and seems to 
> work fine.

Please also add the board to print.c, leave the URL NULL if you can't
find any. Otherwise it will be missing from flashrom -L and the Wiki.

Regards,
  Michael Karcher

Patch

Index: board_enable.c

===================================================================
--- board_enable.c	(revision 1153)

+++ board_enable.c	(working copy)

@@ -1093,6 +1093,15 @@ 

 
 /*
  * Suited for:
+ *  - Abit AB-BM6

+ */

+static int intel_piix4_gpo26_lower(void)

+{

+        return intel_piix4_gpo_set(26, 0);

+}

+           

+/*

+ * Suited for:

  *  - Intel SE440BX-2
  */
 static int intel_piix4_gpo27_lower(void)
@@ -1763,6 +1772,7 @@ 

 	/* first pci-id set [4],          second pci-id set [4],          dmi identifier coreboot id [2],             vendor name    board name       max_rom_...  OK? flash enable */
 #if defined(__i386__) || defined(__x86_64__)
 	{0x10DE, 0x0547, 0x147B, 0x1C2F,  0x10DE, 0x0548, 0x147B, 0x1C2F, NULL,          NULL,         NULL,          "abit",        "AN-M2",                 0,   NT, nvidia_mcp_gpio2_raise},
+	{0x8086, 0x7190,      0,      0,  0x8086, 0x7110,      0,      0, "^i440BX-W977 (BM6)$", NULL, NULL,          "abit",        "BM6",                   0,   OK, intel_piix4_gpo26_lower},

 	{0x8086, 0x24d3, 0x147b, 0x1014,  0x8086, 0x2578, 0x147b, 0x1014, NULL,          NULL,         NULL,          "abit",        "IC7",                   0,   NT, intel_ich_gpio23_raise},
 	{0x8086, 0x2930, 0x147b, 0x1084,  0x11ab, 0x4364, 0x147b, 0x1084, NULL,          NULL,         NULL,          "abit",        "IP35",                  0,   OK, intel_ich_gpio16_raise},
 	{0x8086, 0x2930, 0x147b, 0x1083,  0x10ec, 0x8167, 0x147b, 0x1083, NULL,          NULL,         NULL,          "abit",        "IP35 Pro",              0,   OK, intel_ich_gpio16_raise},