Patchwork [flashrom] flashrom patch: add support for Abit AB-BM6 board

login
register
about
Submitter Tim ter Laak
Date 2010-09-07 07:06:07
Message ID <Pine.LNX.4.64.1009070901530.7521@virtuscin>
Download mbox | patch
Permalink /patch/1878/
State Not Applicable
Headers show

Comments

Tim ter Laak - 2010-09-07 07:06:07
This patch adds support for the Abit BM6 board, using DMI string
identification, and lists it in print.c .

Signed-off-by: Tim ter Laak <timl@scintilla.utwente.nl>
---

On Mon, 6 Sep 2010, Michael Karcher wrote:

> Please also add the board to print.c, leave the URL NULL if you can't
> find any. Otherwise it will be missing from flashrom -L and the Wiki.

I've attached an updated patch that adds this.

Tim.
Michael Karcher - 2010-09-07 07:18:52
Am Dienstag, den 07.09.2010, 09:06 +0200 schrieb Tim ter Laak:
> This patch adds support for the Abit BM6 board, using DMI string
> identification, and lists it in print.c .
> 
> Signed-off-by: Tim ter Laak <timl@scintilla.utwente.nl>
Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>

If no one else beats me to it, I will commit tonight.

Regards,
  Michael Karcher
Uwe Hermann - 2010-09-07 17:11:45
On Tue, Sep 07, 2010 at 09:18:52AM +0200, Michael Karcher wrote:
> Am Dienstag, den 07.09.2010, 09:06 +0200 schrieb Tim ter Laak:
> > This patch adds support for the Abit BM6 board, using DMI string
> > identification, and lists it in print.c .
> > 
> > Signed-off-by: Tim ter Laak <timl@scintilla.utwente.nl>
> Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
> 
> If no one else beats me to it, I will commit tonight.

Looks good to me too, but two small requests:


> Index: board_enable.c
> ===================================================================
> --- board_enable.c      (revision 1153)
> +++ board_enable.c      (working copy)
> @@ -1093,6 +1093,15 @@
> 
>  /*
>   * Suited for:
> + *  - Abit AB-BM6

s/Abit/abit/ for consistency (though we may change the convention later).

And: "AB-BM6" should be just "BM6" as that's the name on the website.
Where does the "AB-" prefix come from? Does it say so on the PCB or
something?

Either way:

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>


Uwe.

Patch

Index: print.c

===================================================================
--- print.c	(revision 1153)

+++ print.c	(working copy)

@@ -283,6 +283,7 @@ 

 	B("A-Trend",	"ATC-6220",		1, "http://www.motherboard.cz/mb/atrend/atc6220.htm", NULL),
 	B("abit",	"AN-M2",		1, "http://www.abit.com.tw/page/de/motherboard/motherboard_detail.php?DEFTITLE=Y&fMTYPE=Socket%20AM2&pMODEL_NAME=AN-M2", NULL),
 	B("abit",	"AX8",			1, "http://www.abit.com.tw/page/en/motherboard/motherboard_detail.php?DEFTITLE=Y&fMTYPE=Socket%20939&pMODEL_NAME=AX8", NULL),
+	B("abit",	"BM6",			1, "http://www.abit.com.tw/page/en/motherboard/motherboard_detail.php?pMODEL_NAME=BM6&fMTYPE=Socket%20370", NULL),

 	B("abit",	"Fatal1ty F-I90HD",	1, "http://www.abit.com.tw/page/de/motherboard/motherboard_detail.php?pMODEL_NAME=Fatal1ty+F-I90HD&fMTYPE=LGA775", NULL),
 	B("abit",	"IC7",			1, "http://www.abit.com.tw/page/en/motherboard/motherboard_detail.php?pMODEL_NAME=IC7&fMTYPE=Socket%20478", NULL),
 	B("abit",	"IP35",			1, "http://www.abit.com.tw/page/en/motherboard/motherboard_detail.php?fMTYPE=LGA775&pMODEL_NAME=IP35", NULL),
Index: board_enable.c

===================================================================
--- board_enable.c	(revision 1153)

+++ board_enable.c	(working copy)

@@ -1093,6 +1093,15 @@ 

 
 /*
  * Suited for:
+ *  - Abit AB-BM6

+ */

+static int intel_piix4_gpo26_lower(void)

+{

+        return intel_piix4_gpo_set(26, 0);

+}

+           

+/*

+ * Suited for:

  *  - Intel SE440BX-2
  */
 static int intel_piix4_gpo27_lower(void)
@@ -1763,6 +1772,7 @@ 

 	/* first pci-id set [4],          second pci-id set [4],          dmi identifier coreboot id [2],             vendor name    board name       max_rom_...  OK? flash enable */
 #if defined(__i386__) || defined(__x86_64__)
 	{0x10DE, 0x0547, 0x147B, 0x1C2F,  0x10DE, 0x0548, 0x147B, 0x1C2F, NULL,          NULL,         NULL,          "abit",        "AN-M2",                 0,   NT, nvidia_mcp_gpio2_raise},
+	{0x8086, 0x7190,      0,      0,  0x8086, 0x7110,      0,      0, "^i440BX-W977 (BM6)$", NULL, NULL,          "abit",        "BM6",                   0,   OK, intel_piix4_gpo26_lower},

 	{0x8086, 0x24d3, 0x147b, 0x1014,  0x8086, 0x2578, 0x147b, 0x1014, NULL,          NULL,         NULL,          "abit",        "IC7",                   0,   NT, intel_ich_gpio23_raise},
 	{0x8086, 0x2930, 0x147b, 0x1084,  0x11ab, 0x4364, 0x147b, 0x1084, NULL,          NULL,         NULL,          "abit",        "IP35",                  0,   OK, intel_ich_gpio16_raise},
 	{0x8086, 0x2930, 0x147b, 0x1083,  0x10ec, 0x8167, 0x147b, 0x1083, NULL,          NULL,         NULL,          "abit",        "IP35 Pro",              0,   OK, intel_ich_gpio16_raise},