Patchwork unify types in kconfig

login
register
about
Submitter Patrick Georgi
Date 2009-08-25 16:55:13
Message ID <1251219313.28873.12.camel@tetris>
Download mbox | patch
Permalink /patch/188/
State Accepted
Headers show

Comments

Patrick Georgi - 2009-08-25 16:55:13
Hi,

attached patch makes PCI_ROM_RUN a boolean (like it is elsewhere), which
is the correct choice, too. Avoids type problems in kconfig

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Myles Watson - 2009-08-25 16:58:44
> attached patch makes PCI_ROM_RUN a boolean (like it is elsewhere), which
> is the correct choice, too. Avoids type problems in kconfig
I agree with the type change.  I think setting it in a mainboard Kconfig is
a mistake.  I tried to build Serengeti_cheetah without VGA to test something
and it was a pain.

> Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles
Uwe Hermann - 2009-08-25 17:14:48
On Tue, Aug 25, 2009 at 10:58:44AM -0600, Myles Watson wrote:
> > attached patch makes PCI_ROM_RUN a boolean (like it is elsewhere), which
> > is the correct choice, too. Avoids type problems in kconfig
> I agree with the type change.

Ditto, I was going to post the same patch also :)

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>


> I think setting it in a mainboard Kconfig is
> a mistake.  I tried to build Serengeti_cheetah without VGA to test something
> and it was a pain.

Hm, you could be right. This was per-mainboard in Config.lb, but in
kconfig it should be a global/common option, and not set in each board.


Uwe.
ron minnich - 2009-08-25 17:37:58
On Tue, Aug 25, 2009 at 10:14 AM, Uwe Hermann<uwe@hermann-uwe.de> wrote:

> Hm, you could be right. This was per-mainboard in Config.lb, but in
> kconfig it should be a global/common option, and not set in each board.

yes, we really need to start using the power of Kconfig now. Let's
make it so people can choose this in menuconfig.

ron

Patch

Index: src/Kconfig
===================================================================
--- src/Kconfig	(Revision 4577)
+++ src/Kconfig	(Arbeitskopie)
@@ -85,8 +85,8 @@ 
 	default 1
 
 config PCI_ROM_RUN
-	int
-	default 0
+	bool
+	default n
 
 config HT_CHAIN_UNITID_BASE
 	int
Index: src/mainboard/amd/serengeti_cheetah/Kconfig
===================================================================
--- src/mainboard/amd/serengeti_cheetah/Kconfig	(Revision 4577)
+++ src/mainboard/amd/serengeti_cheetah/Kconfig	(Arbeitskopie)
@@ -189,7 +189,7 @@ 
 	depends on BOARD_AMD_SERENGETI_CHEETAH
 
 config PCI_ROM_RUN
-	int
-	default 1
+	bool
+	default y
 	depends on BOARD_AMD_SERENGETI_CHEETAH