| Submitter | Patrick Georgi |
|---|---|
| Date | 2009-08-25 16:56:47 |
| Message ID | <1251219407.28873.14.camel@tetris> |
| Download | mbox | patch |
| Permalink | /patch/189/ |
| State | Accepted |
| Headers | show |
Comments
On Tue, Aug 25, 2009 at 10:56 AM, Patrick Georgi<patrick@georgi-clan.de> wrote: > In the mainboard selection, the selected mainboard is printed twice in > certain cases, this patch eliminates the second mention. > > This change might have unintended side-effects, but seems to work okay I'd rather fix the offending boards. Isn't it board-specific? Maybe I haven't seen all the cases. Myles
Am Dienstag, den 25.08.2009, 11:10 -0600 schrieb Myles Watson: > On Tue, Aug 25, 2009 at 10:56 AM, Patrick Georgi<patrick@georgi-clan.de> wrote: > > In the mainboard selection, the selected mainboard is printed twice in > > certain cases, this patch eliminates the second mention. > > > > This change might have unintended side-effects, but seems to work okay > I'd rather fix the offending boards. Isn't it board-specific? Maybe > I haven't seen all the cases. No, it's specific to the Kconfig source layout: choice config { THE BOARDS } config { THE BOARDS' DEPENDENCIES } endchoice To fix that, we'd have to do choice config { THE BOARDS } endchoice config { THE BOARDS' DEPENDENCIES } which doesn't work with the source statement Patrick
Patch
Index: mconf.c =================================================================== --- mconf.c (Revision 4577) +++ mconf.c (Arbeitskopie) @@ -506,11 +506,14 @@ if (def_menu) { item_add_str(" (%s)", _(menu_get_prompt(def_menu))); item_add_str(" --->"); +#if 0 +/* coreboot doesn't need this representation */ if (def_menu->list) { indent += 2; build_conf(def_menu); indent -= 2; } +#endif } return; }
In the mainboard selection, the selected mainboard is printed twice in certain cases, this patch eliminates the second mention. This change might have unintended side-effects, but seems to work okay Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>