Patchwork fintek f71859 sio

login
register
about
Submitter Marc Jones
Date 2010-09-10 03:49:38
Message ID <AANLkTikfEy2=ShTzAyUP64oB11gJJP8U5-WRf0_FTNf6@mail.gmail.com>
Download mbox | patch
Permalink /patch/1905/
State Accepted
Headers show

Comments

Marc Jones - 2010-09-10 03:49:38
I couldn't find any docs, but this gets the serial port to work.

Signed-off-by: Marc Jones <marcj303@gmail.com>

Marc
Uwe Hermann - 2010-09-10 07:26:08
Hi,

On Thu, Sep 09, 2010 at 09:49:38PM -0600, Marc Jones wrote:
> Index: src/superio/fintek/Kconfig
> ===================================================================
> --- src/superio/fintek/Kconfig	(revision 5799)
> +++ src/superio/fintek/Kconfig	(working copy)
> @@ -2,3 +2,5 @@
>  	bool
>  config SUPERIO_FINTEK_F71863FG
>  	bool
> +config SUPERIO_FINTEK_F71859
> +	bool
> Index: src/superio/fintek/f71859/f71859_early_serial.c
> ===================================================================
> --- src/superio/fintek/f71859/f71859_early_serial.c	(revision 0)
> +++ src/superio/fintek/f71859/f71859_early_serial.c	(revision 0)
> @@ -0,0 +1,46 @@
> +/*
> + * This file is part of the coreboot project.
> + *
> + * Copyright (C) 2007 Corey Osgood <corey@slightlyhackish.com>

You can make all those files
 * Copyright (C) 2010 Marc Jones <marcj303@gmail.com>
as each of them is trivial and cannot really be written differently.


> +/* Pre-RAM driver for the Fintek F71805F/FG Super I/O chip. */
                                    ^^^^^^^^^^
                                      F71859

Does your chip have an "F" suffix in the name as the above ones? If yes,
please add it to the name in the code/comments and file/directory names.


> Property changes on: src/superio/fintek/f71859/f71859_early_serial.c
> ___________________________________________________________________
> Added: svn:executable
>    + *

Please drop the executable property from all files, it's incorrect and
not needed.

 
> +/* This chip doesn't have keyboard and mouse support. */

Should probably be dropped unless you are sure the chip doesn't have
keyboard/mouse support.


> +/*
> + * Datasheet:
> +
> + */

Can be dropped.


With the above changes:
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>


Uwe.
Marc Jones - 2010-09-10 22:15:25
On Fri, Sep 10, 2010 at 1:26 AM, Uwe Hermann <uwe@hermann-uwe.de> wrote:
> Hi,
>
> On Thu, Sep 09, 2010 at 09:49:38PM -0600, Marc Jones wrote:
>> Index: src/superio/fintek/Kconfig
>> ===================================================================
>> --- src/superio/fintek/Kconfig        (revision 5799)
>> +++ src/superio/fintek/Kconfig        (working copy)
>> @@ -2,3 +2,5 @@
>>       bool
>>  config SUPERIO_FINTEK_F71863FG
>>       bool
>> +config SUPERIO_FINTEK_F71859
>> +     bool
>> Index: src/superio/fintek/f71859/f71859_early_serial.c
>> ===================================================================
>> --- src/superio/fintek/f71859/f71859_early_serial.c   (revision 0)
>> +++ src/superio/fintek/f71859/f71859_early_serial.c   (revision 0)
>> @@ -0,0 +1,46 @@
>> +/*
>> + * This file is part of the coreboot project.
>> + *
>> + * Copyright (C) 2007 Corey Osgood <corey@slightlyhackish.com>
>
> You can make all those files
>  * Copyright (C) 2010 Marc Jones <marcj303@gmail.com>
> as each of them is trivial and cannot really be written differently.
>
>
>> +/* Pre-RAM driver for the Fintek F71805F/FG Super I/O chip. */
>                                    ^^^^^^^^^^
>                                      F71859
>
> Does your chip have an "F" suffix in the name as the above ones? If yes,
> please add it to the name in the code/comments and file/directory names.
>
>
>> Property changes on: src/superio/fintek/f71859/f71859_early_serial.c
>> ___________________________________________________________________
>> Added: svn:executable
>>    + *
>
> Please drop the executable property from all files, it's incorrect and
> not needed.
>
>
>> +/* This chip doesn't have keyboard and mouse support. */
>
> Should probably be dropped unless you are sure the chip doesn't have
> keyboard/mouse support.
>
>
>> +/*
>> + * Datasheet:
>> +
>> + */
>
> Can be dropped.
>
>
> With the above changes:
> Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

I assume that you mean acked-by.

r 5802

Thanks!

Marc
Uwe Hermann - 2010-09-11 10:02:49
On Fri, Sep 10, 2010 at 04:15:25PM -0600, Marc Jones wrote:
> > With the above changes:
> > Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
> 
> I assume that you mean acked-by.
> 
> r 5802

Er, yes, sorry. Pressed the wrong button. I have Signed-off-by and
Acked-by lines being inserted upon pressing F4/F5 in vim.


Uwe.

Patch

Index: src/superio/fintek/Kconfig
===================================================================
--- src/superio/fintek/Kconfig	(revision 5799)
+++ src/superio/fintek/Kconfig	(working copy)
@@ -2,3 +2,5 @@ 
 	bool
 config SUPERIO_FINTEK_F71863FG
 	bool
+config SUPERIO_FINTEK_F71859
+	bool
Index: src/superio/fintek/f71859/f71859_early_serial.c
===================================================================
--- src/superio/fintek/f71859/f71859_early_serial.c	(revision 0)
+++ src/superio/fintek/f71859/f71859_early_serial.c	(revision 0)
@@ -0,0 +1,46 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2007 Corey Osgood <corey@slightlyhackish.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+/* Pre-RAM driver for the Fintek F71805F/FG Super I/O chip. */
+
+#include <arch/romcc_io.h>
+#include "f71859.h"
+
+static inline void pnp_enter_conf_state(device_t dev)
+{
+	unsigned int port = dev >> 8;
+	outb(0x87, port);
+}
+
+static void pnp_exit_conf_state(device_t dev)
+{
+	unsigned int port = dev >> 8;
+	outb(0xaa, port);
+}
+
+static void f71859_enable_serial(device_t dev, unsigned int iobase)
+{
+	pnp_enter_conf_state(dev);
+	pnp_set_logical_device(dev);
+	pnp_set_enable(dev, 0);
+	pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
+	pnp_set_enable(dev, 1);
+	pnp_exit_conf_state(dev);
+}

Property changes on: src/superio/fintek/f71859/f71859_early_serial.c
___________________________________________________________________
Added: svn:executable
   + *

Index: src/superio/fintek/f71859/Makefile.inc
===================================================================
--- src/superio/fintek/f71859/Makefile.inc	(revision 0)
+++ src/superio/fintek/f71859/Makefile.inc	(revision 0)
@@ -0,0 +1,22 @@ 
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2008 Corey Osgood <corey.osgood@gmail.com>
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+##
+
+#config chip.h
+obj-$(CONFIG_SUPERIO_FINTEK_F71859) += superio.o

Property changes on: src/superio/fintek/f71859/Makefile.inc
___________________________________________________________________
Added: svn:executable
   + *

Index: src/superio/fintek/f71859/superio.c
===================================================================
--- src/superio/fintek/f71859/superio.c	(revision 0)
+++ src/superio/fintek/f71859/superio.c	(revision 0)
@@ -0,0 +1,103 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2010 Marc Jones <marcj303@gmail.com>
+ * Copyright (C) 2008 Corey Osgood <corey.osgood@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+
+#include <arch/io.h>
+#include <device/device.h>
+#include <device/pnp.h>
+#include <console/console.h>
+#include <stdlib.h>
+#include <uart8250.h>
+#include "chip.h"
+#include "f71859.h"
+
+static void pnp_enter_conf_state(device_t dev)
+{
+	outb(0x87, dev->path.pnp.port);
+}
+
+static void pnp_exit_conf_state(device_t dev)
+{
+	outb(0xaa, dev->path.pnp.port);
+}
+
+static void f71859_init(device_t dev)
+{
+	struct superio_fintek_f71859_config *conf = dev->chip_info;
+	struct resource *res0;
+
+	if (!dev->enabled)
+		return;
+
+	switch(dev->path.pnp.device) {
+	/* TODO: Might potentially need code for HWM or FDC etc. */
+	case F71859_SP1:
+		res0 = find_resource(dev, PNP_IDX_IO0);
+		init_uart8250(res0->base, &conf->com1);
+		break;
+	}
+}
+
+static void f71859_pnp_set_resources(device_t dev)
+{
+	pnp_enter_conf_state(dev);
+	pnp_set_resources(dev);
+	pnp_exit_conf_state(dev);
+}
+
+static void f71859_pnp_enable_resources(device_t dev)
+{
+	pnp_enter_conf_state(dev);
+	pnp_enable_resources(dev);
+	pnp_exit_conf_state(dev);
+}
+
+static void f71859_pnp_enable(device_t dev)
+{
+	pnp_enter_conf_state(dev);
+	pnp_set_logical_device(dev);
+	(dev->enabled) ? pnp_set_enable(dev, 1) : pnp_set_enable(dev, 0);
+	pnp_exit_conf_state(dev);
+}
+
+static struct device_operations ops = {
+	.read_resources   = pnp_read_resources,
+	.set_resources    = f71859_pnp_set_resources,
+	.enable_resources = f71859_pnp_enable_resources,
+	.enable           = f71859_pnp_enable,
+	.init             = f71859_init,
+};
+
+static struct pnp_info pnp_dev_info[] = {
+	/* TODO: Some of the 0x7f8 etc. values may not be correct. */
+	{ &ops, F71859_SP1,  PNP_IO0 | PNP_IRQ0, { 0x7f8, 0 }, },
+
+};
+
+static void enable_dev(device_t dev)
+{
+	pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info);
+}
+
+struct chip_operations superio_fintek_f71859_ops = {
+	CHIP_NAME("Fintek F71859 Super I/O")
+	.enable_dev = enable_dev
+};

Property changes on: src/superio/fintek/f71859/superio.c
___________________________________________________________________
Added: svn:executable
   + *

Index: src/superio/fintek/f71859/chip.h
===================================================================
--- src/superio/fintek/f71859/chip.h	(revision 0)
+++ src/superio/fintek/f71859/chip.h	(revision 0)
@@ -0,0 +1,30 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2007 Corey Osgood <corey@slightlyhackish.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+#include <device/device.h>
+#include <uart8250.h>
+
+/* This chip doesn't have keyboard and mouse support. */
+
+extern struct chip_operations superio_fintek_f71859_ops;
+
+struct superio_fintek_f71859_config {
+	struct uart8250 com1, com2;
+};

Property changes on: src/superio/fintek/f71859/chip.h
___________________________________________________________________
Added: svn:executable
   + *

Index: src/superio/fintek/f71859/f71859.h
===================================================================
--- src/superio/fintek/f71859/f71859.h	(revision 0)
+++ src/superio/fintek/f71859/f71859.h	(revision 0)
@@ -0,0 +1,29 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2010 Marc Jones <marcj303@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+/*
+ * Datasheet:
+
+ */
+
+/* Logical Device Numbers (LDN). */
+
+#define F71859_SP1	0x03	/* UART1 */
+

Property changes on: src/superio/fintek/f71859/f71859.h
___________________________________________________________________
Added: svn:executable
   + *

Index: src/superio/fintek/Makefile.inc
===================================================================
--- src/superio/fintek/Makefile.inc	(revision 5799)
+++ src/superio/fintek/Makefile.inc	(working copy)
@@ -1,2 +1,3 @@ 
 subdirs-y += f71805f
 subdirs-y += f71863fg
+subdirs-y += f71859