Patchwork modify "make menuconfig" output

login
register
about
Submitter Myles Watson
Date 2009-08-25 20:13:33
Message ID <2831fecf0908251313v6e37a0aese081dd6c4676a117@mail.gmail.com>
Download mbox | patch
Permalink /patch/192/
State Superseded
Headers show

Comments

Myles Watson - 2009-08-25 20:13:33
On Tue, Aug 25, 2009 at 11:37 AM, Patrick Georgi<patrick@georgi-clan.de> wrote:
> Am Dienstag, den 25.08.2009, 11:10 -0600 schrieb Myles Watson:
>> On Tue, Aug 25, 2009 at 10:56 AM, Patrick Georgi<patrick@georgi-clan.de> wrote:
>> > In the mainboard selection, the selected mainboard is printed twice in
>> > certain cases, this patch eliminates the second mention.
>> >
>> > This change might have unintended side-effects, but seems to work okay
>> I'd rather fix the offending boards.  Isn't it board-specific?  Maybe
>> I haven't seen all the cases.
> No, it's specific to the Kconfig source layout:
>
> choice
> config { THE BOARDS }
> config { THE BOARDS' DEPENDENCIES }
> endchoice
>
> To fix that, we'd have to do
> choice
> config { THE BOARDS }
> endchoice
> config { THE BOARDS' DEPENDENCIES }
>
> which doesn't work with the source statement

How about this fix?

Signed-off-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles
Patrick Georgi - 2009-08-25 20:30:01
Am Dienstag, den 25.08.2009, 14:13 -0600 schrieb Myles Watson:
> How about this fix?
I thought about that, but it has the disadvantage that it spreads the
configuration of the board across two files.

I'm not sure what the best fix is...

Patrick
Myles Watson - 2009-08-25 20:34:22
On Tue, Aug 25, 2009 at 2:30 PM, Patrick Georgi<patrick@georgi-clan.de> wrote:
> Am Dienstag, den 25.08.2009, 14:13 -0600 schrieb Myles Watson:
>> How about this fix?
> I thought about that, but it has the disadvantage that it spreads the
> configuration of the board across two files.
Yes.

I'd like to think that much of the second file will disappear as
CONFIG_USE_DCACHE_RAM and others are moved to their final resting
places.  Then it might make sense to move the last few things like the
mainboard strings into the mainboard/<vendor>/Kconfig file.

> I'm not sure what the best fix is...

I guess the third option is live with it being printed twice.

Thanks,
Myles
Uwe Hermann - 2009-08-26 14:35:46
On Tue, Aug 25, 2009 at 02:34:22PM -0600, Myles Watson wrote:
> On Tue, Aug 25, 2009 at 2:30 PM, Patrick Georgi<patrick@georgi-clan.de> wrote:
> > Am Dienstag, den 25.08.2009, 14:13 -0600 schrieb Myles Watson:
> >> How about this fix?
> > I thought about that, but it has the disadvantage that it spreads the
> > configuration of the board across two files.
> Yes.

Indeed, and I think we should avoid that. The small proposed patch
is perfectly fine, IMHO.

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>


> I'd like to think that much of the second file will disappear as
> CONFIG_USE_DCACHE_RAM and others are moved to their final resting
> places.  Then it might make sense to move the last few things like the
> mainboard strings into the mainboard/<vendor>/Kconfig file.

I doubt this will always work, there are many per-board options that
will still be required, and they should really be in the board dir, IMHO.


> > I'm not sure what the best fix is...
> 
> I guess the third option is live with it being printed twice.

Nah, why should we? The fix is easy.


Uwe.
Myles Watson - 2009-08-26 15:07:22
> Nah, why should we? The fix is easy.

The point of Kconfig is that it is standard.  We had a custom config
tool already.

Thanks,
Myles
Uwe Hermann - 2009-08-26 17:03:29
On Wed, Aug 26, 2009 at 09:07:22AM -0600, Myles Watson wrote:
> > Nah, why should we? The fix is easy.
> 
> The point of Kconfig is that it is standard.  We had a custom config
> tool already.

Sure, I agree, but this small fix doesn't significantly change the
tool's usage in any way. Besides we already have small changes
against upstream's kconfig to adapt it to our needs anyway.


Uwe.

Patch

Index: src/mainboard/asus/Kconfig
===================================================================
--- src/mainboard/asus/Kconfig	(revision 4582)
+++ src/mainboard/asus/Kconfig	(working copy)
@@ -21,8 +21,22 @@ 
 choice
 	prompt "Mainboard model"
 	depends on VENDOR_ASUS
-	
-source "src/mainboard/asus/p2b-f/Kconfig"
 
+config BOARD_ASUS_P2B_F
+	bool "P2B-F"
+	select ARCH_X86
+	select CPU_INTEL_SLOT_2
+	select NORTHBRIDGE_INTEL_I440BX
+	select SOUTHBRIDGE_INTEL_I82371EB
+	select SUPERIO_WINBOND_W83977TF
+	select HAVE_PIRQ_TABLE
+	select UDELAY_IO
+	select PCI_ROM_RUN
+	select CONSOLE_VGA
+	help
+	  ASUS P2B-F mainboard.
+
 endchoice
 
+source "src/mainboard/asus/p2b-f/Kconfig"
+
Index: src/mainboard/asus/p2b-f/Kconfig
===================================================================
--- src/mainboard/asus/p2b-f/Kconfig	(revision 4582)
+++ src/mainboard/asus/p2b-f/Kconfig	(working copy)
@@ -18,20 +18,6 @@ 
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 ##
 
-config BOARD_ASUS_P2B_F
-	bool "P2B-F"
-	select ARCH_X86
-	select CPU_INTEL_SLOT_2
-	select NORTHBRIDGE_INTEL_I440BX
-	select SOUTHBRIDGE_INTEL_I82371EB
-	select SUPERIO_WINBOND_W83977TF
-	select HAVE_PIRQ_TABLE
-	select UDELAY_IO
-	select PCI_ROM_RUN
-	select CONSOLE_VGA
-	help
-	  ASUS P2B-F mainboard.
-
 config MAINBOARD_DIR
 	string
 	default asus/p2b-f