Patchwork fixed linking against libgcc in Kbuild

login
register
about
Submitter Cristi Magherusan
Date 2009-08-26 15:20:16
Message ID <1251300016.13506.3.camel@ufo>
Download mbox | patch
Permalink /patch/196/
State Accepted
Headers show

Comments

Cristi Magherusan - 2009-08-26 15:20:16
Hello,

See the attached (trivial) patch, inspired by the older buildsystem.
This fixes Myles' and my compilation issues.
ron minnich - 2009-08-26 15:30:10
On Wed, Aug 26, 2009 at 8:20 AM, Cristi
Magherusan<Cristi.Magherusan@net.utcluj.ro> wrote:
> Hello,
>
> See the attached (trivial) patch, inspired by the older buildsystem.
> This fixes Myles' and my compilation issues.

If we have name space collisions between coreboot and libgcc, what
will happen? If somebody links in something in libgcc that tries to do
a linux system call, what will happen?

If you're sure this is the way to go, then, with reluctance,

Acked-by: Ronald G. Minnich <rminnich@gmail.com>

(and only because Plan 9 is also linked against Plan 9's libc :-)
Harald Gutmann - 2009-08-26 15:36:02
On Wednesday 26 August 2009 17:20:16 Cristi Magherusan wrote:
> Hello,
>
> See the attached (trivial) patch, inspired by the older buildsystem.
> This fixes Myles' and my compilation issues.
And mine too!

Acked-by: Harald Gutmann <harald.gutmann@gmx.net>

revision 4584.

Kind regards,
Harald
Patrick Georgi - 2009-08-26 15:36:25
Am Mittwoch, den 26.08.2009, 08:30 -0700 schrieb ron minnich:
> Acked-by: Ronald G. Minnich <rminnich@gmail.com>
> 
> (and only because Plan 9 is also linked against Plan 9's libc :-)
> 
libgcc != libc

And if someone actually uses the system compiler (a generic i386-elf
compiler has no OS dependencies in the resulting code, except for bugs),
they're on their own anyway.


Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>

Patrick
Myles Watson - 2009-08-26 15:42:40
> See the attached (trivial) patch, inspired by the older buildsystem.
> This fixes Myles' and my compilation issues.
Thanks!
Myles

Patch

From da7c36bac330126373c02fbc801c084f7bc336e3 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Cristi=20M=C4=83gheru=C8=99an?= <cristi.magherusan@net.utcluj.ro>
Date: Wed, 26 Aug 2009 18:08:18 +0300
Subject: [PATCH] added libgcc to Kbuild

---

 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile

index e8af463..aa4e8ab 100644

--- a/Makefile

+++ b/Makefile

@@ -66,6 +66,8 @@  HOSTCXX = g++

 HOSTCFLAGS := -I$(srck) -I$(objk) -g
 HOSTCXXFLAGS := -I$(srck) -I$(objk)
 
+LIBGCC_FILE_NAME := $(shell $(CC) -print-libgcc-file-name)

+

 DESTDIR = /opt
 
 DOXYGEN := doxygen
-- 

1.6.0.4