Patchwork ASUS M2V-MX SE kconfig fixes trunk/coreboot-v2/src/mainboard/asus: . m2v-mx_se

login
register
about
Submitter Uwe Hermann
Date 2009-08-26 17:27:51
Message ID <20090826172751.GF7448@greenwood>
Download mbox | patch
Permalink /patch/199/
State Accepted
Headers show

Comments

Uwe Hermann - 2009-08-26 17:27:51
On Wed, Aug 26, 2009 at 06:55:06PM +0200, svn@coreboot.org wrote:
> Asus M2V-MX-SE support in Kbuild
> 
> Signed-off-by: Cristi Magherusan <cristi.magherusan@net.utcluj.ro>
> Acked-by: Ronald G. Minnich <rminnich@gmail.com>

Here's a bunch of simplifications and improvements. I haven't checked
all the options from Config.lb and Options.lb against kconfig yet,
just looked at what was there already in Kconfig.


Uwe.

Patch

Simplify ASUS M2V-MX SE kconfig a bit.

 - "bool"s that are set to y can be "select FOO" instead (shorter).

 - MAINBOARD_VENDOR is no longer needed, it's defined already.

 - Correct board name is "M2V-MX SE", not "M2V-MX-SE".

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Index: src/mainboard/asus/m2v-mx_se/Kconfig
===================================================================
--- src/mainboard/asus/m2v-mx_se/Kconfig	(Revision 4586)
+++ src/mainboard/asus/m2v-mx_se/Kconfig	(Arbeitskopie)
@@ -19,7 +19,7 @@ 
 ##
 
 config BOARD_ASUS_M2V_MX_SE
-	bool "M2V-MX-SE"
+	bool "M2V-MX SE"
 	select ARCH_X86
 	select CPU_AMD_K8
 	select CPU_AMD_SOCKET_AM2
@@ -29,19 +29,19 @@ 
 	select SOUTHBRIDGE_VIA_K8T890
 	select SUPERIO_ITE_IT8712F
 	select USE_PRINTK_IN_CAR
+	select USE_DCACHE_RAM
+	select HAVE_HARD_RESET
+	select IOAPIC
+	select HAVE_OPTION_TABLE
+	select HAVE_ACPI_TABLES
 	help
-	  Asus M2V-MX-SE mainboard.
+	  Asus M2V-MX SE mainboard.
 
 config MAINBOARD_DIR
 	string
 	default asus/m2v-mx_se
 	depends on BOARD_ASUS_M2V_MX_SE
 
-config USE_DCACHE_RAM
-	bool
-	dafault y
-	depends on BOARD_ASUS_M2V_MX_SE
-
 config DCACHE_RAM_BASE
 	hex
 	default 0xcc000
@@ -62,21 +62,6 @@ 
 	default 0x10
 	depends on BOARD_ASUS_M2V_MX_SE
 
-config HAVE_HARD_RESET
-	bool
-	default y
-	depends on BOARD_ASUS_M2V_MX_SE
-
-config IOAPIC
-	bool
-	default y
-	depends on BOARD_ASUS_M2V_MX_SE
-
-config MAINBOARD_VENDOR
-	string
-	default "ASUS"
-	depends on BOARD_ASUS_M2V_MX_SE
-
 config MAINBOARD_PART_NUMBER
 	string
 	default "M2V-MX SE"
@@ -102,17 +87,6 @@ 
 	default 262144
 	depends on BOARD_ASUS_M2V_MX_SE
 
-config HAVE_OPTION_TABLE
-	bool
-	default y
-	depends on BOARD_ASUS_M2V_MX_SE
-
-config HAVE_ACPI_TABLES
-	bool
-	default y
-	depends on BOARD_ASUS_M2V_MX_SE
-
-
 config LB_CKS_RANGE_END
 	int
 	default 122