Patchwork drop meaningless K8_4RANK_DIMM_SUPPORT define

login
register
about
Submitter Jonathan A. Kollasch
Date 2010-10-01 01:03:27
Message ID <20101001010326.GB12447@tarantulon.kollasch.net>
Download mbox | patch
Permalink /patch/2013/
State Accepted
Commit r5905
Headers show

Comments

Jonathan A. Kollasch - 2010-10-01 01:03:27
Don't define K8_4RANK_DIMM_SUPPORT, nothing uses it.
All these boards define QRANK_DIMM_SUPPORT anyway,
which is probably what was meant.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
---
Uwe Hermann - 2010-10-02 14:07:39
On Fri, Oct 01, 2010 at 01:03:27AM +0000, Jonathan A. Kollasch wrote:
> Don't define K8_4RANK_DIMM_SUPPORT, nothing uses it.
> All these boards define QRANK_DIMM_SUPPORT anyway,
> which is probably what was meant.

Indeed.

 
> Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>

Thanks, r5905.


Uwe.

Patch

Index: src/mainboard/msi/ms9282/romstage.c
===================================================================
--- src/mainboard/msi/ms9282/romstage.c	(revision 5888)
+++ src/mainboard/msi/ms9282/romstage.c	(working copy)
@@ -96,8 +96,6 @@ 
        return smbus_read_byte(device, address);
 }
 
-//#define K8_4RANK_DIMM_SUPPORT 1
-
 #include "northbridge/amd/amdk8/amdk8_f.h"
 #include "northbridge/amd/amdk8/incoherent_ht.c"
 #include "northbridge/amd/amdk8/coherent_ht.c"
Index: src/mainboard/asus/a8v-e_se/romstage.c
===================================================================
--- src/mainboard/asus/a8v-e_se/romstage.c	(revision 5888)
+++ src/mainboard/asus/a8v-e_se/romstage.c	(working copy)
@@ -100,8 +100,6 @@ 
 // defines S3_NVRAM_EARLY:
 #include "southbridge/via/k8t890/k8t890_early_car.c"
 
-#define K8_4RANK_DIMM_SUPPORT 1
-
 #include "northbridge/amd/amdk8/amdk8.h"
 #include "northbridge/amd/amdk8/incoherent_ht.c"
 #include "northbridge/amd/amdk8/coherent_ht.c"
Index: src/mainboard/asus/m2v-mx_se/romstage.c
===================================================================
--- src/mainboard/asus/m2v-mx_se/romstage.c	(revision 5888)
+++ src/mainboard/asus/m2v-mx_se/romstage.c	(working copy)
@@ -82,8 +82,6 @@ 
 // defines S3_NVRAM_EARLY:
 #include "southbridge/via/k8t890/k8t890_early_car.c"
 
-#define K8_4RANK_DIMM_SUPPORT 1
-
 #include "northbridge/amd/amdk8/amdk8.h"
 #include "northbridge/amd/amdk8/incoherent_ht.c"
 #include "northbridge/amd/amdk8/coherent_ht.c"