| Submitter | Warren Turkal |
|---|---|
| Date | 2010-10-01 10:51:44 |
| Message ID | <1285930304-19097-1-git-send-email-wt@penguintechs.org> |
| Download | mbox | patch |
| Permalink | /patch/2018/ |
| State | Rejected |
| Headers | show |
Comments
On 10/1/10 12:51 PM, Warren Turkal wrote: > This change gets the board building again. Since it is late here, I am > going to go to sleep. Anyone can feel free to commit this change if they > ack it. NACK! Please don't go back to big bootblock. Instead rather fix the code. Stefan
For what it's worth, I agree. I will look into this more after I wake up. wt On Fri, Oct 1, 2010 at 4:38 AM, Stefan Reinauer <stefan.reinauer@coresystems.de> wrote: > On 10/1/10 12:51 PM, Warren Turkal wrote: >> This change gets the board building again. Since it is late here, I am >> going to go to sleep. Anyone can feel free to commit this change if they >> ack it. > NACK! Please don't go back to big bootblock. Instead rather fix the code. > > Stefan > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot >
Patch
diff --git a/src/mainboard/via/vt8454c/Kconfig b/src/mainboard/via/vt8454c/Kconfig index 6c08007..3ef94a3 100644 --- a/src/mainboard/via/vt8454c/Kconfig +++ b/src/mainboard/via/vt8454c/Kconfig @@ -14,7 +14,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_HARD_RESET select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_512 - select TINY_BOOTBLOCK +# select TINY_BOOTBLOCK config MAINBOARD_DIR string
This change gets the board building again. Since it is late here, I am going to go to sleep. Anyone can feel free to commit this change if they ack it. Thanks, wt 8<------------------------------------------------------------------- The tiny boot block breaks cache-as-ram for this board. Specifically, the crt0s.romstage.o target will not build without this change. Signed-off-by: Warren Turkal <wt@penguintechs.org> --- src/mainboard/via/vt8454c/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)