Patchwork AMD SB600 uses a hardcoded USB Debug Port number

login
register
about
Submitter Uwe Hermann
Date 2010-10-02 15:49:48
Message ID <20101002154948.GB3256@greenwood>
Download mbox | patch
Permalink /patch/2025/
State Accepted
Commit r5906
Headers show

Comments

Uwe Hermann - 2010-10-02 15:49:48
See patch.

Will post a patch for changing the port on SB700 soon, on that
southbridge it is indeed possible according to the datasheet.


Uwe.
Peter Stuge - 2010-10-02 19:02:38
Uwe Hermann wrote:
> AMD SB600 uses a hardcoded USB Debug Port number.
> 
> It cannot be changed via software according to the datasheet, whereas
> this is indeed possible on AMD SB700. I tested using the SB700 mechanism
> on SB600 but it didn't work, so I suspect the datasheet is indeed correct.
> 
> Thus, don't show the kconfig option for selecting the physical USB port
> on the AMD SB600 southbridge.
> 
> Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Acked-by: Peter Stuge <peter@stuge.se>

Patch

AMD SB600 uses a hardcoded USB Debug Port number.

It cannot be changed via software according to the datasheet, whereas
this is indeed possible on AMD SB700. I tested using the SB700 mechanism
on SB600 but it didn't work, so I suspect the datasheet is indeed correct.

Thus, don't show the kconfig option for selecting the physical USB port
on the AMD SB600 southbridge.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Index: src/console/Kconfig
===================================================================
--- src/console/Kconfig	(Revision 5903)
+++ src/console/Kconfig	(Arbeitskopie)
@@ -112,13 +112,13 @@ 
 
 	  If unsure, say N.
 
-# Note: This option doesn't make sense on Intel ICH southbridges as those
-# hardcode the physical USB port to be used as Debug Port to 1. It cannot
-# be changed by coreboot.
+# Note: This option doesn't make sense on Intel ICH / AMD SB600 southbridges
+# as those hardcode the physical USB port to be used as Debug Port to 1.
+# It cannot be changed by coreboot.
 config USBDEBUG_DEFAULT_PORT
 	int "Default USB port to use as Debug Port"
 	default 1
-	depends on USBDEBUG && !SOUTHBRIDGE_INTEL_I82801GX
+	depends on USBDEBUG && !SOUTHBRIDGE_INTEL_I82801GX && !SOUTHBRIDGE_AMD_SB600
 	help
 	  This option selects which physical USB port coreboot will try to
 	  use as EHCI Debug Port first (valid values are: 1-15).