Patchwork Enable or disable the power button in Kconfig

login
register
about
Submitter Jens Rottmann
Date 2010-10-05 15:25:20
Message ID <4CAB4360.7020805@LiPPERTEmbedded.de>
Download mbox | patch
Permalink /patch/2043/
State Accepted
Headers show

Comments

Jens Rottmann - 2010-10-05 15:25:20
Hi Peter,

sorry for the delay, was on vacation.

Nice new feature!  :)

> please confirm if my understanding of the old vs. new
> hurricane-lx board version vs. power button behavior is correct.

Yes, your patch correctly preserves current behavior.

However, I'd like to make use of your nice new feature and give the user
the option to enable the button after they have removed the jumper -
patch attached.

Thanks a lot!!
Jens
Peter Stuge - 2010-10-13 06:24:23
Jens Rottmann wrote:
> I'd like to make use of your nice new feature and give the user
> the option to enable the button after they have removed the jumper
> - patch attached.

Thanks. I included your chane.


Nils wrote:
> I tested your patch on the Wyse S50 (r5901) and it seems to work ok.
> So:
> Acked-by: Nils Jacobs <njacobs8@hetnet.nl>

Thanks! Commited as r5948


//Peter

Patch

--- src/mainboard/lippert/hurricane-lx/Kconfig	(rev 5911 + Peter)
+++ src/mainboard/lippert/hurricane-lx/Kconfig	(working copy)
@@ -29,15 +29,16 @@ 
 config BOARD_OLD_REVISION
 	bool "Board is old pre-3.0 revision"
 	default n
-	select POWER_BUTTON_FORCE_DISABLE
+	select POWER_BUTTON_DEFAULT_DISABLE
 	help
 	  Look on the bottom side for a number like 406-0001-30.  The last 2
 	  digits state the PCB revision (3.0 in this example).  For 2.0 or older
 	  boards choose Y, for 3.0 and newer say N.
 
-	  Old revision boards need a jumper shorting the power button to
-	  power on automatically. So we must disable the button's fail-safe
-	  function, or the board will shut down after 4 s.
+	  Old revision boards need a jumper shorting the power button to power on
+	  automatically.  You may enable the button only after this jumper has
+	  been removed.  New revision boards are not restricted in this way, the
+	  button is always enabled.
 
 config POWER_BUTTON_FORCE_ENABLE
 	def_bool y if !BOARD_OLD_REVISION