From patchwork Wed Oct  6 20:38:05 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: correct setting of non-posted option in RS780 function
 ProgK8TempMmioBase
Date: Wed, 06 Oct 2010 20:38:05 -0000
From: Scott <scott@notabs.org>
X-Patchwork-Id: 2056
Message-Id: <721C8A8F37F249368A6A4AE4B4C3D9B1@m3a78>
To: <coreboot@coreboot.org>

RS780 function ProgK8TempMmioBase is setting a reserved
bit in the AMD processor 'MMIO Limit Address Register'.
I suspect it is because of a typo where 0x80 was entered
as 0x8. If 0x80 is used, then the strap configuration
register accesses become non-posted, which is how the
Shiner reference BIOS does it.

Thanks,
Scott

Signed-off-by: Scott Duplichan <scott@notabs.org>
Acked-by: Rudolf Marek <r.marek@assembler.cz>


Index: src/southbridge/amd/rs780/rs780_cmn.c
===================================================================
--- src/southbridge/amd/rs780/rs780_cmn.c       (revision 5917)
+++ src/southbridge/amd/rs780/rs780_cmn.c       (working copy)
@@ -204,7 +204,7 @@
        if (in_out) {
                pci_write_config32(k8_f1, 0xbc,
                                   (((pcie_base_add + 0x10000000 -
-                                    1) >> 8) & 0xffffff00) | 0x8);
+                                    1) >> 8) & 0xffffff00) | 0x80); //non-posted
                pci_write_config32(k8_f1, 0xb8, (pcie_base_add >> 8) | 0x3);
                pci_write_config32(k8_f1, 0xb4,
                                   ((mmio_base_add + 0x10000000 -