Patchwork Slot 1 regression! Asus P2B/P3B boards no longer boots with model_6bx CPUs

login
register
about
Submitter Keith Hui
Date 2010-10-12 01:19:30
Message ID <AANLkTimDoYF9=SJxhde2hUdY0gTrEHjo=hEV74vXO775@mail.gmail.com>
Download mbox | patch
Permalink /patch/2098/
State Superseded
Headers show

Comments

Keith Hui - 2010-10-12 01:19:30
Guys,

I could no longer boot my P3B-F with my Tualeron and r5938. Dies with
"unknown CPU". I believe it will happen with any Slot 1 440BX boards
that supports model_6bx CPUs.

I need to make the change below to make it work. abuild tested. Boot
tested on P2B-LS and P3B-F.

After we split the rest of the P6 family from model_6xx, a similar
change will need to be made here.

Signed-off-by: Keith Hui <buurin@gmail.com>

8<-------------------------
Idwer Vollering - 2010-10-12 01:41:34
2010/10/12 Keith Hui <buurin@gmail.com>

> Guys,
>

Hi Keith,

>
> I could no longer boot my P3B-F with my Tualeron and r5938. Dies with
> "unknown CPU". I believe it will happen with any Slot 1 440BX boards
> that supports model_6bx CPUs.
>

Can you confirm that this changeset caused the regression:
http://tracker.coreboot.org/trac/coreboot/changeset/5909 ?

>
> I need to make the change below to make it work. abuild tested. Boot
> tested on P2B-LS and P3B-F.
>

In which directory does this changed file reside, src/cpu/intel/slot_1/ or
src/cpu/intel/model_6bx/ ?


> After we split the rest of the P6 family from model_6xx, a similar
> change will need to be made here.
>
> Signed-off-by: Keith Hui <buurin@gmail.com>
>
> 8<-------------------------
> Index: Makefile.inc
> ===================================================================
> --- Makefile.inc        (revision 5938)
> +++ Makefile.inc        (working copy)
> @@ -20,6 +20,7 @@
>
>  ramstage-y += slot_1.c
>  subdirs-y += ../model_6xx
> +subdirs-y += ../model_6bx
>  subdirs-y += ../../x86/tsc
>  subdirs-y += ../../x86/mtrr
>  subdirs-y += ../../x86/lapic
>
> --
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>

Patch

Index: Makefile.inc
===================================================================
--- Makefile.inc	(revision 5938)
+++ Makefile.inc	(working copy)
@@ -20,6 +20,7 @@ 

 ramstage-y += slot_1.c
 subdirs-y += ../model_6xx
+subdirs-y += ../model_6bx
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/lapic