Patchwork Mark w25q80 as writable

login
register
about
Submitter David Hendricks
Date 2010-10-14 04:24:41
Message ID <AANLkTinG=mu9Z5CdDiJFW0MmKmUVu8TTJ1fyMPYspfdV@mail.gmail.com>
Download mbox | patch
Permalink /patch/2105/
State Superseded
Headers show

Comments

David Hendricks - 2010-10-14 04:24:41
patch attached.

Tested on a W25Q80...

Signed-off-by: David Hendricks <dhendrix@google.com>
Stefan Reinauer - 2010-10-18 23:15:15
* David Hendricks <dhendrix@google.com> [101014 06:24]:
> patch attached.
> 
> Tested on a W25Q80...
> 
> Signed-off-by: David Hendricks <dhendrix@google.com>
> 
> --
> David Hendricks (dhendrix)
> Systems Software Engineer, Google Inc.

It seems this is included in the patch you sent on 2010-10-15
However,

Acked-by: Stefan Reinauer <stepan@coreboot.org>


> Index: flashchips.c
> ===================================================================
> --- flashchips.c	(revision 1209)
> +++ flashchips.c	(working copy)
> @@ -7008,7 +7008,7 @@
>  		.total_size	= 1024,
>  		.page_size	= 256,
>  		.feature_bits	= FEATURE_WRSR_WREN,
> -		.tested		= TEST_OK_PRE,
> +		.tested		= TEST_OK_PREW,
>  		.probe		= probe_spi_rdid,
>  		.probe_timing	= TIMING_ZERO,
>  		.block_erasers	=
David Hendricks - 2010-10-18 23:18:10
On Mon, Oct 18, 2010 at 4:15 PM, Stefan Reinauer <stepan@coreboot.org>wrote:

> * David Hendricks <dhendrix@google.com> [101014 06:24]:
> > patch attached.
> >
> > Tested on a W25Q80...
> >
> > Signed-off-by: David Hendricks <dhendrix@google.com>
> >
> > --
> > David Hendricks (dhendrix)
> > Systems Software Engineer, Google Inc.
>
> It seems this is included in the patch you sent on 2010-10-15
> However,
>
> Acked-by: Stefan Reinauer <stepan@coreboot.org>
>

Yeah, I was testing a patch using one system, came up with this patch, and
then continued to test on more systems with different winbond chips. I
should've revised this patch rather than sending a new one... sorry for the
dupe, and thanks for the ack!


>
> > Index: flashchips.c
> > ===================================================================
> > --- flashchips.c      (revision 1209)
> > +++ flashchips.c      (working copy)
> > @@ -7008,7 +7008,7 @@
> >               .total_size     = 1024,
> >               .page_size      = 256,
> >               .feature_bits   = FEATURE_WRSR_WREN,
> > -             .tested         = TEST_OK_PRE,
> > +             .tested         = TEST_OK_PREW,
> >               .probe          = probe_spi_rdid,
> >               .probe_timing   = TIMING_ZERO,
> >               .block_erasers  =
>
>

Patch

Index: flashchips.c
===================================================================
--- flashchips.c	(revision 1209)
+++ flashchips.c	(working copy)
@@ -7008,7 +7008,7 @@ 
 		.total_size	= 1024,
 		.page_size	= 256,
 		.feature_bits	= FEATURE_WRSR_WREN,
-		.tested		= TEST_OK_PRE,
+		.tested		= TEST_OK_PREW,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
 		.block_erasers	=